Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-20 Thread graham
LGTM https://codereview.appspot.com/6940064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread tdanielsmusic
LGTM https://codereview.appspot.com/6940064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread tdanielsmusic
On 2012/12/17 21:01:29, mail_philholmes.net wrote: I hear what Trevor says (that they do work capitalised) but if we have them non-capitalised in our code, that also should be changed, since it doesn't follow the standard. Presumably somewhere the entered name is lower-cased, so the scm fi

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread Phil Holmes
- Original Message - From: To: ; ; ; Cc: ; Sent: Monday, December 17, 2012 5:38 PM Subject: Re: Doc: NR typo for Midi Instuments used in example (issue 6940064) On 2012/12/17 17:21:39, email_philholmes.net wrote: - Original Message - From: <mailto:tdaniel

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread pkx166h
new patch uploaded https://codereview.appspot.com/6940064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread pkx166h
Reviewers: phileholmes_googlemail.com, Trevor Daniels, email_philholmes.net, dak, Message: On 2012/12/17 19:44:18, Trevor Daniels wrote: On 2012/12/17 17:38:46, dak wrote: > > The capitalized versions just won't work for that reason. Actually, they do work if capitalised. I don't know why

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread tdanielsmusic
On 2012/12/17 17:38:46, dak wrote: The capitalized versions just won't work for that reason. Actually, they do work if capitalised. I don't know why or how - I just do the experiment ;) Trevor https://codereview.appspot.com/6940064/ ___ lilypon

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread dak
: NR typo for Midi Instuments used in example (issue 6940064) > I'd prefer it if the MIDI instruments in this patch > were not capitalised, in order to be consistent with > the rest of the documentation and in particular with > Appendix A6. I've no objection in principle to

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread Phil Holmes
- Original Message - From: To: ; Cc: ; Sent: Monday, December 17, 2012 11:27 AM Subject: Re: Doc: NR typo for Midi Instuments used in example (issue 6940064) I'd prefer it if the MIDI instruments in this patch were not capitalised, in order to be consistent with the rest o

Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-17 Thread tdanielsmusic
I'd prefer it if the MIDI instruments in this patch were not capitalised, in order to be consistent with the rest of the documentation and in particular with Appendix A6. I've no objection in principle to capitalising the names, but it should be done consistently throughout the documentation as a

Doc: NR typo for Midi Instuments used in example (issue 6940064)

2012-12-16 Thread PhilEHolmes
LGTM https://codereview.appspot.com/6940064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel