----- Original Message -----
From: <d...@gnu.org>
To: <pkx1...@gmail.com>; <philehol...@googlemail.com>;
<tdanielsmu...@googlemail.com>; <em...@philholmes.net>
Cc: <re...@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Monday, December 17, 2012 5:38 PM
Subject: Re: Doc: NR typo for Midi Instuments used in example (issue
6940064)
On 2012/12/17 17:21:39, email_philholmes.net wrote:
----- Original Message -----
From: <mailto:tdanielsmu...@googlemail.com>
To: <pkx1...@gmail.com>; <mailto:philehol...@googlemail.com>
Cc: <lilypond-devel@gnu.org>;
<mailto:re...@codereview-hr.appspotmail.com>
Sent: Monday, December 17, 2012 11:27 AM
Subject: Re: Doc: NR typo for Midi Instuments used in example (issue
6940064)
> I'd prefer it if the MIDI instruments in this patch
> were not capitalised, in order to be consistent with
> the rest of the documentation and in particular with
> Appendix A6. I've no objection in principle to
> capitalising the names, but it should be done
> consistently throughout the documentation as a
> separate patch.
>
> Otherwise LGTM
>
> Trevor
>
>
> https://codereview.appspot.com/6940064/
I definitely think they should all be capitalised. See, for example,
http://www.midi.org/techspecs/gm1sound.php
It is not a matter of preference. The definitions in scm/midi.scm
(instrument-names-alist) are lowercase, and LilyPond uses assoc-get in
midi-program for looking them up, which is case-sensitive.
The capitalized versions just won't work for that reason.
https://codereview.appspot.com/6940064/
I hear what Trevor says (that they do work capitalised) but if we have them
non-capitalised in our code, that also should be changed, since it doesn't
follow the standard.
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
