Re: Doc: NR: Reformat ly code. (issue1242044)

2010-05-25 Thread percival . music . ca
I managed to trudge through another 4 or 5 files. Look, this is ridiculous. I'm officially rejecting this patch because it's **WAY** too long for anybody to look at. Please break this into separate patches, where each patch is 1500 lines or less. If a single file has more than 1500 diff-lines,

Re: Doc: NR: Reformat ly code. (issue1242044)

2010-05-25 Thread percival . music . ca
I only had time to examine changing-defaults. I'll review the other files tonight. http://codereview.appspot.com/1242044/diff/30002/34001 File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/1242044/diff/30002/34001#newcode357 Documentation/notation/changi

Re: Doc: NR: Reformat ly code. (issue1242044)

2010-05-24 Thread markpolesky
Reviewers: Graham Percival, Message: Patch set 3 uploaded Would anyone else like to review this patch? Thanks - Mark http://codereview.appspot.com/1242044/diff/2001/3010 File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/1242044/diff/2001/3010#newcode2724 Docume

Re: Doc: NR: Reformat ly code. (issue1242044)

2010-05-23 Thread Mark Polesky
Patch set 3 uploaded. http://codereview.appspot.com/1242044 I replied to Graham's comments there, but a copy of my reply apparently wasn't sent to the lilypond-devel mailing list, despite having set the cc field accordingly (or so I thought). Would anyone else like to review this patch? Thanks -

Doc: NR: Reformat ly code. (issue1242044)

2010-05-22 Thread percival . music . ca
Well, there's 40 minutes of my 60 minutes of lilypond work for today done. What's the first thing we tell new doc contributors? Send small patches. I think this applies here. http://codereview.appspot.com/1242044/diff/2001/3001 File Documentation/notation/changing-defaults.itely (right): htt