Reviewers: Graham Percival, Message: Patch set 3 uploaded
Would anyone else like to review this patch? Thanks - Mark http://codereview.appspot.com/1242044/diff/2001/3010 File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/1242044/diff/2001/3010#newcode2724 Documentation/notation/pitches.itely:2724: \aikenHeadsMinor On 2010/05/22 08:10:42, Graham Percival wrote:
err, why?
why what? http://codereview.appspot.com/1242044/diff/2001/3015 File Documentation/notation/staff.itely (right): http://codereview.appspot.com/1242044/diff/2001/3015#newcode1373 Documentation/notation/staff.itely:1373: { \voiceTwo d4. bes4 c8 } On 2010/05/22 08:10:42, Graham Percival wrote:
WTM are the \voiceTwo and \voiceOne doing here? Do they contribute to a tiny example?
The current version uses \StemDown and \StemUp for the main voice, and relies on the cue pitches for its stem directions, which all happen to point up in this particular case. I think the \voiceOne (etc.) commands are preferable here. Description: Doc: NR: Reformat ly code. Please review this at http://codereview.appspot.com/1242044/show Affected files: M Documentation/notation/changing-defaults.itely M Documentation/notation/cheatsheet.itely M Documentation/notation/chords.itely M Documentation/notation/editorial.itely M Documentation/notation/expressive.itely M Documentation/notation/fretted-strings.itely M Documentation/notation/input.itely M Documentation/notation/keyboards.itely M Documentation/notation/percussion.itely M Documentation/notation/pitches.itely M Documentation/notation/repeats.itely M Documentation/notation/rhythms.itely M Documentation/notation/simultaneous.itely M Documentation/notation/spacing.itely M Documentation/notation/staff.itely M Documentation/notation/text.itely M Documentation/notation/unfretted-strings.itely M Documentation/notation/vocal.itely M Documentation/notation/wind.itely M Documentation/notation/world.itely _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
