Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-07 Thread Graham Percival
On Fri, May 07, 2010 at 01:31:35PM -0700, Mark Polesky wrote: > Graham Percival wrote: > > http://codereview.appspot.com/1056041/diff/33001/27003#newcode2481 > > Documentation/learning/fundamental.itely:2481: << > > There is *still* an indentation mistake here. This is the > > third time I've poin

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-07 Thread Mark Polesky
Graham Percival wrote: > http://codereview.appspot.com/1056041/diff/33001/27003#newcode2481 > Documentation/learning/fundamental.itely:2481: << > There is *still* an indentation mistake here. This is the > third time I've pointed it out -- do we disagree on the > "two-space indents" rule? Graham,

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-07 Thread percival . music . ca
Looks (mostly) good to me, other than the below 2 items. http://codereview.appspot.com/1056041/diff/33001/27003 File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/1056041/diff/33001/27003#newcode1339 Documentation/learning/fundamental.itely:1339: @c TODO: This

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-07 Thread Mark Polesky
patch set 4 is up: http://codereview.appspot.com/1056041 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-06 Thread percival . music . ca
Looking much closer now. http://codereview.appspot.com/1056041/diff/24001/25001 File Documentation/learning/common-notation.itely (right): http://codereview.appspot.com/1056041/diff/24001/25001#newcode147 Documentation/learning/common-notation.itely:147: a1 | This example doesn't need a bar che

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-06 Thread tdanielsmusic
Mark I've not examined every change in detail, but I think I've picked out all the ones I wanted to comment on. Trevor http://codereview.appspot.com/1056041/diff/24001/25001 File Documentation/learning/common-notation.itely (right): http://codereview.appspot.com/1056041/diff/24001/25001#newcode

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-06 Thread Graham Percival
On Wed, May 05, 2010 at 06:31:21PM -0600, Carl Sorensen wrote: > On 5/5/10 6:11 PM, "Graham Percival" wrote: > > >>> sweet mao... you're adding barline checks to every single example?! > OK. Final barline checks on examples where they add to the clarity of *that > particular* examples would be

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-06 Thread percival . music . ca
I've only reviewed the first file. I don't think that reviewing more would do good; we're still debating simple things like "should there be a barline check at the end of every single line". Seeing a patch doesn't help with that debate. At the same time, there's good changes -- like adding expl

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-06 Thread Mark Polesky
Patch set 3 uploaded. http://codereview.appspot.com/1056041 Hope this isn't driving you crazy. - Mark ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-05 Thread Graham Percival
On Wed, May 05, 2010 at 06:04:42PM -0600, Carl Sorensen wrote: > > On 5/5/10 12:01 PM, "Graham Percival" wrote: > > > On Wed, May 5, 2010 at 11:57 AM, wrote: > >> I think it's an improvement.  I've made specific comments inline. > > > > sweet mao... you're adding barline checks to every singl

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-05 Thread Carl Sorensen
On 5/5/10 6:11 PM, "Graham Percival" wrote: > On Wed, May 05, 2010 at 06:04:42PM -0600, Carl Sorensen wrote: >> >> On 5/5/10 12:01 PM, "Graham Percival" wrote: >> >>> On Wed, May 5, 2010 at 11:57 AM, wrote: I think it's an improvement.  I've made specific comments inline. >>> >>> sweet

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-05 Thread Carl Sorensen
On 5/5/10 12:01 PM, "Graham Percival" wrote: > On Wed, May 5, 2010 at 11:57 AM, wrote: >> I think it's an improvement.  I've made specific comments inline. > > sweet mao... you're adding barline checks to every single example?! > > cis4 ees fisis, aeses | > > I definitely do **not** lik

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-05 Thread Graham Percival
On Wed, May 5, 2010 at 11:57 AM, wrote: > I think it's an improvement.  I've made specific comments inline. sweet mao... you're adding barline checks to every single example?! cis4 ees fisis, aeses | I definitely do **not** like this. cis4 ees fisis, aeses is just fine to read. If there's

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-05 Thread Carl . D . Sorensen
Hi Mark, I think it's an improvement. I've made specific comments inline. Thanks! Carl http://codereview.appspot.com/1056041/diff/11001/12001 File Documentation/learning/common-notation.itely (right): http://codereview.appspot.com/1056041/diff/11001/12001#newcode313 Documentation/learning/

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-03 Thread Carl . D . Sorensen
http://codereview.appspot.com/1056041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-03 Thread Carl . D . Sorensen
http://codereview.appspot.com/1056041/diff/1/2 File Documentation/learning/common-notation.itely (right): http://codereview.appspot.com/1056041/diff/1/2#newcode101 Documentation/learning/common-notation.itely:101: aeses1 On 2010/05/03 14:19:08, Graham Percival wrote: On 2010/05/03 13:48:52, Car

Re: Doc: LM: Reformat ly code. (issue1056041)

2010-05-03 Thread Carl . D . Sorensen
I'm out of time to finish this review today, so I thought it would be best to publish what I have. My overall thought is that in the Learning Manual, we shouldn't enforce yet-to-be-explained coding standards. Instead, we ought to format the examples to do the best job possible of explaining the