Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-10 Thread mtsolo
New patch set up that gets Y-offset right for glissando stem scripts. Cheers, MS http://codereview.appspot.com/4777044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-07 Thread m...@apollinemike.com
On Aug 6, 2011, at 10:56 PM, pkx1...@gmail.com wrote: > make fails. > > --snip-- > > -DHAVE_CONFIG_H -DNDEBUG -I/home/jlowe/lilypond-git/lily/include > -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out > -I../flower/include -I/home/jlowe/lilypond-git/lily/out -O2 > -finline-

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-06 Thread pkx166h
make fails. --snip-- -DHAVE_CONFIG_H -DNDEBUG -I/home/jlowe/lilypond-git/lily/include -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out -I../flower/include -I/home/jlowe/lilypond-git/lily/out -O2 -finline-functions -g -pipe -pthread -I/usr/include/freetype2 -pthread -I/usr

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-06 Thread mtsolo
I've merged my glissando stem work with current master. It passes regtests and can currently handle tremoli and scripts (see the regtest). However, these scripts just kinda float in the ether - they are prone to bump into anything outside the staff (for now). If anyone has any suggestions for h

Re: Music functions with pitch and duration arguments (was: Creates a glissando stem grob that uses stems' functionality. (issue4777044))

2011-07-21 Thread Han-Wen Nienhuys
On Thu, Jul 21, 2011 at 10:01 PM, David Kastrup wrote: > Anyway, this is not particularly complex either.  Could possibly pave > the way for a nicer function for setting up strings for tabulatures. > Also stuff like \transpose can be implemented by users with a > straightforward syntax accepting j

Music functions with pitch and duration arguments (was: Creates a glissando stem grob that uses stems' functionality. (issue4777044))

2011-07-21 Thread David Kastrup
n.putt...@gmail.com writes: > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly > File input/regression/glissando-stem.ly (right): > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 > input/regression/glissando-stem.ly:

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread m...@apollinemike.com
On Jul 20, 2011, at 6:27 PM, n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly > File input/regression/glissando-stem.ly (right): > > http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 > inp

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread Han-Wen Nienhuys
On Wed, Jul 20, 2011 at 1:05 PM, m...@apollinemike.com wrote: >> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >> lily/beam.cc:706: Interval positions = robust_scm2interval >> ((*s)->get_property ("head-positions"), Interval (0,0)); >> rather than changing all callers, w

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread Han-Wen Nienhuys
On Wed, Jul 20, 2011 at 11:30 PM, Han-Wen Nienhuys wrote: >>> http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 >>> lily/beam.cc:706: Interval positions = robust_scm2interval >>> ((*s)->get_property ("head-positions"), Interval (0,0)); >>> rather than changing all callers, wh

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread n . puttock
http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly File input/regression/glissando-stem.ly (right): http://codereview.appspot.com/4777044/diff/7001/input/regression/glissando-stem.ly#newcode10 input/regression/glissando-stem.ly:10: \xenakisStem #(ly:make-duration

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread Han-Wen Nienhuys
On Wed, Jul 20, 2011 at 9:32 AM, wrote: > A lot of files change because Stem::head_positions is now a callback.  I > may > even rename the property - it should really be called > extremal-positions, as > it describes the position of the extreme two heads (stems) or glissandi > (glissando stems).

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread m...@apollinemike.com
On Jul 20, 2011, at 5:31 PM, hanw...@gmail.com wrote: > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 > lily/beam.cc:706: Interval positions = robust_scm2interval > ((*s)->ge

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread hanwenn
http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4777044/diff/7001/lily/beam.cc#newcode706 lily/beam.cc:706: Interval positions = robust_scm2interval ((*s)->get_property ("head-positions"), Interval (0,0)); rather than changing

Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-07-20 Thread mtsolo
Reviewers: , Message: Tries to minimize overlap with stem.cc - Glissando_stem::has_interface now appears four (indispensable) times in stem.cc. I think it is pretty modular. If I get run over by a truck and no one knows how to maintain this thing and people decide to delete glissando stems from