Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-18 Thread Carl . D . Sorensen
I've uploaded a new patch set with graphical back in as a property and assigned to the instrument-specific-markup interface. http://codereview.appspot.com/1946043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/list

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-18 Thread Carl . D . Sorensen
On 2010/08/18 21:46:02, Neil Puttock wrote: On 2010/08/15 04:10:36, Carl wrote: > I tested, and verified that I don't need it, but why? I thought that we had > checks to issue a warning if an undefined property was used. Is that only for > context properties? It depends on whether you

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-18 Thread n . puttock
On 2010/08/15 04:10:36, Carl wrote: I tested, and verified that I don't need it, but why? I thought that we had checks to issue a warning if an undefined property was used. Is that only for context properties? It depends on whether you think users are likely to do this (where you'd also

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-17 Thread Carl Sorensen
On 8/17/10 9:15 PM, "Mike Solomon" wrote: > Hey all, > Looks a-ok to me: I don't have time to run the regtests now (still > traveling, no battery...), but if they don't break, feel free to push! regtests are fine, so I'll go ahead and push, and then finish the documentation. Thanks, Car

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-17 Thread Mike Solomon
Hey all, Looks a-ok to me: I don't have time to run the regtests now (still traveling, no battery...), but if they don't break, feel free to push! ~Mike On 8/15/10 12:10 AM, "carl.d.soren...@gmail.com" wrote: > OK, I fixed all these things, but I did have a question about why the > grob pr

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-15 Thread Carl Sorensen
On 8/15/10 2:39 AM, "David Kastrup" wrote: > carl.d.soren...@gmail.com writes: > >> On 2010/08/14 19:47:59, Neil Puttock wrote: >>> Since these are bound with defaults above, you don't need to use >> chain-assoc-get >> >>> (radius size) >> >> Done. I forgot about how nifty the new interface i

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-15 Thread David Kastrup
carl.d.soren...@gmail.com writes: > On 2010/08/14 19:47:59, Neil Puttock wrote: >> Since these are bound with defaults above, you don't need to use > chain-assoc-get > >> (radius size) > > Done. I forgot about how nifty the new interface is that David made > possible. Actually, the niftiness is

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-14 Thread Carl . D . Sorensen
OK, I fixed all these things, but I did have a question about why the grob property didn't need to be defined. Thanks, Carl http://codereview.appspot.com/1946043/diff/1/5 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/1946043/diff/1/5#newcode414 scm/define-grob-pr

Re: Change syntax for woodwind-diagram markup (issue1946043)

2010-08-14 Thread n . puttock
http://codereview.appspot.com/1946043/diff/1/5 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/1946043/diff/1/5#newcode414 scm/define-grob-properties.scm:414: (graphical ,boolean? "Display in graphical, rather than textual, form.") don't need this http://codereview.ap

Change syntax for woodwind-diagram markup (issue1946043)

2010-08-14 Thread Carl . D . Sorensen
Reviewers: MikeSol, Message: Here's a patch that changes the syntax for woodwind-diagram markups so that size, thickness, and graphic become part of the properties, rather than part of the arguments to the markup call. It's your code, Mike, so I don't want to push it without your permission, but