OK, I fixed all these things, but I did have a question about why the grob property didn't need to be defined.
Thanks, Carl http://codereview.appspot.com/1946043/diff/1/5 File scm/define-grob-properties.scm (right): http://codereview.appspot.com/1946043/diff/1/5#newcode414 scm/define-grob-properties.scm:414: (graphical ,boolean? "Display in graphical, rather than textual, form.") On 2010/08/14 19:47:59, Neil Puttock wrote:
don't need this
I tested, and verified that I don't need it, but why? I thought that we had checks to issue a warning if an undefined property was used. Is that only for context properties? Done, anyway http://codereview.appspot.com/1946043/diff/1/6 File scm/display-woodwind-diagrams.scm (right): http://codereview.appspot.com/1946043/diff/1/6#newcode1870 scm/display-woodwind-diagrams.scm:1870: (thickness .1) On 2010/08/14 19:47:59, Neil Puttock wrote:
0.1
Done. http://codereview.appspot.com/1946043/diff/1/6#newcode1952 scm/display-woodwind-diagrams.scm:1952: (let* ((radius (chain-assoc-get 'size props 1.0)) On 2010/08/14 19:47:59, Neil Puttock wrote:
Since these are bound with defaults above, you don't need to use
chain-assoc-get
(radius size)
Done. I forgot about how nifty the new interface is that David made possible. http://codereview.appspot.com/1946043/diff/1/6#newcode1954 scm/display-woodwind-diagrams.scm:1954: (display-graphic (chain-assoc-get 'graphic props #t)) On 2010/08/14 19:47:59, Neil Puttock wrote:
graphical
Done. http://codereview.appspot.com/1946043/diff/1/6#newcode1966 scm/display-woodwind-diagrams.scm:1966: ;(user-draw-commands (cadddr input-list)) On 2010/08/14 19:47:59, Neil Puttock wrote:
remove
Done. http://codereview.appspot.com/1946043/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
