Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-15 Thread mtsolo
On 2011/07/14 20:23:03, Neil Puttock wrote: On 14 July 2011 21:01, mailto:m...@apollinemike.com wrote: > I'll run the regtests tonight or tomorrow and report back. I've just tried this and I think you've got an infinite loop somewhere (I had to kill the proces

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread Neil Puttock
On 14 July 2011 21:01, m...@apollinemike.com wrote: > I'll run the regtests tonight or tomorrow and report back. I've just tried this and I think you've got an infinite loop somewhere (I had to kill the process and reboot). Edit: it's from tie-pitched-trill.ly; segfaults due to stack overflow.

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread m...@apollinemike.com
On Jul 14, 2011, at 3:51 PM, hanw...@gmail.com wrote: > much better. I bet there will skeletons coming out the regtest closet > now, but let's hope that we can fix things up if necessary > > > http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc > File lily/axis-group-i

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread hanwenn
much better. I bet there will skeletons coming out the regtest closet now, but let's hope that we can fix things up if necessary http://codereview.appspot.com/4639075/diff/23001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): http://codereview.appspot.com/4639075/diff/2

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread m...@apollinemike.com
On Jul 14, 2011, at 2:47 PM, carl.d.soren...@gmail.com wrote: > > http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc#newcode670 > lily/axis-group-interface.cc:670: > Axis_group_interface::has_outside_staff_parent (Grob *me) > Why not make this part of the Grob class ins

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread Carl . D . Sorensen
I like the fact that there's no more "rider" concept. The only architectural question I have is whether has_outside_staff_parent should be in Axis_group_interface or Grob. Otherwise, LGTM. Thanks, Carl http://codereview.appspot.com/4639075/diff/18001/lily/axis-group-interface.cc File lily/a

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-14 Thread m...@apollinemike.com
On Jul 13, 2011, at 10:48 PM, Han-Wen Nienhuys wrote: > On Wed, Jul 13, 2011 at 5:12 PM, m...@apollinemike.com > wrote: >> On Jul 13, 2011, at 4:42 PM, Han-Wen Nienhuys wrote: >> >>> On Wed, Jul 13, 2011 at 11:27 AM, m...@apollinemike.com >>> wrote: >>> > Wouldnt it be much easier for the

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-13 Thread Han-Wen Nienhuys
On Wed, Jul 13, 2011 at 5:12 PM, m...@apollinemike.com wrote: > On Jul 13, 2011, at 4:42 PM, Han-Wen Nienhuys wrote: > >> On Wed, Jul 13, 2011 at 11:27 AM, m...@apollinemike.com >> wrote: >> Wouldnt it be much easier for the tuplet number's extents  to be ignored for skyline purposes if

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-13 Thread m...@apollinemike.com
On Jul 13, 2011, at 4:42 PM, Han-Wen Nienhuys wrote: > On Wed, Jul 13, 2011 at 11:27 AM, m...@apollinemike.com > wrote: > >>> Wouldnt it be much easier for the tuplet number's extents to be >>> ignored for skyline purposes if there already is an associated tuplet >>> bracket? >>> >> >> That's

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-13 Thread Han-Wen Nienhuys
On Wed, Jul 13, 2011 at 11:27 AM, m...@apollinemike.com wrote: >> Wouldnt it be much easier for the tuplet number's extents  to be >> ignored for skyline purposes if there already is an associated tuplet >> bracket? >> > > That's what the new line 250 of axis-group-interface.cc in the patch does:

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-13 Thread m...@apollinemike.com
On Jul 13, 2011, at 4:13 PM, Han-Wen Nienhuys wrote: > On Fri, Jul 1, 2011 at 1:09 PM, Han-Wen Nienhuys wrote: >>> The problem with this is that, in the axis-group-interface, the >>> TupletNumber either: >>> >>> (1) Does not have an outside staff priority and therefore is included in >>> the s

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-13 Thread Han-Wen Nienhuys
On Fri, Jul 1, 2011 at 1:09 PM, Han-Wen Nienhuys wrote: >> The problem with this is that, in the axis-group-interface, the TupletNumber >> either: >> >> (1) Does not have an outside staff priority and therefore is included in the >> staff's skyline, which pushes the bracket too high. >> (2) Does

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-12 Thread mtsolo
On 2011/07/01 16:13:00, mike_apollinemike.com wrote: On Jul 1, 2011, at 6:09 PM, Han-Wen Nienhuys wrote: > maybe I misunderstand the problem. Are you fixing the slope of the > bracket (should be sloped), or the position of the number (not > centered on the bracket?) The position of the num

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-01 Thread Han-Wen Nienhuys
On Fri, Jul 1, 2011 at 12:44 PM, m...@apollinemike.com wrote: > On Jul 1, 2011, at 5:02 PM, hanw...@gmail.com wrote: > >> This patch doesnt make sense to me.  The TupletBracket grob is already >> linked to the TupletNumber.  The correct way to fix this is to make sure >> the number lets the bracke

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-01 Thread m...@apollinemike.com
On Jul 1, 2011, at 6:09 PM, Han-Wen Nienhuys wrote: > On Fri, Jul 1, 2011 at 12:44 PM, m...@apollinemike.com > wrote: >> On Jul 1, 2011, at 5:02 PM, hanw...@gmail.com wrote: >> >>> This patch doesnt make sense to me. The TupletBracket grob is already >>> linked to the TupletNumber. The correc

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-01 Thread m...@apollinemike.com
On Jul 1, 2011, at 5:02 PM, hanw...@gmail.com wrote: > This patch doesnt make sense to me. The TupletBracket grob is already > linked to the TupletNumber. The correct way to fix this is to make sure > the number lets the bracket decide its position. > > The problem with this is that, in the a

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-07-01 Thread hanwenn
This patch doesnt make sense to me. The TupletBracket grob is already linked to the TupletNumber. The correct way to fix this is to make sure the number lets the bracket decide its position. http://codereview.appspot.com/4639075/diff/4001/lily/axis-group-interface.cc File lily/axis-group-inter

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-06-28 Thread mtsolo
On 2011/06/27 21:56:00, Neil Puttock wrote: This doesn't look too good: \relative c' { \override TupletBracket #'outside-staff-priority = #1 \times 2/3 { c2 c c } } -> needlessly translated away from stave Fixed in the newest patchset. Thanks for catching that! http://codereview.

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-06-27 Thread n . puttock
On 2011/06/27 17:38:04, MikeSol wrote: Useful for stuff like: \version "2.15" \relative c' { \override TupletBracket #'outside-staff-priority = #1 \times 2/3 { c2^.^>^|^-^\espressivo c c } } This doesn't look too good: \relative c' { \override TupletBracket #'outside-staff-priority = #1

Allows for rider grobs in outside-staff-priority. (issue4639075)

2011-06-27 Thread mtsolo
Reviewers: , Message: Useful for stuff like: \version "2.15" \relative c' { \override TupletBracket #'outside-staff-priority = #1 \times 2/3 { c2^.^>^|^-^\espressivo c c } } Description: Allows for rider grobs in outside-staff-priority. Please review this at http://codereview.appspot.com/463