Now pushed.
fd7ad42f98d7e6117958a41e74cd736e396fb933
Will appear in 2.13.51.
Many thanks, Mike.
http://codereview.appspot.com/4079064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode861
Documentation/notation/pitches.itely:861: A scale of any length
and with
any intervals may be specified:
"An ascending scale of any length ..."
The octaves are linked smoothly if the scale is asce
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830
Documentation/notation/pitches.itely:830: left untransformed and a
warning given.}
I'd omit the "and a warning given". I mean, the warning will be
obvious, right? Just end with "... left untransform
Still works well for me, including the new bits.
Some late suggestions on the docs that you can take or leave.
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4079064/diff/7001
LGTM
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830
Documentation/notation/pitches.itely:830: left untransform
> I've just uploaded the latest changes from Mike. These extend
> modalInversion to permit inversions around a pivot between two notes in
> the scale.
>
> There are also some minor changes suggested by Graham.
>
> Please review.
LGTM
> http://codereview.appspot.com/4079064/
I've just uploaded the latest changes from Mike. These extend
modalInversion to permit inversions around a pivot between two notes in
the scale.
There are also some minor changes suggested by Graham.
Please review.
Trevor
http://codereview.appspot.com/4079064/
__
percival.music...@gmail.com> wrote Saturday, February 05, 2011 6:20
PM
http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely#newcode827
Documentation/notation/pitches.itely:827: it may be converted to
its
@notation{retrograde} (written backwards).
I'm not certain
LGTM.
http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely#newcode827
Documentation/notation/pitches.itely:827: it may be converted t
Reviewers: ,
Message:
This is a continuation of Issue 4126042. I had to start a new Rietfeld
number as I'd moved to a new branch after rebasing and resolving merge
conflicts in preparation for pushing ... then Neil's comments arrived.
Sorry Neil - I think I've responded to all your comments corr
10 matches
Mail list logo
