percival.music...@gmail.com> wrote Saturday, February 05, 2011 6:20
PM
http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely#newcode827
Documentation/notation/pitches.itely:827: it may be converted to
its
@notation{retrograde} (written backwards).
I'm not certain you need to spell out "written backwards". You
haven't
said what "inverted" or "transposed" means, after all!
If you're paranoid, then how about adding a stub to the music
glossary,
and a @rgloss{} to the @seealso ? (or actually add a full entry
to the
glossary if you want)
I'll do this as a separate patch after this has been pushed.
http://codereview.appspot.com/4079064/diff/1/Documentation/notation/pitches.itely#newcode855
Documentation/notation/pitches.itely:855: \new Staff {
I know that you don't want to hear this at this point, but...
You know, all these examples are beautifully written and are very
clear.
I think we could have capitalized on this by doing everything at
once.
I think it would have been a little too long.
(BTW, do you actually need the \score and \new Staff in these? My
first
guess would be that a simple \relative c' would suffice, but maybe
I'm
wrong or maybe the transposing complicates the \relative)
\modalTranspose and the other functions have problems
inside \relative blocks. Ordinary \transpose is similar.
I can get away with just a \new Staff, so I'll change to
this.
Trevor
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
