Re: Add independent control of thickness and offset for underline markup (issue1347041)

On 2010/08/13 03:15:48, Carl wrote: Is the default OK now? Looks fine to me. Cheers, Neil http://codereview.appspot.com/1347041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add independent control of thickness and offset for underline markup (issue1347041)

Having not seen anything back from Kieren, I went ahead and made the changes that were suggested. Is the default OK now? Thanks, Carl http://codereview.appspot.com/1347041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.

Re: Add independent control of thickness and offset for underline markup (issue1347041)

Reviewers: Neil Puttock, Message: On 2010/05/29 17:51:11, c_sorensen_byu.edu wrote: On 5/29/10 10:10 AM, "Kieren MacMillan" wrote: > To be clear, 'line-thickness and the thickness property of \underline are > [potentially] two different independent val

Re: Add independent control of thickness and offset for underline markup (issue1347041)

On 2010/05/29 16:10:16, kieren_macmillan_sympatico.ca wrote: I tried #:properties ((thickness 1)) and it failed. Sorry, I meant remove the default value, but keep `offset' in the properties list, i.e., #:properties ((thickness 1) (offset)) This way it's bound to #f if the user hasn't over

Re: Add independent control of thickness and offset for underline markup (issue1347041)

Hi Carl, > Couldn't we define the offset as a multiple of 'line-thickness, instead of > an absolute value? That's how fret diagrams are scaled. Sounds good to me! To be clear, 'line-thickness and the thickness property of \underline are [potentially] two different independent values, right? Ch

Re: Add independent control of thickness and offset for underline markup (issue1347041)

Hi Neil, Thanks for the comments! [Should I be somehow commenting on codereview instead of here?] > I don't think we can remove the link between 'line-thickness and > underline offset, since it should scale based on staff-size. At small > staff-sizes, 'line-thickness gets progressively larger, w

Re: Add independent control of thickness and offset for underline markup (issue1347041)

On 5/29/10 10:10 AM, "Kieren MacMillan" wrote: > Hi Neil, > > Thanks for the comments! > [Should I be somehow commenting on codereview instead of here?] Either way works. > >> I don't think we can remove the link between 'line-thickness and >> underline offset, since it should scale based on

Re: Add independent control of thickness and offset for underline markup (issue1347041)

On 5/28/10 2:29 PM, "n.putt...@gmail.com" wrote: > Hi Kieren, > > I don't think we can remove the link between 'line-thickness and > underline offset, since it should scale based on staff-size. At small > staff-sizes, 'line-thickness gets progressively larger, which matches > the thicker und

Add independent control of thickness and offset for underline markup (issue1347041)

Hi Kieren, I don't think we can remove the link between 'line-thickness and underline offset, since it should scale based on staff-size. At small staff-sizes, 'line-thickness gets progressively larger, which matches the thicker underline with a slightly bigger gap. What you could do instead is