Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-26 Thread Han-Wen Nienhuys
On Sun, Apr 26, 2020 at 10:04 PM Valentin Villenave wrote: > > On 4/26/20, hanw...@gmail.com wrote: > > I can host this script somewhere else so it can be referenced in the CG, > > but I don't think there optimizing our C++ code is a domain for > > beginners. > > I may be off the mark here, but

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-26 Thread Valentin Villenave
On 4/26/20, hanw...@gmail.com wrote: > I can host this script somewhere else so it can be referenced in the CG, > but I don't think there optimizing our C++ code is a domain for > beginners. I may be off the mark here, but what about adding your speed test into the standard regression test suite

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-26 Thread jonas . hahnfeld
On 2020/04/25 22:05:26, dak wrote: > On 2020/04/25 17:07:17, hahnjo wrote: > > I strongly object to adding more random scripts to the source tree. There are > > already far too many unmaintained in scripts/auxiliar/ with no documentation > at > > all. > > How about approaching this in a different

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
On 2020/04/25 22:05:26, dak wrote: > On 2020/04/25 17:07:17, hahnjo wrote: > > I strongly object to adding more random scripts to the source tree. There are > > already far too many unmaintained in scripts/auxiliar/ with no documentation > at > > all. > > How about approaching this in a different

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread dak
On 2020/04/25 17:07:17, hahnjo wrote: > I strongly object to adding more random scripts to the source tree. There are > already far too many unmaintained in scripts/auxiliar/ with no documentation at > all. How about approaching this in a different manner then? Adding instructions to the CG about

Re: Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread hanwenn
Reviewers: hahnjo, Message: sure. Description: Add a script for running timing benchmarks Please review this at https://codereview.appspot.com/545950043/ Affected files (+97, -0 lines): A scripts/auxiliar/benchmark.py Index: scripts/auxiliar/benchmark.py diff --git a/scripts/auxiliar/benchm

Add a script for running timing benchmarks (issue 545950043 by hanw...@gmail.com)

2020-04-25 Thread jonas . hahnfeld
I strongly object to adding more random scripts to the source tree. There are already far too many unmaintained in scripts/auxiliar/ with no documentation at all. https://codereview.appspot.com/545950043/