Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Patrick McCarty
On Mon, Apr 06, 2009 at 08:48:15PM -0600, Carl D. Sorensen wrote: > Patrick, > > I applied this patch. I actually had to redo it, because I changed > define-grobs.scm first, so the patch wouldn't apply. But it's > applied now, along with the changes to lily/beam.cc and > scm/define-grob-interfac

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Carl D. Sorensen
Patrick, I applied this patch. I actually had to redo it, because I changed define-grobs.scm first, so the patch wouldn't apply. But it's applied now, along with the changes to lily/beam.cc and scm/define-grob-interfaces.scm so that details works as desired for beams. Thanks for your help in ge

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Carl D. Sorensen
On 4/6/09 12:44 PM, "Patrick McCarty" wrote: > On Mon, Apr 06, 2009 at 07:46:41AM -0600, Carl D. Sorensen wrote: >> >> >> So the new assignment, then, is to modify the *.cc file for each >> object that has a details property so that the elements of the >> details are included. I haven't rev

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Patrick McCarty
On Mon, Apr 06, 2009 at 07:46:41AM -0600, Carl D. Sorensen wrote: > > On 4/6/09 7:10 AM, "Mats Bengtsson" wrote: > > > > What do you mean? The way it's done for the Stem related > > subproperties is that the documentation is included together with > > the other stem-interface documentation at the

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Mats Bengtsson
Carl D. Sorensen wrote: The way it's done for the Stem related subproperties is that the documentation is included together with the other stem-interface documentation at the end of the file lily/stem.cc. ... Ahh -OK. I had missed the description at the top, and had just noticed that

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Carl D. Sorensen
On 4/6/09 7:10 AM, "Mats Bengtsson" wrote: >>> Thanks Mats, I did not think of doing that. >>> >>> This will be a task in itself. For example, Tie has 26 different >>> subproperties of 'details to document! >>> >>> >> >> This documentation *has* to be automatically generated.

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Mats Bengtsson
Carl D. Sorensen wrote: On 4/6/09 3:48 AM, "Patrick McCarty" wrote: On Mon, Apr 06, 2009 at 09:37:09AM +0200, Mats Bengtsson wrote: Patrick McCarty wrote: So, is the patch okay as it is? Don't refer to *.cc files for more information on the subproperties in deta

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Carl D. Sorensen
On 4/6/09 3:48 AM, "Patrick McCarty" wrote: > On Mon, Apr 06, 2009 at 09:37:09AM +0200, Mats Bengtsson wrote: >> >> >> Patrick McCarty wrote: >>> >>> So, is the patch okay as it is? >>> >> Don't refer to *.cc files for more information on the subproperties in >> details. These are (or at

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Patrick McCarty
On Mon, Apr 06, 2009 at 09:37:09AM +0200, Mats Bengtsson wrote: > > > Patrick McCarty wrote: >> >> So, is the patch okay as it is? >> > Don't refer to *.cc files for more information on the subproperties in > details. These are (or at least should be) described in the > corresponding *-inter

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-06 Thread Mats Bengtsson
Patrick McCarty wrote: On Fri, Apr 03, 2009 at 01:53:43PM -0600, Carl D. Sorensen wrote: On 4/3/09 1:43 PM, "Patrick McCarty" wrote: On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen wrote: Unfortunately, there are different 'details lists for different grobs, so there's n

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-05 Thread Patrick McCarty
On Fri, Apr 03, 2009 at 08:59:31PM +0100, Neil Puttock wrote: > 2009/4/3 Carl D. Sorensen : > > > > > > > > On 4/3/09 1:43 PM, "Patrick McCarty" wrote: > > > >> On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen > >> wrote: > >>> > > >>> Unfortunately, there are different 'details lists for

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-05 Thread Patrick McCarty
On Fri, Apr 03, 2009 at 01:53:43PM -0600, Carl D. Sorensen wrote: > > > > On 4/3/09 1:43 PM, "Patrick McCarty" wrote: > > > On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen > > wrote: > >> > >>> > >> Unfortunately, there are different 'details lists for different grobs, > >> so there's no

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Han-Wen Nienhuys
On Fri, Apr 3, 2009 at 4:21 PM, Carl D. Sorensen wrote: >> This patch moves the 'details property from the internal to the user >> grob property list. > > I believe that moving 'details from internal to user won't have the effect > we want. I believe that internal properties are set by the grob,

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Neil Puttock
2009/4/3 Carl D. Sorensen : > > > > On 4/3/09 1:43 PM, "Patrick McCarty" wrote: > >> On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen wrote: >>> >>> Unfortunately, there are different 'details lists for different grobs, >>> so there's not a generic set of defaults that we can list, if I und

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Carl D. Sorensen
On 4/3/09 1:43 PM, "Patrick McCarty" wrote: > On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen wrote: >> >>> >> Unfortunately, there are different 'details lists for different grobs, >> so there's not a generic set of defaults that we can list, if I understand >> correctly. > > If 'detail

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Patrick McCarty
On Fri, Apr 3, 2009 at 12:21 PM, Carl D. Sorensen wrote: > > On 4/2/09 5:31 PM, "Patrick McCarty" wrote: > >> Hello, >> >> This patch moves the 'details property from the internal to the user >> grob property list. > > I believe that moving 'details from internal to user won't have the effect > w

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Carl D. Sorensen
On 4/2/09 5:31 PM, "Patrick McCarty" wrote: > Hello, > > This patch moves the 'details property from the internal to the user > grob property list. I believe that moving 'details from internal to user won't have the effect we want. I believe that internal properties are set by the grob, rat

Re: [PATCH] Docs: IR: Move 'details to user grob property list

2009-04-03 Thread Francisco Vila
2009/4/3 Patrick McCarty : > Can someone apply? I feel uncomfortable while ignoring these kind of messages just because I could apply it as I have git access, but I am not a developer but a translator. If it is really of any help, I could apply it after a LGTM from a developer. If not, I could si

[PATCH] Docs: IR: Move 'details to user grob property list

2009-04-02 Thread Patrick McCarty
rick >From 27dca7f299aac2f0894c05dc7adcb1647b685d1e Mon Sep 17 00:00:00 2001 From: Patrick McCarty Date: Thu, 2 Apr 2009 15:01:15 -0700 Subject: [PATCH] Docs: IR: Move 'details to user grob property list Signed-off-by: Patrick McCarty --- scm/define-grob-properties.scm | 15 +++---