Re: Prevent race condition in `-dfont-ps-resdir` (issue 561810045 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm File scm/backend-library.scm (right): https://codereview.appspot.com/561810045/diff/551840043/scm/backend-library.scm#newcode143 scm/backend-library.scm:143: ;; When the directory alread

Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode467 lily/open-type-font-scheme.cc:467: warn

Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/548080043/diff/573790043/Documentation/usage/running.itely#newcode663 Documentation/usage/running

Re: Add `-dfont-ps-resdir` option to embed fonts to PDFs later (issue 577900043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/577900043/diff/577910043/Documentation/usage/running.itely#newcode652 Documentation/usage/running

Re: Fix Windows resource to enable manifest (issue 551580044 by truer...@gmail.com)

Reviewers: lemzwerg, Be-3, dak, thomasmorley651, Message: I've added changes.tely entry in Issue 5833. This Issue 5828 became "push", but I would like to push this and Issue 5833 together. If only this issue is pushed without Issue 5833, LilyPond for Windows cannot handle some filenames. I wait

Re: Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

On 2020/02/01 18:55:50, lemzwerg wrote: > > In `-std=c++11`, most POSIX functions/definitions cannot > > be used. > > Also `putenv ()` and `chroot ()` cannot be used. > > What about using > > AC_USE_SYSTEM_EXTENSIONS > > instead (in `configure.in`) to activate many POSIX functionality? done.

Re: Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

In `-std=c++11`, most POSIX functions/definitions cannot be used. Also `putenv ()` and `chroot ()` cannot be used. These missing raises error in compiling LilyPond. We can define `M_PI` if there is no `M_PI` definition. We can implement `strdup ()` alternative by using only strict C++11 standard f

Re: Issue 5720: Fix C++11 option (issue 579270051 by truer...@gmail.com)

Reviewers: lemzwerg, Message: On 2020/02/01 07:10:17, lemzwerg wrote: > Mhmm, wouldn't it be better to simply define `M_PI` if it is not defined? GNU > options might not be available with other compilers... `-std=c++11` cannot use not only `M_PI` but also POSIX functions such as `strdup ()`. Eve

Re: Inline assembler fallback for _FPU_SETCW() missing in MINGW libraries (issue 577450043 by thomasmorle...@gmail.com)

Hello Arnold. Thank you for your patch. If I understand correctly, we only need check the definitions of `__x86__` and `__i386__` check. In x86_64 environment, neither `__x86__` nor `__i386__` are defined. ``` $ echo | x86_64-w64-mingw32-gcc -dM -E - | grep "__x86__" $ echo | x86_64-w64-mingw32

Re: Inline assembler fallback for _FPU_SETCW() missing in MINGW libraries (issue 577450043 by thomasmorle...@gmail.com)

How about this patch? Sorry, not tested. If I understand correctly, this patch solves not only Issue 4943 but also Issue 4975. These issues do not only occur on Windows, but on all x86 platforms except Linux. `defined (__MINGW32__)` is not necessary. For Linux-x86, it uses the original precision

Re: Issue 5463: Fix dblatex uses xetex backend (issue 344120043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make File make/lilypond-book-vars.make (right): https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make#newcode43 make/lilypond-book-vars.make:43: ifneq (,($findstring xela

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

$@ $(outdir)/$*.tmp.pdf On 2018/07/14 10:21:51, Dan Eble wrote: On 2018/07/14 08:22:49, trueroad wrote: > Unfortunately, we cannnot specify an output filename for LaTeX. How about creating the intermediate file in a different directory? Would that solve the problem? Done. ht

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdi

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

Thank you for your reviewing. On 2018/07/14 06:49:26, lemzwerg wrote: LGTM, thanks! Two minor suggestions: s/intermediate/tmp/, since this is shorter. Please wrap the extremely long lines in the makefiles for improved readability. Done. https://codereview.appspot.com/357760043/

Re: Issue 5380: Fix `make doc` with non-clean build directory (issue 355750043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py File scripts/build/www_post.py (right): https://codereview.appspot.com/355750043/diff/1/scripts/build/www_post.py#newcode97 scripts/build/www_post.py:97: os.link (f, strip_file_name[t] (f)) O

Re: Allow use of Identity-H CMap and CID versions of Emmentaler (issue 343970043 by knup...@gmail.com)

https://codereview.appspot.com/343970043/diff/60001/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/343970043/diff/60001/mf/GNUmakefile#newcode165 mf/GNUmakefile:165: cd $(outdir) && mv $(notdir $<) $(notdir $@) Is it necessary to change the file name? I think that th

Re: Allow use of Identity-H CMap and CID versions of Emmentaler (issue 343970043 by knup...@gmail.com)

Great! But, I failed to build in my Cygwin (case insensitive) environment. I think there is potential confusion where the CID file has no extension, and just has capitalization to indicate it. Is this a standard for CID-keyed fonts? Actually, it is, but I don't see a reason to not use `.ci

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

LGTM For the future, I would like to prefer Identity-H encoding rather than 3 custom encodings. If I understand correctly, All glyphs can be used with Identity-H encoding. No other encoding is necessary. For current LilyPond and Ghostscript, when using CID-keyed font, Identity-H encoding PDF i

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

On 2017/09/25 13:21:44, dak wrote: I don't really have a clue here: can someone chime in with the current Ghostscript versions in possibly concerned distributions? Naturally including our own Gub-based ones? GUB has Ghostscript 9.21 except freebsd-x86. (Ghostscript 9.2x for freebsd-x86 raise

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

On 2017/09/24 11:03:26, dak wrote: In my opinion, -b/--bigpdf should be simple to use for lilypond-book-like applications. lilypond-book should likely call lilypond using options leading to good results by default. For generating our own documentation, I find 3-4GB of disk space excessive

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

On 2017/09/24 00:25:17, knupero wrote: > If I understand correctly, `--bigpdfs` / `-b` has two effects. > One is to embed full set (non-subset) font. > The other is to define and use some encodings for Emmentaler. It also changes the way emmentaler glyphs are printed. With --bigpdfs we use th

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by knup...@gmail.com)

`-dgs-never-embed-fonts` doesn't effect for TrueType fonts. Therefore, when both `-dgs-never-embed-fonts` and `--bigpdfs`/`-b` are used at the same time, TrueType fonts are embedded as full set (ie non-subset). (if there is no bug in gs.) On the other hand, some intermeiate PDFs use Japanese TrueT

Re: Doc: Add `-dPDFDontUseFontObjectNum` for gs 9.17+ (issue 322580043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/322580043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/322580043/diff/1/Documentation/usage/running.itely#newcode204 Documentation/usage/running.itely:204: On

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely#newcode1624 Documentation/notation/text.itely

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

Thank you for your suggestion. https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/330040043/diff/20001/Documentation/notation/input.itely#newcode2847 Documentation/notation/input.

Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely#newcode2845 Documentation/notation/input.itely:284

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

On 2017/08/01 15:05:46, trueroad wrote: Add notes and identification way If I understand correctly, I've found a current limitation. I could not find a way to specify OpenType font scripts and languages. So I've added it to the document. Also I've added feature identification w

Re: Add usage of OpenType font feature to the documents (issue 328140043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely#newcode1037 Documentation/changes.tely:1037: On 2017/07/26 20:09:33, lemzw

Re: Web: Authors.itexi update (issue 323320043 by pkx1...@gmail.com)

On 2017/07/21 14:07:06, pkx166h wrote: On 2017/07/21 14:06:24, pkx166h wrote: > Added Hosoda-sama to 'Translations' section I have done this. Thank you. LGTM https://codereview.appspot.com/323320043/ ___ lilypond-devel mailing list lilypond-devel

Web: Authors.itexi update (issue 323320043 by pkx1...@gmail.com)

Would you add "Masamichi Hosoda" to "Translation"? I translated some Japanese documents. Documentation/ja/web.texi Documentation/ja/web/community.itexi Documentation/ja/web/download.itexi Documentation/ja/web/manuals.itexi etc. https://codereview.appspot.com/323320043/ _

Re: Initial work to support opentype font features (issue 323850043 by horndud...@gmail.com)

On 2017/06/12 10:43:53, trueroad wrote: On 2017/06/05 05:01:28, horndude77 wrote: > Update minimum pango version If I understand correctly, LilyDev 4.1 cannot compile this patch. In my humble opinion, it is necessary that LilyDev 4.1 can compile it. I want to hear the opinions of Lily

Re: Initial work to support opentype font features (issue 323850043 by horndud...@gmail.com)

On 2017/06/05 05:01:28, horndude77 wrote: Update minimum pango version If I understand correctly, LilyDev 4.1 cannot compile this patch. In my humble opinion, it is necessary that LilyDev 4.1 can compile it. I want to hear the opinions of LilyDev 4.1 users. If it is necessary, shall I create

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

Thank you for your opinion. I've removed the comment. https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly File Documentation/ly-examples/granados.ly (right): https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly#newcode12

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

Thank you for your reviewing. Here's new commit message. Issue 5128: Prevent granados.ly image rotation in web.pdf granados.ly used 'landscape symbol for page settings. As a result, granados.pdf which was generated from granados.ly contained `/Rotate 90` that is not supported by

Re: Prevent race condition in font export directory making (issue 319510043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm#newcode551 scm/framework-ps.scm:551: (let ((errno (system-error-errno stuff))) On 2017/03/19

Re: Fix build failure on GNU Hurd (issue 319400043 by pkx1...@gmail.com)

On 2017/03/08 17:36:40, pkx166h wrote: My error message is similar it is this: Thank you for showing your error message. It looks the same as mine. I've created a patch for fixing `make check` error only. Would you try it? https://sourceforge.net/p/testlilyissues/issues/5077/#28bc This patch

Re: Fix build failure on GNU Hurd (issue 319400043 by pkx1...@gmail.com)

On 2017/03/04 18:03:37, pkx166h wrote: I am going to need some help from a developer on this as not being a programmer I don't know what that last comment means I need to do on my side. I've tried Patch Set 1. I could not reproduce errors. Would you show me your environment and detailed repro

Re: Add capability to build Japanese PDF documents (issue 316340043 by truer...@gmail.com)

Thank you for your reviewing. On 2017/03/06 12:40:30, davide.liessi wrote: 2017-03-06 13:32 GMT+01:00 : > https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile#newcode24 > Documentation/ja/GNUmakefile:24: # (This package is for Chine

Re: Add capability to build Japanese PDF documents (issue 316340043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile File Documentation/ja/GNUmakefile (right): https://codereview.appspot.com/316340043/diff/1/Documentation/ja/GNUmakefile#newcode7 Documentation/ja/GNUmakefile:7: # By default, Japanese PDF

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

Thank you for your advice. https://codereview.appspot.com/314130043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305 configure.ac:305: [" documentation and the final PDF files.)"]) On 2016/11/19 14:06:07, pkx166h wro

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

On 2016/11/19 06:11:09, lemzwerg wrote: Ah, bad wording, sorry. I don't care about the actual length of the message but the line length in the source code, so please just wrap the message to stay within 80 columns or so if possible. Here's another version of the message which you might co

Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

, you can build documents. Ghostscript 9.20+: It is necessary for string named destinations. Ghostscript 9.19 and prior cannot handle them. http://bugs.ghostscript.com/show_bug.cgi?id=696974 Extract PDFmark: It is necessary for preserving named destinations and page mode. https://github.co

Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)

On 2016/11/16 15:40:48, pkx166h wrote: Push patch set 1. Then we can worry about getting the download up to LilyPond site afterwards. I will create a tracker to document all this. I've pushed Patch Set 1 to staging. commit 855e8e36a0c75aa75076fabe19aa292a6902ec96 https://codereview.appspot.c

Re: Add installing optional URW++ fonts (issue 315850043 by truer...@gmail.com)

Reviewers: lemzwerg, pkx166h, Message: On 2016/11/05 10:24:39, pkx166h wrote: Hosoda-san (and perhaps others who know about font installation), I cannot seem to be able to install 'just' a git commit (as is described in the warning message that is posted by the makefile when you run 'confi

Re: Add `-dfont-export-dir=[dir]` option (issue 316860043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/316860043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/316860043/diff/1/scm/framework-ps.scm#newcode513 scm/framework-ps.scm:513: ;; If the cause is the file already exist, return #f. O

Re: Add `-dgs-neverembed-fonts` option (issue 312970043 by truer...@gmail.com)

On 2016/11/04 11:51:04, trueroad wrote: Fix PNG output I've noticed that PNG output is broken. So I've fixed it and uploaded Patch Set 4. https://codereview.appspot.com/312970043/ ___ lilypond-devel mailing list lilypond-devel@gnu

Re: Add `-dgs-neverembed-fonts` option (issue 312970043 by truer...@gmail.com)

On 2016/10/31 18:32:09, pwm wrote: For consistency and readability should there be a dash between "never" and "embed"? For example: -dgs-never-embed-fonts rather than -dgs-neverembed-fonts Thank you for reviewing. I've uploaded Patch set 3. https://codereview.appspot.com/312970043/ __

Re: Add `-dgs-neverembed-fonts` option (issue 312970043 by truer...@gmail.com)

> I am happy to help with the documentation if language is a difficulty to > describe, but fundamentally what is the purpose of this command and why, as a > user, would I want to use (and perhaps not to use it?). I leave a detailed answer to Masamichi-san :-) This option is very useful wh

Re: Add Greek and Cyrillic glyph aliases (issue 316800043 by truer...@gmail.com)

On 2016/10/27 15:50:14, lemzwerg wrote: > Other version of URW fonts do not seem to have OTF format. The link you are showing points to a directory where the fonts come in all three flavours. > C059-BdIta.otf ... in the ghostscript-9.20.tar.gz bundle the URW fonts don't have an extens

Re: Add Greek and Cyrillic glyph aliases (issue 316800043 by truer...@gmail.com)

On 2016/10/26 15:16:27, lemzwerg wrote: > Our checks can detect old URW fonts. > Current URW fonts cannot be detect. Hmm, fontconfig collects information on a font's supported Unicode blocks while adding it to the database. If we check that the URW fonts are not Filippov's, but still supp

Re: Fix Type1 (PFA and PFB) font embedding (issue 313930043 by truer...@gmail.com)

Reviewers: lemzwerg, Message: Thank you for your reviewing. https://codereview.appspot.com/313930043/diff/1/lily/pfb.cc File lily/pfb.cc (right): https://codereview.appspot.com/313930043/diff/1/lily/pfb.cc#newcode49 lily/pfb.cc:49: seglen |= (static_cast(*p++) << 24); I suggest to add a guar

Re: Add Greek and Cyrillic glyph aliases (issue 316800043 by truer...@gmail.com)

On 2016/10/26 11:46:15, lemzwerg wrote: > For non-GUB, it might be difficult. > There are many variations of URW fonts. > e.g. difference of the name, with or without Greek and Cyrillic glyphs, etc. Hmm. Didn't we have a test that checks whether the URW fonts contain Cyrillic glyphs? Maybe

Re: Add Greek and Cyrillic glyph aliases (issue 316800043 by truer...@gmail.com)

On 2016/10/25 20:39:09, lemzwerg wrote: > When you build current LilyPond, some TeX Gyre fonts are required. > They are installed in LilyPond's directory. > e.g. /usr/share/lilypond/current/fonts/otf > > Do you think that URW fonts should be installed in the same directory? Good question. May

Re: Add Greek and Cyrillic glyph aliases (issue 316800043 by truer...@gmail.com)

Reviewers: lemzwerg, Message: On 2016/10/25 06:29:32, lemzwerg wrote: LGTM. Note, however, that the new versions of URW fonts are considered problematic, since they differ too much from the original set of fonts (especially metrics) – this is the very reason that currently TeXLive doesn't u

Re: Replace `-dgs-load-fonts' to `--bigpdfs' in lilypond-book (issue 300280043 by truer...@gmail.com)

If I understand the issue correctly, your solution overcomes the last obstacle with ghostscript, so we could actually start with an implementation :-) Unfortunately, Ghostscript 9.19 (newest release version) and prior versions cannot handle some PDF destination names. http://bugs.ghostscript.com

Re: Replace `-dgs-load-fonts' to `--bigpdfs' in lilypond-book (issue 300280043 by truer...@gmail.com)

ss PDF. Both the PDF and the PDFmark are mixed by Ghostscript. https://github.com/trueroad/extractpdfmark/ i.e. $ extractpdfmark Fontless.pdf > Fontless.pdfmark.ps $ gs -I -dNOSAFER \ -q -dBATCH -dNOPAUSE -sDEVICE=pdfwrite \ -sOutputFile=WithEmbeddedFonts.pdf Fontless.pdf Fontless.

Re: Replace `-dgs-load-fonts' to `--bigpdfs' in lilypond-book (issue 300280043 by truer...@gmail.com)

On 2016/07/22 15:27:10, wl_gnu.org wrote: > ps2pdf -I \ > -dNOSAFER -P \ > Fontless.pdf WithEmbeddedFonts.pdf This should rather be ps2pdf -I \ -dNOSAFER \ Fontless.pdf WithEmbeddedFonts.pdf I've tested with the fonts in the current d

Re: Add checking conflicts between CFF flavored fonts (issue 302090043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/302090043/diff/1/scm/framework-ps.scm#newcode259 scm/framework-ps.scm:259: (_ "The same CFF font `~a' has been detected. Omit the

Re: Issue 4876/4: Enable fontname replacing in TrueType functions (issue 300490043 by truer...@gmail.com)

Thank you for your comments. https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc File lily/open-type-font.cc (right): https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode185 lily/open-type-font.cc:185: // FreeType 2.6.2+ has been fixed this

Re: Issue 4876/4: Enable fontname replacing in TrueType functions (issue 300490043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc File lily/open-type-font.cc (right): https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc#newcode160 lily/open-type-font.cc:160: string cff_table = get_otf_table (face,

Re: Issue 4902: Improve `-dgs-load-fonts` option for TTF that doesn't have glyph names (issue 302000043 by truer...@gmail.com)

Thank you for your reviewing. https://codereview.appspot.com/30243/diff/1/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): https://codereview.appspot.com/30243/diff/1/lily/open-type-font-scheme.cc#newcode216 lily/open-type-font-scheme.cc:216: bool has_glyph_name

Re: Replace `-dgs-load-fonts' to `--bigpdfs' in lilypond-book (issue 300280043 by truer...@gmail.com)

Mhmm. As James writes, this can easily break. My proposal never change the font selection method. It changes the font embedding method for intermediate EPS. Current "make doc" works as follows: For all fonts, the font file name is embedded. In other words, the font glyphs are not embedded. S

Re: Replace `-dgs-load-fonts' to `--bigpdfs' in lilypond-book (issue 300280043 by truer...@gmail.com)

I came up with another idea. Remove `-dgs-load-fonts` from lilypond-book default. During LilyPond and its documents are built, `-dgs-load-lily-fonts` option instead of `-dgs-load-fonts` is used. `-dgs-load-lily-fonts` means "Load only the LilyPond fonts via Ghostscript." "LilyPond fonts" mean t

Re: Add ly:get-font-format to get the font format (issue 296350043 by truer...@gmail.com)

LGTM, but note that FreeType's `FT_Get_Font_Format` doesn't really return the font format but the name of the module used to handle a font. In particular, it doesn't make a difference between PFA and PFB. My main purpose was the distinction between the TTC and OTC. So this patch cannot dist

Re: Add XeTeX for document building (issue 285790043 by truer...@gmail.com)

Reviewers: lemzwerg, Message: texinfo.tex's XeTeX support seems have still some issues. Here's LilyPond PDF documents generated by XeTeX. https://drive.google.com/file/d/0ByGBX3PDrqjsQmllOXBUQW1rbkU/view?usp=sharing I've noticed that non-ascii characters of ``Table of Contents'' are broken. Wou

Re: Change texi2html option order for fixing Japanese navigation bars (issue 281970043 by truer...@gmail.com)

I've uploaded Patch Set 3. It passes full make doc in my environment. https://codereview.appspot.com/281970043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Usage - Update svg & svg-woff backend text (issue 274260043 by pkx1...@gmail.com)

LGTM Thank you. https://codereview.appspot.com/274260043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Usage - Update svg & svg-woff backend text (issue 274260043 by pkx1...@gmail.com)

https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely#newcode490 Documentation/usage/running.itely:490: additional additional @cod

Re: Doc: Usage - Update svg & svg-woff backend text (issue 274260043 by pkx1...@gmail.com)

On 2015/11/03 14:20:57, pkx166h wrote: On 2015/11/03 13:55:02, trueroad wrote: > https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/274260043/diff/1/Documen

Doc: Usage - Update svg & svg-woff backend text (issue 274260043 by pkx1...@gmail.com)

https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely#newcode783 Documentation/usage/running.itely:783: handle them. For other font forma

Re: Doc: Included/compile.itexi - CG 4.2 - Updated notes on reqs for compiling (issue 261430043 by pkx1...@gmail.com)

https://codereview.appspot.com/261430043/diff/40001/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/261430043/diff/40001/Documentation/included/compile.itexi#newcode114 Documentation/included/compile.itexi:114: ttf-kochi-goth

Re: Fix svg backend explanation (issue 262380043 by truer...@gmail.com)

Thank you for your suggestions. https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/20001/Documentation/usage/running.itely#newcode488 Documentation/usage/running.ite

Re: Fix svg backend explanation (issue 262380043 by truer...@gmail.com)

Thank you for your comments. I've fixed some sentences. https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/262380043/diff/1/Documentation/usage/running.itely#newcode478 Documentation/us

Re: Issue 4591: Fix font-name overriding (issue 262330043 by truer...@gmail.com)

I've noticed that LilyPond' font-family and Pango/Fontconfig's font family are quite a different thing. To prevent confusion, I've changed some term. https://codereview.appspot.com/262330043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https

Re: Issue 4595: NR: Describe default fonts as TeX Gyre fonts (issue 268780043 by truer...@gmail.com)

https://codereview.appspot.com/268780043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/268780043/diff/1/Documentation/notation/text.itely#newcode1460 Documentation/notation/text.itely:1460: (alias of TeX Gyre Cursor). On 2

Re: Issue 4591: Fix font-name overriding (issue 262330043 by truer...@gmail.com)

I've added cleaning up etc. Issue 4591 / 6: Clean up Alignment spacing only. https://codereview.appspot.com/262330043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4591: Fix font-name overriding (issue 262330043 by truer...@gmail.com)

I've updated the patch. https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/262330043/diff/1/Documentation/notation/text.itely#newcode1547 Documentation/notation/text.itely:1547: If firs

Re: Issue 4571 / 4: Add font aliases settings for NR: antient.itely (issue 261980044 by truer...@gmail.com)

Reviewers: lemzwerg, J_lowe, dak, Message: On 2015/08/26 07:09:10, dak wrote: On 2015/08/26 07:06:58, J_lowe wrote: > Patch counted down please push. > > PATCH_PUSH The commit message appears to talk about "antient.ly" instead of "ancient.ly". Fixing that before rebasing/pushing might be a

Re: Change the LilyPond default fonts to TeX Gyre (issue 258250043 by truer...@gmail.com)

On 2015/08/15 09:04:20, J_lowe wrote: https://codereview.appspot.com/258250043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/258250043/diff/20001/configure.ac#newcode98 configure.ac:98: STEPMAKE_ADD_ENTRY(REQUIRED,'(make sure the fc-list utility can see t

Re: Add font settings for Unicode demonstration (issue 258190043 by truer...@gmail.com)

https://codereview.appspot.com/258190043/diff/1/Documentation/snippets/new/utf-8.ly File Documentation/snippets/new/utf-8.ly (right): https://codereview.appspot.com/258190043/diff/1/Documentation/snippets/new/utf-8.ly#newcode1 Documentation/snippets/new/utf-8.ly:1: \version "2.18.0" On 2015/08/0

Re: Fix LilyPond default fonts definition (issue 258160043 by truer...@gmail.com)

https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/258160043/diff/1/lily/font-config.cc#newcode43 lily/font-config.cc:43: /* Create an empty configureation */ On 2015/08/08 14:08:45, lemzwerg wrote: s/configureati

Re: Add comment to font.scm and lilypond-fonts.conf.in (issue 257940043 by pkx1...@gmail.com)

LGTM Thank you. https://codereview.appspot.com/257940043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add comment to font.scm and lilypond-fonts.conf.in (issue 257940043 by pkx1...@gmail.com)

On 2015/07/27 12:27:26, J_lowe wrote: On 2015/07/27 12:10:24, trueroad wrote: > https://codereview.appspot.com/257940043/diff/1/scm/font.scm > File scm/font.scm (right): > > https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254 > scm/font.scm:254: ; are a

Add comment to font.scm and lilypond-fonts.conf.in (issue 257940043 by pkx1...@gmail.com)

https://codereview.appspot.com/257940043/diff/1/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/257940043/diff/1/scm/font.scm#newcode254 scm/font.scm:254: ; are aliases that are defined in mf/lilypond-fonts.conf.in. `mf/lilypond-fonts.conf.in' is filename in the source fil

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

Would you change this issue 4441's labels? I don't have permission to edit issue. git-cl shows like following. ``` Username (google account name): trueroad Password: This has been identified with code.google.com issue 4441. Is this correct? [y/n (y)] WARNING: could not change is

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

I've improved and uploaded the patch. Issue 4441 / 5: Reject bitmap fonts in lilypond-fonts.conf LilyPond can not use bitmap fonts. So this commit adds ``reject bitmap fonts'' from fontconfig's ``70-no-bitmaps.conf'' to lilypond-fonts.conf. Issue 4441 / 4: Define default fonts i

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

Reviewers: J_lowe, lemzwerg, https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc File lily/font-config.cc (right): https://codereview.appspot.com/241340043/diff/1/lily/font-config.cc#newcode62 lily/font-config.cc:62: for (vsize i = 0; i < confs.size (); i++) On 2015/06/11 22:14:

Re: Add Netpbm messages to verbose output (issue 240950043 by truer...@gmail.com)

Reviewers: J_lowe, Message: I've pushed. Issue 4420: Add Netpbm messages to verbose output authorMasamichi Hosoda Mon, 25 May 2015 14:41:16 + (23:41 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:39:19 + (22:39 +0900) commitb666e5959e3eb170e57bb1937f

Re: Fix png filename handling (issue 241760043 by truer...@gmail.com)

I've pushed Issue 4417 / 3: Fix png filename handling authorMasamichi Hosoda Sun, 24 May 2015 14:20:30 + (23:20 +0900) committer Masamichi Hosoda Sun, 31 May 2015 13:27:28 + (22:27 +0900) commit6a59207988b737482012aee97c6d3d5c1458a750 Issue 4417 / 2: Use ly

Re: Doc: Fix configure option (issue 236450043 by truer...@gmail.com)

Reviewers: J_lowe, Message: I've pushed. authorMasamichi Hosoda Fri, 22 May 2015 13:31:34 + (22:31 +0900) committer Masamichi Hosoda Thu, 28 May 2015 13:27:26 + (22:27 +0900) commitaa95943866a89d98f3af24bcb90b7859a043afba Description: Doc: Fix configure option configure optio

Fix png filename handling (issue 241760043 by truer...@gmail.com)

Reviewers: , Message: I've found that LilyPond fail to compile the source file whose name contains `%' to png files. For example, the following command fails. $ lilypond --png %foobar.ly This patch solve it. Description: Fix png filename handling This patch can compile the source file

Re: Use mkstemp for intermediate ps files (issue 233230044 by truer...@gmail.com)

I've pushed. Issue 4374 / 1: Fix platform identification authorMasamichi Hosoda Sat, 9 May 2015 08:20:19 + (17:20 +0900) committer Masamichi Hosoda Sat, 16 May 2015 11:56:31 + (20:56 +0900) commite2eb72d3d2070a3888df1f7e7907798833965baa Issue 4374 / 2: Add make-tmpfile procedu

Re: Use mkstemp for intermediate ps files (issue 233230044 by truer...@gmail.com)

I've divided and improved the patch. Issue 4374 / 1: Fix platform identification On Cygwin environment, Guile's uname returns the strings of "CYGWIN_NT-6.3" etc. It contains unnecessary strings for the platform identification, such as Windows version. Therefore, to remove

Re: Use mkstemp for intermediate ps files (issue 233230044 by truer...@gmail.com)

Just to add, it seems to fail make doc quite quickly (so if this log isn't helping you may want to try a make, make doc and see if you can debug it locally). Usually make doc can take a long time, and only fail near the end - but this seems to fail relatively quickly. I've fixed. I've s

Re: Use mkstemp for intermediate ps files (issue 233230044 by truer...@gmail.com)

If possible, please apply this rather large patch in smaller commits so that it becomes more readable. At least, I'll divide about PLATFORM variable changing. https://codereview.appspot.com/233230044/diff/20001/scm/backend-library.scm#newcode142 scm/backend-library.scm:142: ;; includeing un

Re: Fix lilypond-invoke-editor's temp dir (issue 234900043 by truer...@gmail.com)

Reviewers: J_lowe, Message: I've pushed to staging branch. http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=f758afb1497e9d95e564844363f23efa5a313321 Description: Fix lilypond-invoke-editor's temp dir To use environment variable TMP and TEMP is Windows-only conventions. The POSIX c

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

On 2015/04/07 18:19:25, lemzwerg wrote: > Wouldn't it make more sense to have one setting for all > of the included fonts? Are there really circumstances > where we can expect all of these to be different? Probably not. I think that the patch is a proof of concept, and we should comment on

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

On 2015/04/07 16:07:49, dak wrote: https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge File scripts/auxiliar/pfx2ttf-mono.fontforge (right): https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge#newcode17 scripts/auxiliar/

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

On 2015/04/02 04:29:07, wl_gnu.org wrote: >> Moreover, in my experiment, pango can't handle the ligature of >> PostScript Type1 font (.pfb with .afm or .pfm). It can handle the >> ligature of OpenType font (.otf). If you assumption is correct, this is clearly a bug. Looking into the source c

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

Reviewers: J_lowe, dak, c_sorensen, Message: On 2015/04/01 05:33:59, dak wrote: On 2015/03/31 22:18:11, c_sorensen wrote: > On 2015/03/31 15:57:54, dak wrote: > > Shouldn't we rather be selecting the Courier and Helvetica fonts (standard > > PostScript) and rely on GhostScript and/or font inst

  1   2   >