Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Mon, 2023-01-09 at 23:19 +0100, Jean Abou Samra wrote: > Le 09/01/2023 à 20:50, Jonas Hahnfeld a écrit : > > I tried very hard to install as much as possible from the official > > repositories (MetaPost on CentOS7 and Meson being the exceptions), > > which makes the environment very easy to repr

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Aaron Hill
On 2023-01-09 11:12 am, Jean Abou Samra wrote: I'm not really sure how to get factual data about this (a straw poll on the user list?). In my experience, for things like logos, SVG is more common (there *are* logos in PDF, they're just less common as far as I know, but again this is only my e

PATCHES - Countdown to January 11

2023-01-09 Thread Colin Campbell
Here is the current countdown report. The next countdown will begin on January 11th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !1804 open-type-font-scheme: Mark local variables when needed - Jean Abou

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Werner LEMBERG
>> Hmm. Just to be sure it makes probably sense to also check whether >> the Emmentaler OTFs are identical in the binary and documentation >> builds... > > How can I check for this? You disassemble the fonts with `ttx` from 'fonttools' and compare the created XML files. Thanks for the OTF, I've

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:50, Jonas Hahnfeld a écrit : I tried very hard to install as much as possible from the official repositories (MetaPost on CentOS7 and Meson being the exceptions), which makes the environment very easy to reproduce. I'm not too fond of the rustup approach in general... Maybe

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 22:52, Werner LEMBERG a écrit : It seems that with the versions of Pango/Fontconfig in this Docker image, the backslash character, which doesn't exist in Emmentaler, causes a fallback text font to be used, which obviously defeats the Emmentaler OTF feature that causes "9" and "\"

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:48, Jean Abou Samra a écrit : It seems that with the versions of Pango/Fontconfig in this Docker image, the backslash character, which doesn't exist in Emmentaler, causes a fallback text font to be used, which obviously defeats the Emmentaler OTF feature that causes "9" and "

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Werner LEMBERG
> It seems that with the versions of Pango/Fontconfig in this Docker > image, the backslash character, which doesn't exist in Emmentaler, > causes a fallback text font to be used, which obviously defeats the > Emmentaler OTF feature that causes "9" and "\" to be combined > specially. Hmm. Just

Re: The hel-arabic.ly file story...

2023-01-09 Thread Amir Czwink
Hello, if you have problems with English maybe try DeepL translater, it's pretty good: https://www.deepl.com/translator Anyways @Adam Good, thanks for your offering. You can find the merge request here: https://gitlab.com/lilypond/lilypond/-/merge_requests/1783 @Hassan EL FATIHI I'm not "changin

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:48, Jean Abou Samra a écrit : Le 09/01/2023 à 19:26, Jonas Hahnfeld a écrit : I build the documentation in a Docker container, steered by release/doc/build-doc.sh and documented in the CG. It is veeery unlikely that there is anything to this theory. Right. I did a quick te

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Mon, 2023-01-09 at 20:12 +0100, Jean Abou Samra wrote: > Le 09/01/2023 à 19:44, Jonas Hahnfeld a écrit : > > On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: > > > In order to keep support for vector graphics, even if not > > > with EPS, we can add support for embedding SVG images. > >

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 19:26, Jonas Hahnfeld a écrit : I build the documentation in a Docker container, steered by release/doc/build-doc.sh and documented in the CG. It is veeery unlikely that there is anything to this theory. Right. I did a quick test with \markup $(markup-lambda (layout props ar

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 20:12, Jean Abou Samra a écrit : while rustup arranges so that the version of Rust used in each project is the one specified in Cargo.toml. Sorry, I misremembered: s/Cargo.toml/rust-toolchain.toml. A pinned Rust version is specified there, Cargo.toml supports a minimum supporte

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 19:44, Jonas Hahnfeld a écrit : On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: In order to keep support for vector graphics, even if not with EPS, we can add support for embedding SVG images. Are we sure that this is actually what the users need? If everybody just car

Re: RFC: require librsvg to implement SVG image support

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Sun, 2023-01-08 at 23:18 +0100, Jean Abou Samra wrote: > In order to keep support for vector graphics, even if not > with EPS, we can add support for embedding SVG images. Are we sure that this is actually what the users need? If everybody just cares about including PDF (for logos), I'm not sur

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Mon, 2023-01-09 at 19:19 +0100, Jean Abou Samra wrote: > Le 09/01/2023 à 19:02, Werner LEMBERG a écrit : > > Have a look at > > > >https://lilypond.org/doc/v2.24/Documentation/notation/font > > > > and check the example for `\figured-bass`, which is wrong. If I > > compile this with a cur

Re: Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Jean Abou Samra
Le 09/01/2023 à 19:02, Werner LEMBERG a écrit : Have a look at https://lilypond.org/doc/v2.24/Documentation/notation/font and check the example for `\figured-bass`, which is wrong. If I compile this with a current lilypond binary, I get correct output (see attached image). I also get this

Wrong `\figured-bass` markup rendering in documentation

2023-01-09 Thread Werner LEMBERG
Have a look at https://lilypond.org/doc/v2.24/Documentation/notation/font and check the example for `\figured-bass`, which is wrong. If I compile this with a current lilypond binary, I get correct output (see attached image). I also get this if I build the documentation by myself on my compu

Re: The hel-arabic.ly file story...

2023-01-09 Thread hassan . elfatihi
Hello I believe you are changing everything ,if I understood correctly. it was necessary to delete 7/2 and 5/2 and we are tempted to compare arablic.ly and hel-arabic.ly which aren't the same. I absolutely do not agree all your modifications but do what you want. To say for example that nahawand i

Re: RFC: require librsvg to implement SVG image support,RFC: require librsvg to implement SVG image support

2023-01-09 Thread Werner LEMBERG
> Therefore, the proposal here is to add librsvg as a dependency to > LilyPond. The transitive dependencies it pulls in are libxml2, > GdkPixbuf, and libjpeg (the latter for GdkPixbuf). Your proposal sounds good to me. > * If so, how do we manage the transition? Do we make them optional > a

Re: The hel-arabic.ly file story...

2023-01-09 Thread Werner LEMBERG
> I'm around (Adam Good) and though I worked on the turkish-makam.ly file and > Turkish makam is most my specialty, I'd be happy to look at any ly file you > may be working on currently and give my thoughts or thumbs up. Great! Please have a look at Amir's merge request. https://gitlab.com/l