https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc
File lily/slur.cc (right):
https://codereview.appspot.com/577820043/diff/555750043/lily/slur.cc#newcode380
lily/slur.cc:380: vector boxes;
Please move vector> segments here and use to for the
early return
https://codereview.ap
https://codereview.appspot.com/561680043/diff/557780043/lily/transform.cc
File lily/transform.cc (right):
https://codereview.appspot.com/561680043/diff/557780043/lily/transform.cc#newcode39
lily/transform.cc:39: #include
As Dan mentioned "transform.hh" should be the first include and IMO
system
On Sun, Apr 26, 2020 at 10:04 PM Valentin Villenave
wrote:
>
> On 4/26/20, hanw...@gmail.com wrote:
> > I can host this script somewhere else so it can be referenced in the CG,
> > but I don't think there optimizing our C++ code is a domain for
> > beginners.
>
> I may be off the mark here, but
I am currently getting this error when trying to build GUB:
Tail of target/tools/log/fontforge.log
checking Build with LibUniNamesList Unicode support?... configure: error: in
`/home/gub/NewGub/gub/target/tools/build/fontforge-20190801':
configure: error: You may provide option `--withou
On 4/26/20, hanw...@gmail.com wrote:
> I can host this script somewhere else so it can be referenced in the CG,
> but I don't think there optimizing our C++ code is a domain for
> beginners.
I may be off the mark here, but what about adding your speed test into
the standard regression test suite
LGTM (interesting that you found unused methods from 2012 :D)
https://codereview.appspot.com/583750043/
https://codereview.appspot.com/583750043/diff/557770050/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/583750043/diff/557770050/lily/skyline.cc#newcode584
lily/skyline.cc:584: for (auto const b : buildings_)
On 2020/04/26 11:28:19, hahnjo wrote:
> I think this will
Doh. Thanks, as ever.
It then failed trying to access https://pkg-config.freedesktop.org/ which
appears to be off the air at present. I found an alternative at fossies.org
and updated sources.py to use this location. It now gives me:
Tail of target/tools/log/fontforge.log
checkin
Looks good with respect to using auto. One question inline, might be a
missing reference.
https://codereview.appspot.com/583750043/diff/557770050/lily/skyline.cc
File lily/skyline.cc (right):
https://codereview.appspot.com/583750043/diff/557770050/lily/skyline.cc#newcode584
lily/skyline.cc:584:
Am Sonntag, den 26.04.2020, 11:25 +0100 schrieb Phil Holmes:
> Can anyone help? I'm getting this
>
> /home/gub/NewGub/gub/target/linux-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/mf/gen-emmentaler.fontforge.py
>
> line: 2 Undefined variable: import
> make[1]: *** [out/emmental
On Sun, Apr 26, 2020 at 11:26 AM Werner LEMBERG wrote:
> Unfortunately, the OpenType standard doesn't store the orientation of
> outlines in the `glyf` or `CFF` (or `CFF2`) table. In other words,
> this has to be computed, which further means that you have to use
> `FT_Outline_Get_Orientation` so
URLs using www have escaped this update:
$ ag http://www\.lilypond\.org
Documentation/po/pt.po
11750:"see also
http://www.lilypond.org/doc/v2.18/Documentation/snippets/tweaks-and-";
14090:"see also
http://www.lilypond.org/doc/v2.18/Documentation/notation/repeats";
Documentation/ly-examples/bach-b
On 2020/04/24 13:15:10, dak wrote:
> mailto:hanw...@gmail.com writes:
>
> > Here is how I have experienced this discussion:
> >
> > DAK: this is micro-optimization that causes memory fragmentation.
> >
> > HW: No, it's not; here is a benchmark that shows decreased memory
use as
> > well.
> >
> > D
Can anyone help? I'm getting this
/home/gub/NewGub/gub/target/linux-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/mf/gen-emmentaler.fontforge.py
line: 2 Undefined variable: import
make[1]: *** [out/emmentaler-11.svg] Error 1
make[1]: *** Waiting for unfinished jobs
Making m
>> The 'inner' outline of an 'O' glyph has exactly the opposite
>> direction of the outer outline. In other words, for getting the
>> outermost outline(s) of a glyph you can always skip such 'inner'
>> ones.
>
> I'm confused. Our code currently does
>
> FT_Load_Glyph (face, idx, FT_LOAD_NO_SC
Am Sonntag, den 26.04.2020, 09:50 +0100 schrieb James Lowe:
> Apologies for no countdown or patch testing yesterday, I had no Internet
> connection all morning and just gave up checking after many hours.
I think there's really no need for you to apologize. In my opinion it's
just remarkable how y
>> PostScript flavoured glyphs like PFA or OTF[*] have the opposite
>> orientation. You can easily check whether the used FreeType driver
>> for a font is 'truetype':
>>
>> FT_Face face = Get_FT_Face_For_Current_Font(...);
>> FT_Module module;
>>
>> module = &face->driver->root;
>> if (!st
Hello,
Apologies for no countdown or patch testing yesterday, I had no Internet
connection all morning and just gave up checking after many hours.
Here is the current patch countdown list. The next countdown will (now)
be on April 28th
A quick synopsis of all patches currently in the review
Reviewers: lemzwerg, Dan Eble,
https://codereview.appspot.com/561680043/diff/577820044/lily/include/transform.hh
File lily/include/transform.hh (right):
https://codereview.appspot.com/561680043/diff/577820044/lily/include/transform.hh#newcode33
lily/include/transform.hh:33: int print_smob (SCM p
Reviewers: ,
Message:
commit 7073ab2d033f82eb797d6fcefd3cd18c98fb3d63
Author: Han-Wen Nienhuys
Date: Fri Apr 3 23:10:17 2020 +0200
Use HTTPS for lilypond.org throughout
https://sourceforge.net/p/testlilyissues/issues/5877
http://codereview.appspot.com/575950043
Description
On Sat, Apr 25, 2020 at 9:42 PM Werner LEMBERG wrote:
> > Also, is there is way to detect internal curves (eg. the inner curve
> > of the O glyph?).
>
> The 'inner' outline of an 'O' glyph has exactly the opposite direction
> of the outer outline. In other words, for getting the outermost
> outli
On Sat, Apr 25, 2020 at 9:53 PM Werner LEMBERG wrote:
>
>
> > In https://docs.microsoft.com/en-us/typography/opentype/spec/ttch01
> > it is explained that outside curves go clockwise. Does that hold for
> > other font types too? (PFA, OTF?)
>
> PostScript flavoured glyphs like PFA or OTF[*] have t
Am Samstag, den 25.04.2020, 21:53 +0200 schrieb Francisco Vila:
> El 24/4/20 a las 17:18, Jonas Hahnfeld escribió:
> > However I'm pretty sure that many translations in the latter are dead:
> > As far as I understand we don't translate the docs by putting the
> > strings in Documentation/po, but ra
Reviewers: ,
Message:
goes on top of https://codereview.appspot.com/581960043/
Description:
Create skylines directly from glyph outlines.
This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.
Benchmark:
benchmark for arguments: input/regression/mozart-h
Reviewers: ,
Message:
goes on top of https://codereview.appspot.com/561730043/
Description:
Split glyph contours in up/down segments for skylines
This reduces the amount of skyline input coming from glyph outlines by
2x.
benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b
On 2020/04/25 22:05:26, dak wrote:
> On 2020/04/25 17:07:17, hahnjo wrote:
> > I strongly object to adding more random scripts to the source tree.
There are
> > already far too many unmaintained in scripts/auxiliar/ with no
documentation
> at
> > all.
>
> How about approaching this in a different
26 matches
Mail list logo
