Re: Issue 5344: Avoid repeated calculation of accepted contexts (issue 346080043 by nine.fierce.ball...@gmail.com)

2018-06-14 Thread nine . fierce . ballads
Reviewers: dak, Message: Thank you for your review. I disagree with some of your conclusions. https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc File lily/acceptance-set.cc (right): https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc#newcode34 lily/accep

Issue 5344: Avoid repeated calculation of accepted contexts (issue 346080043 by nine.fierce.ball...@gmail.com)

2018-06-14 Thread dak
https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc File lily/acceptance-set.cc (right): https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc#newcode34 lily/acceptance-set.cc:34: if (!scm_is_null (default_)) Why do you prioritize the default child? The only