Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

LGTM. https://codereview.appspot.com/226700043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

baseMoment does have another use. It is used to define the major beaming groups for automatic beaming. So if you have a 5/8 time signature, and you want to beam it 3+2, you would do the following: \set baseMoment = #(ly:make-moment 1 8) \set beatStructure = '(3 2) If you want to subdivide t

Re: \set Staff.midiInstrument has no effect in RhythmicStaff

Il 26/04/15 02.19, Thomas Morley ha scritto: Maybe Issue 4281, should be fixed for 2.19.17 and late. Try: \score { \new RhythmicStaff { %\set RhythmicStaff.midiInstrument = "flute" \set Staff.midiInstrument = "flute" c } \midi { \context { \RhythmicStaff \

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

I have now checked the code for my interface idea, and it seems to work. In short, I did the following: - assign the subdivideBeams context property to base_moment - set subdivide_beams_ to true or false, depending on the value of base_moment_ - change to predicate of subdivideBeams to ly:moment?

Re: \set Staff.midiInstrument has no effect in RhythmicStaff

Davide Liessi writes: > Il 26/04/15 01.38, David Kastrup ha scritto: >> Davide Liessi writes: >>> "\set Staff.midiInstrument = ..." has no effect when used inside a >>> RhythmicStaff. >> >> Minimal example exhibiting the problem, version number? > > \version "2.19.15" > \score { > \new Rhythmi

Re: \set Staff.midiInstrument has no effect in RhythmicStaff

2015-04-26 1:51 GMT+02:00 Davide Liessi : > Il 26/04/15 01.38, David Kastrup ha scritto: >> >> Davide Liessi writes: >>> >>> "\set Staff.midiInstrument = ..." has no effect when used inside a >>> RhythmicStaff. >> >> >> Minimal example exhibiting the problem, version number? > > > \version "2.19.1

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

On 2015/04/25 22:58:56, Carl wrote: On 2015/04/25 11:54:01, benko.pal wrote: > 2015-04-25 10:20 GMT+02:00 : > > Thank you for picking this up. It is certainly an improvement already. > > > > However: In an example where 8 32th notes are subdivided by 16th note

Re: \set Staff.midiInstrument has no effect in RhythmicStaff

Il 26/04/15 01.38, David Kastrup ha scritto: Davide Liessi writes: "\set Staff.midiInstrument = ..." has no effect when used inside a RhythmicStaff. Minimal example exhibiting the problem, version number? \version "2.19.15" \score { \new RhythmicStaff { %\set RhythmicStaff.midiInstrum

Re: \set Staff.midiInstrument has no effect in RhythmicStaff

Davide Liessi writes: > Dear all, > "\set Staff.midiInstrument = ..." has no effect when used inside a > RhythmicStaff. > > I didn't expect this, since (at least some of) the other properties of > RhythmicStaff can be set with "\set Staff...". > E.g. "\set Staff.instrumentName = ..." correctly se

Understanding and modifying font nodes

I have wrapped around about anything I could think of, but I'm stuck and would greatly benefit of some help now. I'm working on the font interface and will (hopefully soon) present a patch that may improve font handling (with the new alternative fonts provided by Abraham) significantly. The la

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

On 2015/04/25 11:54:01, benko.pal wrote: 2015-04-25 10:20 GMT+02:00 : > Thank you for picking this up. It is certainly an improvement already. > > However: In an example where 8 32th notes are subdivided by 16th notes > ony the first and third subdivision sho

\set Staff.midiInstrument has no effect in RhythmicStaff

Dear all, "\set Staff.midiInstrument = ..." has no effect when used inside a RhythmicStaff. I didn't expect this, since (at least some of) the other properties of RhythmicStaff can be set with "\set Staff...". E.g. "\set Staff.instrumentName = ..." correctly sets the printed instrument name w

Re: \change Voice

On Fri, 24 Apr 2015 22:04:28 -0700, David Kastrup wrote: Keith OHara writes: The thing you want to change is the "outlet" of the sequential iterator. That's just \context Voice = "xxx". However, it does not take engravers and properties along, as opposed to \change ... Yes. The current

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Carl Sorensen writes: > On 4/25/15 6:37 AM, "Urs Liska" wrote: > >>> >>> In that context I'd like to raise the question if baseMoment really is >>> the appropriate property for configuring beamSubdivision or if it >>> shouldn't have a dedicated property. Changing baseMoment might have >>> side-e

Re: Trouble building old versions of LilyPond

On 4/25/15 9:05 AM, "David Kastrup" wrote: >Carl Sorensen writes: > >> >> Any suggestions on how I can make old versions compile so I can decide >> when/where the denominators disappeared? > >No. There is also stuff like the Freetype library having changed its >interface more recently and so on

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

On 4/25/15 6:37 AM, "Urs Liska" wrote: >> >> In that context I'd like to raise the question if baseMoment really is >> the appropriate property for configuring beamSubdivision or if it >> shouldn't have a dedicated property. Changing baseMoment might have >> side-effects on other aspects of the

Re: Trouble building old versions of LilyPond

Carl Sorensen writes: > I'm trying to fix the problems with autobeaming. > > I have discovered that in lily/beaming-patterns.cc, inside the > function Beaming_pattern::beatify, infos[i].start_moment_ has only > numerators.  All the denominators are zero.  I'm pretty sure it wasn't > this way the

Trouble building old versions of LilyPond

I'm trying to fix the problems with autobeaming. I have discovered that in lily/beaming-patterns.cc, inside the function Beaming_pattern::beatify, infos[i].start_moment_ has only numerators.  All the denominators are zero.  I'm pretty sure it wasn't this way the last time I looked at it. So I

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Am 25.04.2015 um 13:58 schrieb Urs Liska: Am 25.04.2015 um 13:33 schrieb carl.d.soren...@gmail.com: Reviewers: lemzwerg, uliska, Message: Ok, so let me see if I understand what you are saying. Unfortunately I'm not 100% sure if I understand your questions correctly, so I'm not sure if my

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Am 25.04.2015 um 13:54 schrieb Benkő Pál: 2015-04-25 10:20 GMT+02:00 : Thank you for picking this up. It is certainly an improvement already. However: In an example where 8 32th notes are subdivided by 16th notes ony the first and third subdivision should have two beams, the second one only

Re: Images in doc

Am 25.04.2015 um 10:34 schrieb Joram: Hi, is it a general no-go to have images in the docs? I don't think there's anything that completely speaks agains images. I know these counter arguments: 1. not helpful for visually impaired users I think it would be enough to make sure that informa

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Am 25.04.2015 um 13:33 schrieb carl.d.soren...@gmail.com: Reviewers: lemzwerg, uliska, Message: Ok, so let me see if I understand what you are saying. Unfortunately I'm not 100% sure if I understand your questions correctly, so I'm not sure if my answers will make perfect sense to you ...

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

2015-04-25 10:20 GMT+02:00 : > Thank you for picking this up. It is certainly an improvement already. > > However: In an example where 8 32th notes are subdivided by 16th notes > ony the first and third subdivision should have two beams, the second > one only one beam. > > Put differently: when th

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Reviewers: lemzwerg, uliska, Message: Ok, so let me see if I understand what you are saying. When we choose to subdivide beams with a given baseMoment, there should be a subdivision at baseMoment and at every even interval larger than that. So if we have a baseMoment of 1/32, we should subdivid

Re: Images in doc

Hi, > Uh, we have images in the docs? Ok sorry, I havn’t seen many that are not generated by ly code. This is one: http://lilypond.org/doc/v2.18/Documentation/pictures/context-example.png >> If there are changes to include that to the docs and I hear about the >> way/program to create the image,

Re: Images in doc

Joram writes: > Hi, > > is it a general no-go to have images in the docs? Uh, we have images in the docs? Wagonloads of them? To the degree where generating them takes the lion's share of the Documentation build time? > If there are changes to include that to the docs and I hear about the > w

Re: \change Voice

Keith OHara writes: > Dan Eble faithful.be> writes: > >> >> Would it be hard to make \change Voice work as below without relying on >> the extra “NoteSequence” context? >> >> \layout { >> \context { >> \name "Thread" >> \type "Engraver_group" >> } >> \context { >> \Voice >>

Images in doc

Hi, is it a general no-go to have images in the docs? I know these counter arguments: 1. not helpful for visually impaired users 2. larger binary blobs for version control 3. reduced ability to edit, recreate and update However, I see big advantages in some cases, for instance settings of vertica

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

On 2015/04/25 08:20:52, uliska wrote: Thank you for picking this up. It is certainly an improvement already. However: In an example where 8 32th notes are subdivided by 16th notes ony the first and third subdivision should have two beams, the second one only one beam. Put differently: wh

Re: Fix issue 4355 -- broken beam subdivision (issue 226700043 by carl.d.soren...@gmail.com)

Thank you for picking this up. It is certainly an improvement already. However: In an example where 8 32th notes are subdivided by 16th notes ony the first and third subdivision should have two beams, the second one only one beam. Put differently: when there is following a total of an eighth not