Re: Cleanup of ugly MI and SOL shaped noteheads (issue 45160043)

2013-12-23 Thread Werner LEMBERG
> I think this happened when I updated the source before submitting. > How do I get it out? You have to upload a new patch set (using the same issue ID on rietveld). > On 2013/12/24 00:57:53, lemzwerg wrote: >> Please stay in the 80-char-per-line limit. > > Does MF allow for line wrapping inside

Re: Cleanup of ugly MI and SOL shaped noteheads (issue 45160043)

2013-12-23 Thread carlopeterson
https://codereview.appspot.com/45160043/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (left): https://codereview.appspot.com/45160043/diff/1/Documentation/contributor/source-code.itexi#oldcode1387 Documentation/contributor/source-code.itexi:1

Re: Cleanup of ugly MI and SOL shaped noteheads (issue 45160043)

2013-12-23 Thread lemzwerg
LGTM, codewise. Since I don't use Sacred Harp notation, I can't give further comments w.r.t. usefulness or correctness. https://codereview.appspot.com/45160043/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (left): https://codereview.appspot

Cleanup of ugly MI and SOL shaped noteheads (issue 45160043)

2013-12-23 Thread carlopeterson
Reviewers: , Message: Patch for review to make shaped noteheads conform more closely to personally-observed practice. Description: Cleanup of ugly MI and SOL shaped noteheads 1. Reducing width of MI notehead, for both "regular" (Aiken, etc.) and "small" (Funk/Walker) heads. When Funk/Walker

Re: Fwd: Re: Issue 3719 in lilypond: Patch: CG: Add comment about git-cl editor

2013-12-23 Thread David Kastrup
James writes: > On 23/12/13 12:26, Urs Liska wrote: >> Am 23.12.2013 13:02, schrieb David Kastrup: >>> Urs Liska writes: >>> Am 23.12.2013 12:45, schrieb Urs Liska: > Attached is an updated patch using @command instead of @code. > Rebased patch passes make doc (issues in other

Re: Fwd: Re: Issue 3719 in lilypond: Patch: CG: Add comment about git-cl editor

2013-12-23 Thread James
On 23/12/13 12:26, Urs Liska wrote: Am 23.12.2013 13:02, schrieb David Kastrup: Urs Liska writes: Am 23.12.2013 12:45, schrieb Urs Liska: Attached is an updated patch using @command instead of @code. Rebased patch passes make doc (issues in other subthread solved). Thanks for pushing Urs

Re: Fwd: Re: Issue 3719 in lilypond: Patch: CG: Add comment about git-cl editor

2013-12-23 Thread David Kastrup
Urs Liska writes: > Am 23.12.2013 13:02, schrieb David Kastrup: >> Urs Liska writes: >> >>> Am 23.12.2013 12:45, schrieb Urs Liska: >>> Attached is an updated patch using @command instead of @code. Rebased patch passes make doc (issues in other subthread solved). Thanks for p

Re: Fwd: Re: Issue 3719 in lilypond: Patch: CG: Add comment about git-cl editor

2013-12-23 Thread Urs Liska
Am 23.12.2013 13:02, schrieb David Kastrup: Urs Liska writes: Am 23.12.2013 12:45, schrieb Urs Liska: Attached is an updated patch using @command instead of @code. Rebased patch passes make doc (issues in other subthread solved). Thanks for pushing Urs Sorry, found an error after reading

Re: Fwd: Re: Issue 3719 in lilypond: Patch: CG: Add comment about git-cl editor

2013-12-23 Thread Urs Liska
Am 22.12.2013 12:06, schrieb David Kastrup: Urs Liska writes: Am 22.12.2013 10:54, schrieb David Kastrup: I see that you used @code{vi} and @code{git-cl} rather than @command{vi} and @command{git-cl}: any particular reason for that? I was suggested to use that on Rietveld. So, no, no parti