Re: replaced function argument 'string' by 'const string&' where it makes sense to avoid unnecessary co… (issue 13537043)

2013-09-09 Thread dak
https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc File lily/file-name-map.cc (left): https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc#oldcode32 lily/file-name-map.cc:32: s = file_name_map_global[s]; On 2013/09/07 04:44:02, fred1995 wrote: Then it would req

Re: Handle MultiMeasureRest direction in the part combiner like other elements (issue 13302048)

2013-09-09 Thread ianhulin44
texidoc string comment nit-pick, otherwise LGTM. https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-apart.ly File input/regression/part-combine-mmrest-apart.ly (right): https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-a

Re: 2.17.26 regression tests

2013-09-09 Thread Keith OHara
David Kastrup gnu.org> writes: > You make it sound as if issue 2910 will warrant a bunch of fine-tuning > before the results can be called production-ready. No, the stencil-integral patch had changed the meaning of a padding, we started started fine-tuning the defaults in response, then the pa

Re: 2.17.26 regression tests

2013-09-09 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "Phil Holmes" > To: ; "Keith OHara" > Sent: Monday, September 09, 2013 9:18 AM > Subject: Re: 2.17.26 regression tests > >> I'd seen the same long list of regressions before I uploaded the >> release, and presumed it was down to slig

Re: 2.17.26 regression tests

2013-09-09 Thread Phil Holmes
- Original Message - From: "Phil Holmes" To: ; "Keith OHara" Sent: Monday, September 09, 2013 9:18 AM Subject: Re: 2.17.26 regression tests I'd seen the same long list of regressions before I uploaded the release, and presumed it was down to slight padding changes. I plan to run the

Re: Mensural flags

2013-09-09 Thread David Kastrup
"Phil Holmes" writes: > In the NR, under > http://www.lilypond.org/doc/v2.17/Documentation/notation/typesetting-mensural-music#mensural-flags > under known issues and warnings, we have > > "The attachment of ancient flags to stems is slightly off." > > That was http://code.google.com/p/lilypond/i

Mensural flags

2013-09-09 Thread Phil Holmes
In the NR, under http://www.lilypond.org/doc/v2.17/Documentation/notation/typesetting-mensural-music#mensural-flags under known issues and warnings, we have "The attachment of ancient flags to stems is slightly off." That was http://code.google.com/p/lilypond/issues/detail?id=3105, fixed in t

Re: Patchy email

2013-09-09 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: Sent: Monday, September 09, 2013 9:25 AM Subject: Re: Patchy email "Phil Holmes" writes: - Original Message - From: "David Kastrup" To: Sent: Monday, September 09, 2013 9:11 AM Subject: Re: Patchy email

Patchy email

2013-09-09 Thread phileholmes
08:56:20 (UTC) Begin LilyPond compile, previous commit at c0a691181c981f55ef28e5daa8410b41e37ef808 08:56:23 *** FAILED STEP *** merge from staging Command '['git', 'fetch']' returned non-zero exit status 1 error: unable to resolve reference refs/remotes/origin/dev/janek/expe

Re: Patchy email

2013-09-09 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: > Sent: Monday, September 09, 2013 9:11 AM > Subject: Re: Patchy email > > >> David Kastrup writes: >> >>> philehol...@googlemail.com writes: >>> error: some local refs could not be updated; try running >>

Re: Patchy email

2013-09-09 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Monday, September 09, 2013 9:11 AM Subject: Re: Patchy email David Kastrup writes: philehol...@googlemail.com writes: error: some local refs could not be updated; try running 'git remote prune origin' to remove any old, confl

Re: Patchy email

2013-09-09 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: > Sent: Monday, September 09, 2013 9:05 AM > Subject: Re: Patchy email > > >> philehol...@googlemail.com writes: >> >>> error: some local refs could not be updated; try running >>> 'git remote prune origin' to

Re: 2.17.26 regression tests

2013-09-09 Thread Phil Holmes
- Original Message - From: "Keith OHara" To: Sent: Monday, September 09, 2013 5:59 AM Subject: 2.17.26 regression tests I re-pushed the fix for issue 2910, which fixes the implementation of outside-staff-padding, so many many regtests change slightly ... for the third time. Sorry a

Re: Patchy email

2013-09-09 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Monday, September 09, 2013 9:05 AM Subject: Re: Patchy email philehol...@googlemail.com writes: error: some local refs could not be updated; try running 'git remote prune origin' to remove any old, conflicting branches Well, y

Re: Patchy email

2013-09-09 Thread David Kastrup
David Kastrup writes: > philehol...@googlemail.com writes: > >> error: some local refs could not be updated; try running >> 'git remote prune origin' to remove any old, conflicting branches > > Well, yes. Either do that, or look up how to prune just dev/janek. That would likely be git branch

Patchy email

2013-09-09 Thread phileholmes
08:05:40 (UTC) Begin LilyPond compile, previous commit at c0a691181c981f55ef28e5daa8410b41e37ef808 08:07:32 *** FAILED STEP *** merge from staging Command '['git', 'fetch']' returned non-zero exit status 1 error: unable to resolve reference refs/remotes/origin/dev/janek/expe

Re: Patchy email

2013-09-09 Thread David Kastrup
philehol...@googlemail.com writes: > error: some local refs could not be updated; try running > 'git remote prune origin' to remove any old, conflicting branches Well, yes. Either do that, or look up how to prune just dev/janek. He first created this as a branch, then changed it to a branch di

Patchy email

2013-09-09 Thread phileholmes
07:58:57 (UTC) Begin LilyPond compile, previous commit at c0a691181c981f55ef28e5daa8410b41e37ef808 07:59:10 *** FAILED STEP *** merge from staging Command '['git', 'fetch']' returned non-zero exit status 1 error: unable to resolve reference refs/remotes/origin/dev/janek/expe

Patchy email

2013-09-09 Thread phileholmes
07:58:14 (UTC) Begin LilyPond compile, previous commit at a71356bae841fad9b08f8d29f7fc26688de3f302 07:58:35 *** FAILED STEP *** merge from staging Command '['git', 'fetch']' returned non-zero exit status 1 error: unable to resolve reference refs/remotes/origin/dev/janek/expe