I tried to go through and look for unintended consequences.
I guess f(const string &s) is conventional in C++, so I guess this looks
good to me.
https://codereview.appspot.com/13537043/diff/1/lily/file-name-map.cc
File lily/file-name-map.cc (left):
https://codereview.appspot.com/13537043/diff/1
Just in case the lilypond package for fedora is built by the lilypond team:
I have submitted a bug report to fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1005394
vim has been updated from 7.3 to 7.4 but the lilypond package
continues to put its files in /usr/share/vim/vim73.
Frédéric
_
Reviewers: dak,
Message:
On 2013/09/06 16:39:24, dak wrote:
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make
File stepmake/stepmake/generic-targets.make (right):
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make#newcode
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make
File stepmake/stepmake/generic-targets.make (right):
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make#newcode1
stepmake/stepmake/generic-targets.make:1: .PHONY : all clean b
LGTM, save the 72pt vs. 72.27pt issue.
https://codereview.appspot.com/13457046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
pushed as 1883fef6da1f91b1985ac296f0eb5bc9aee613ec
https://codereview.appspot.com/4609041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
