Re: order of function arguments

2013-04-21 Thread David Kastrup
Janek Warchoł writes: > Hi, > > On 2013/04/21 08:23:34, dak wrote: >> Janek Warchoł writes: >> >> > 2013/4/16 : >> >> Uh, a call of offset can be followed by music quite naturally. So this >> >> is not just a "technical restriction". It is one of logic. >> > >

Doc: Augment section about titles (3103) (issue 8895044)

2013-04-21 Thread ianhulin44
LGTM Cheers, Ian https://codereview.appspot.com/8895044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-21 Thread janek . lilypond
Hi, On 2013/04/20 00:03:17, fanziye1 wrote: Hi Janek, It seems I forgot to publish this issue in list. This is for the googlecode issue 1367. Only a few c++ code was added, nothing done with regression test and docs. Was it appropriate to post a patch like this? Or is there anything I should do

order of function arguments (was: Add the command \offset)

2013-04-21 Thread Janek Warchoł
Hi, On 2013/04/21 08:23:34, dak wrote: > Janek Warchoł writes: > > > 2013/4/16 : > >> Uh, a call of offset can be followed by music quite naturally. So this > >> is not just a "technical restriction". It is one of logic. > > > > So, do i understand correctly th

Re: is changing OctavateEight to ClefModifier appropriate for 2.18?

2013-04-21 Thread Janek Warchoł
2013/4/21 David Kastrup : > Janek Warchoł writes: > >> http://code.google.com/p/lilypond/issues/detail?id=3309 >> https://codereview.appspot.com/8614045 >> >> This had passed countdown (with 0 reviews). I'm not sure if it's >> "stable enough" to be included in 2.18 - should i push it or set it's >

Re: Point and Click does not work on Windows

2013-04-21 Thread Eluze
James wrote > Hello, > > > On 21 April 2013 13:18, Eluze < > eluzew@ > > wrote: > >> James wrote > > I'm not sure what you mean here. > > For instance in Windows there is > > Control Panel\Programs\Default Programs\Set Associations > > or > > Control Panel\Programs\Default Programs\Set De

Re: Point and Click does not work on Windows

2013-04-21 Thread James
Hello, On 21 April 2013 13:18, Eluze wrote: > James wrote > > Hello, > > > > > > On 21 April 2013 11:56, Eluze < > > > eluzew@ > > > > wrote: > > > >> James wrote > >> > > >> > Am I supposed to run this bat file pre-edited or with an argument or > >> > something? > >> > >> hi James > >> > >> 2n

Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread lilyfan
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422 Documentation/notation/rhythms.itely:1422: is usually positive and

Re: Doc: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread tdanielsmusic
Thanks Graham. https://codereview.appspot.com/8622047/diff/8002/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/8622047/diff/8002/Documentation/notation/pitches.itely#newcode1499 Documentation/notation/pitches.itely:1499: \f

Re: Point and Click does not work on Windows

2013-04-21 Thread Eluze
James wrote > Hello, > > > On 21 April 2013 11:56, Eluze < > eluzew@ > > wrote: > >> James wrote >> > >> > Am I supposed to run this bat file pre-edited or with an argument or >> > something? >> >> hi James >> >> 2nd >> >> regQuery.bat myFile.ly >> or >> regQuery.bat "D:\data\…\myfile.ly" >> >

Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread tdanielsmusic
Reviewers: Graham Percival, Jean-Charles, Message: Thanks for the review! https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#new

Re: Point and Click does not work on Windows

2013-04-21 Thread James
Hello, On 21 April 2013 11:56, Eluze wrote: > James wrote > > > > Am I supposed to run this bat file pre-edited or with an argument or > > something? > > hi James > > 2nd > > regQuery.bat myFile.ly > or > regQuery.bat "D:\data\…\myfile.ly" > > C:\Users\jlowe\Desktop>regQuery.bat Dak.ly myExt=.l

Re: Point and Click does not work on Windows

2013-04-21 Thread Eluze
James wrote > > Am I supposed to run this bat file pre-edited or with an argument or > something? hi James 2nd regQuery.bat myFile.ly or regQuery.bat "D:\data\…\myfile.ly" thanks for the feedback! Eluze -- View this message in context: http://lilypond.1069038.n5.nabble.com/Point-and-Click-

Re: Doc: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread graham
https://codereview.appspot.com/8622047/diff/8002/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/8622047/diff/8002/Documentation/notation/pitches.itely#newcode1499 Documentation/notation/pitches.itely:1499: \flute Since the \

Re: Point and Click does not work on Windows

2013-04-21 Thread James
hello, On 21 April 2013 10:43, Eluze wrote: > ArnoldTheresius wrote > > Until now I did not find a function in guile to read registry values. > > There is the command line program »REG QUERY ... « to get the > information. > > It's standard output needs to be parsed, and the call needs to be fa

Re: Point and Click does not work on Windows

2013-04-21 Thread Eluze
ArnoldTheresius wrote > Until now I did not find a function in guile to read registry values. > There is the command line program »REG QUERY ... « to get the information. > It's standard output needs to be parsed, and the call needs to be fail > save (dont throw an exception if it fails). > > … >

Re: Doc: Augment description of how to customise staff line positions (3175) (issue 8540046)

2013-04-21 Thread lilyfan
LGTM https://codereview.appspot.com/8540046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread lilyfan
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422 Documentation/notation/rhythms.itely:1422: is usually positive and

Re: Doc: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread lilyfan
LGTM https://codereview.appspot.com/8622047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread Trevor Daniels
gra...@percival-music.ca > error: old chunk mismatch. Could you re-upload? Done; what causes this? Did I forget to rebase maybe? > https://codereview.appspot.com/8622047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/

Re: Doc: Change \on-the-fly #procedure to \on-the-fly \procedure (3098) (issue 8853044)

2013-04-21 Thread graham
LGTM https://codereview.appspot.com/8853044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Document the use of \temporary (2938) (issue 8859044)

2013-04-21 Thread graham
LGTM https://codereview.appspot.com/8859044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread graham
LGTM https://codereview.appspot.com/8538050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread graham
error: old chunk mismatch. Could you re-upload? https://codereview.appspot.com/8622047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Augment description of how to customise staff line positions (3175) (issue 8540046)

2013-04-21 Thread graham
LGTM https://codereview.appspot.com/8540046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add the command \offset to LilyPond (issue 8647044)

2013-04-21 Thread David Kastrup
Janek Warchoł writes: > Sorry for the delay, got little lilypond-time recently... > > 2013/4/16 : >> On 2013/04/16 14:33:50, janek wrote: >>> >>> 2013/4/16 : >>> > nothing-or-music in the last position only works if "nothing" is >>> > _explicitly_ specified with \default >>> > >>> > There is no

Re: is changing OctavateEight to ClefModifier appropriate for 2.18?

2013-04-21 Thread David Kastrup
Janek Warchoł writes: > http://code.google.com/p/lilypond/issues/detail?id=3309 > https://codereview.appspot.com/8614045 > > This had passed countdown (with 0 reviews). I'm not sure if it's > "stable enough" to be included in 2.18 - should i push it or set it's > status to waiting? I haven't rev

is changing OctavateEight to ClefModifier appropriate for 2.18?

2013-04-21 Thread Janek Warchoł
http://code.google.com/p/lilypond/issues/detail?id=3309 https://codereview.appspot.com/8614045 This had passed countdown (with 0 reviews). I'm not sure if it's "stable enough" to be included in 2.18 - should i push it or set it's status to waiting? thanks, Janek _

Re: Add the command \offset to LilyPond (issue 8647044)

2013-04-21 Thread Janek Warchoł
Sorry for the delay, got little lilypond-time recently... 2013/4/16 : > On 2013/04/16 14:33:50, janek wrote: >> >> 2013/4/16 : >> > nothing-or-music in the last position only works if "nothing" is >> > _explicitly_ specified with \default >> > >> > There is no way that the last argument of a mus

Re: Doc: elaborate explanation of accidentals within cadenzas (3078) (issue 8866043)

2013-04-21 Thread tdanielsmusic
Reviewers: Ian Hulin (gmail), Message: On 2013/04/21 00:08:55, Ian Hulin (gmail) wrote: LGTM apart from a Nitpick: "can" implies there just may be an option of the accidentals appearing in this case. So use "must" "have to" or "need to be". Cheers, Ian https://codereview.appspot.com/8866043