Reviewers: Ian Hulin (gmail),
Message:
On 2013/04/21 00:08:55, Ian Hulin (gmail) wrote:
LGTM apart from a Nitpick:
"can" implies there just may be an option of the accidentals appearing
in this
case. So use "must" "have to" or "need to be".
Cheers, Ian
https://codereview.appspot.com/8866043/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/8866043/diff/1/Documentation/notation/rhythms.itely#newcode1514
Documentation/notation/rhythms.itely:1514: reminder accidentals can be
inserted
manually, see @ref{Accidentals}.
"must be inserted manually"
Done
Description:
Doc: elaborate explanation of accidentals within cadenzas (3078)
Text based on suggestion by Federico Bruni
Please review this at https://codereview.appspot.com/8866043/
Affected files:
M Documentation/notation/rhythms.itely
Index: Documentation/notation/rhythms.itely
diff --git a/Documentation/notation/rhythms.itely
b/Documentation/notation/rhythms.itely
index
cc69b76764a820681c9c64d48621526d197d949b..7801e29e62d38ef6fca6d13d35629be8133a4760
100644
--- a/Documentation/notation/rhythms.itely
+++ b/Documentation/notation/rhythms.itely
@@ -1506,15 +1506,19 @@ c4 c d8[ d d] f4 g4.
d4 e d c
@end lilypond
-A new bar is never started within a cadenza, even if one or more
-@code{\bar} commands are inserted within it. Therefore, reminder
-accidentals will need to be added manually. See @ref{Accidentals}.
+Inserting a @code{\bar} command within a cadenza does not start a new
+measure, even if a bar line is printed. So any accidentals -- which
+are usually assumed to remain in force until the end of the measure --
+will still be valid after the bar line printed by @code{\bar}. If
+subsequent accidentals should be printed, forced accidentals or
+reminder accidentals can be inserted manually, see @ref{Accidentals}.
@lilypond[verbatim,relative=2,quote]
c4 d e d
\cadenzaOn
cis4 d cis d
\bar "|"
+% First cis is printed without alteration even if it's after a \bar
cis4 d cis! d
\cadenzaOff
\bar "|"
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
