Re: Doc: NR Moved Appendix C to CG (issue 6948070)

2012-12-28 Thread graham
LGTM https://codereview.appspot.com/6948070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: CG Clarifying about Examples with overrides (issue 7013043)

2012-12-28 Thread graham
LGTM https://codereview.appspot.com/7013043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix for segfault in Font_metric::mark_smob (optimization; Debian bug #684817)

2012-12-28 Thread David Kastrup
Don Armstrong writes: > The attached patch fixes a segfault in mark_smob where s gets > optimized away and garbage collected before m goes out of scope, > leading to a segfault. > > There may be other cases of this bug floating around, but I didn't > look particularly hard for them. > diff --git

Fix for segfault in Font_metric::mark_smob (optimization; Debian bug #684817)

2012-12-28 Thread Don Armstrong
The attached patch fixes a segfault in mark_smob where s gets optimized away and garbage collected before m goes out of scope, leading to a segfault. There may be other cases of this bug floating around, but I didn't look particularly hard for them. Don Armstrong -- I shall require that [a sc

Re: Simplify several library functions. (issue 7020044)

2012-12-28 Thread dak
Reviewers: lemzwerg, thomasmorley65, Message: On 2012/12/28 15:09:24, thomasmorley65 wrote: LGTM Two questions: a) Where is `identity´ defined? I can't find it, neither in LilyPond nor in the guile-manual. Huh. The Guile2 manual shows its definition. It's a common function and is equiva

Re: Simplify several library functions. (issue 7020044)

2012-12-28 Thread thomasmorley65
LGTM Two questions: a) Where is `identity´ defined? I can't find it, neither in LilyPond nor in the guile-manual. b) Why are the definitions in lily-library.scm not all (or nearly all) defined public? Some examples: split-list other-axis index-cell sign I see no reason _not_ to make them