Re: Allow digits in identifiers (issue 6493072)

2012-10-28 Thread lemzwerg
LGTM. Nice idea. I'm not sure whether this fits into the large picture w.r.t. syntax normalization as envisioned by David, but at least for me it looks reasonable. http://codereview.appspot.com/6493072/ ___ lilypond-devel mailing list lilypond-devel@

Re: How to procede with \override/\revert business

2012-10-28 Thread Werner LEMBERG
>> there is still the big convert-to-single-path-override patch >> pending, how available in dev/syntax and discussed in >> http://code.google.com/p/lilypond/issues/detail?id=2934>. Everything looks fine! Thanks for your efforts. Am I right that \override foo.bar is the same as \override

PATCH: Countdown to 20121030

2012-10-28 Thread Colin Campbell
For 20:00 MDT Tuesday October 30 Enhancement: Issue 2445 : Center a number above a measure - R 6730044 Issue 2928 : Patch: parser

Change \alterBroken interface to match that of other tweak/overrides (issue 6784063)

2012-10-28 Thread david . nalesnik
LGTM! Thanks very much for doing this, David. https://codereview.appspot.com/6784063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: How to procede with \override/\revert business

2012-10-28 Thread Francisco Vila
2012/10/28 David Kastrup : > The translations for 2.16.1 are pretty much through, and I merged into > master again. I updated Documentation/es/changes.tely for stable and committed to translation branch. Then updated the same file for 2.17 (I wrongly said it was for 2.16 in the commit info) and co

Re: How to procede with \override/\revert business

2012-10-28 Thread David Kastrup
David Kastrup writes: > Hi folks, > > there is still the big convert-to-single-path-override patch pending, > how available in dev/syntax and discussed in > http://code.google.com/p/lilypond/issues/detail?id=2934>. > > It is non-Patchy-checkable since Rietveld does not accept diffs of that > size

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread dak
On 2012/10/28 17:38:10, Keith wrote: http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll#newcode95 lily/lexer.ll:95: The inside of \"violin1" is marked by nesting two quote modes as we A start-condi

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012-10-28 Thread k-ohara5a5a
http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode85 lily/breathing-sign.cc:85: ydim.widen (-0.25 * ydim.delta ()); Use ydim.length() so the reader does not wond

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread k-ohara5a5a
http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll#newcode95 lily/lexer.ll:95: The inside of \"violin1" is marked by nesting two quote modes as we A start-condition named "command_quote" would be less

Re: How to procede with \override/\revert business

2012-10-28 Thread Trevor Daniels
David Kastrup wrote Sunday, October 28, 2012 4:34 PM > http://code.google.com/p/lilypond/issues/detail?id=2934>. > > If we are going through with this one, it means that the > override/revert/overrideProperty syntax presented to users is > fundamentally different from before. I think this is a p

Re: AU add -d option for convert-ly (issue 6758044)

2012-10-28 Thread Trevor Daniels
janek.lilyp...@gmail.com wrote Sunday, October 28, 2012 4:28 PM > uh, this is probably a stupid question, but i'm working on lily since 2 > years and i have no idea: what AU is? Application Usage, shown as just Usage on the web. It's it the syllabus for year 3 ;) Trevor __

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-28 Thread janek . lilypond
LGTM http://codereview.appspot.com/6742061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: How to procede with \override/\revert business

2012-10-28 Thread David Kastrup
David Kastrup writes: > So I'd aim for getting 2.16.1 closed on Wednesday or so. At that time, > the next countdown will just have ended. I'd want to flush this syntax > change in at that time. Just to clear up any confusion: 2.16.1 is _not_ going to receive any of the discussed changes. It i

Issue 2592: index entries for slides and chord glissandi (issue 6766050)

2012-10-28 Thread janek . lilypond
LGTM http://codereview.appspot.com/6766050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

How to procede with \override/\revert business

2012-10-28 Thread David Kastrup
Hi folks, there is still the big convert-to-single-path-override patch pending, how available in dev/syntax and discussed in http://code.google.com/p/lilypond/issues/detail?id=2934>. It is non-Patchy-checkable since Rietveld does not accept diffs of that size. It runs make test fine, and I am c

Re: Doc: Pitches.itely @knownissue OctavateEight grob (issue 6761045)

2012-10-28 Thread janek . lilypond
one nitpick, otherwise LGTM http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/6761045/diff/6001/Documentation/notation/pitches.itely#newcode1183 Documentation/notation/pitches.ite

Doc: AU add -d option for convert-ly (issue 6758044)

2012-10-28 Thread janek . lilypond
uh, this is probably a stupid question, but i'm working on lily since 2 years and i have no idea: what AU is? Janek http://codereview.appspot.com/6758044/diff/1/Documentation/usage/updating.itely File Documentation/usage/updating.itely (right): http://codereview.appspot.com/6758044/diff/1/Docu

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread Marc Hohl
Am 28.10.2012 09:25, schrieb d...@gnu.org: Reviewers: lemzwerg, marc, Message: On 2012/10/28 07:46:36, marc wrote: On 2012/10/26 13:58:41, lemzwerg wrote: > LGTM. +1 Nice to have this feature available! It is more a pacifier than a feature since it does not actually add any functionalit

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread Trevor Daniels
> On 2012/10/28 08:47:50, t.daniels_treda.co.uk wrote: >> David wrote: > >> >> Nice to have this feature available! >> > >> > It is more a pacifier than a feature since it does not actually add >> > any functionality. And I don't want to see anything in our code > tree >> > (except possibly the

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread dak
On 2012/10/28 08:47:50, t.daniels_treda.co.uk wrote: David wrote: >> Nice to have this feature available! > > It is more a pacifier than a feature since it does not actually add > any functionality. And I don't want to see anything in our code tree > (except possibly the documentation for i

Re: Allow quoted identifiers like to be used like \"violin1", notjust defined. (issue 6778055)

2012-10-28 Thread Trevor Daniels
David wrote: >> Nice to have this feature available! > > It is more a pacifier than a feature since it does not actually add > any functionality. And I don't want to see anything in our code tree > (except possibly the documentation for it itself) making use of it, > just like I don't want to s

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread dak
Reviewers: lemzwerg, marc, Message: On 2012/10/28 07:46:36, marc wrote: On 2012/10/26 13:58:41, lemzwerg wrote: > LGTM. +1 Nice to have this feature available! It is more a pacifier than a feature since it does not actually add any functionality. And I don't want to see anything in our

Re: Busy Developer's Summary 3: steady progress?

2012-10-28 Thread David Kastrup
Janek Warchoł writes: > Julien Rioux wrote a patch for git-cl improving tracker issue > handling. Appropriate status and owner is now set, and new patch sets > are announced on tracker with appropriate commit message (not the > first commit's message, as it used to be). Everyone is encouraged t

Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)

2012-10-28 Thread marc
On 2012/10/26 13:58:41, lemzwerg wrote: LGTM. +1 Nice to have this feature available! http://codereview.appspot.com/6778055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012-10-28 Thread Benkő Pál
2012/10/27 : > On 2012/10/27 20:34:35, benko.pal wrote: > >> I want staves with line-positions like (-2 0 2 4) work. > Why would somebody specify (-2 0 2 4) with the expectation that the > results should be identical to (-3 -1 1 3)? Why would he not specify > (-3 -1 1 3) in the first place then?

Busy Developer's Summary 3: steady progress?

2012-10-28 Thread Janek Warchoł
There were some problems with translations, but i think they are solved now and a stable 2.16.1 release should happen soon. (Thread: "2.16.1" http://lists.gnu.org/archive/html/lilypond-devel/2012-10/msg00627.html) A quite large discussion about LilyPond usability happened on the user list, with so