Re: Waltrop meeting outline

2012-08-21 Thread Rodolfo Zitellini
On Tue, Aug 21, 2012 at 5:48 PM, David Kastrup wrote: >> I would like to be present all day the 24th, but I am not sure I can >> make it the 23th. One topic I think would also be nice to touch is >> promoting LilyPond and how we can valorize all the music that is in >> Mutopia (I saw, for example

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread Keith OHara
On Tue, 21 Aug 2012 20:43:03 -0700, wrote: Have you tried setting TupletNumber's priority to be smaller than TupletBracket? It results TupletNumber moving twice as far as it should That is a problem with the simple code. What is the desired output, though, if someone specifically asks for Tu

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread k-ohara5a5a
Works nice. But so far the density of problems in the code as been pretty high. These problems seem to be in corner cases for which the code is (unnecessarily?) complex. It is not clear why the _use_ of skylines has to change so much at the same time as the _shapes_ of skylines change. Maybe Joe

PATCH: Countdown to 20120823

2012-08-21 Thread Colin Campbell
For 22:00 MDT Thursday August 23 Documentation: Issue 2706 : add link to enc2ly - R 6448169 Issue 2694 : Bar engraver bug or wrong

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread joeneeman
On 2012/08/21 07:42:38, Keith wrote: On 2012/08/18 10:12:00, MikeSol wrote: > \relative c'' { >\override TupletBracket #'outside-staff-priority = #1 >\override TupletNumber #'font-size = #5 >\times 2/3 { a4\trill a\trill^"foo" a\trill } > } > > I added this as a regtest. If you co

Re: Patchy switches for forcing make doc don't seem to work

2012-08-21 Thread James
Hello, On 21 August 2012 21:46, John Mandereau wrote: > Le mardi 21 août 2012 à 13:05 -0400, Julien Rioux a écrit : >> On line #431, change quick_make=True to quick_make=False and you will be >> doing a `make doc' (in addition to `make check' and everything). >> >> A command-line switch would be

Re: Patchy switches for forcing make doc don't seem to work

2012-08-21 Thread John Mandereau
Le mardi 21 août 2012 à 13:05 -0400, Julien Rioux a écrit : > On line #431, change quick_make=True to quick_make=False and you will be > doing a `make doc' (in addition to `make check' and everything). > > A command-line switch would be much better, but for the time being this > is something you

Re: make test

2012-08-21 Thread John Mandereau
Sorry for the delay Phil, I had missed this message. Le mercredi 08 août 2012 à 09:59 +0100, Phil Holmes a écrit : > I've been looking at how the regression test comparison works. The first > thing I find is that we have 2 effectively duplicate, but different, pages > on running regtest comparis

Re: make test

2012-08-21 Thread Julien Rioux
On 08/08/2012 4:59 AM, Phil Holmes wrote: I've been looking at how the regression test comparison works. The first thing I find is that we have 2 effectively duplicate, but different, pages on running regtest comparisons: http://lilypond.org/doc/v2.15/Documentation/contributor/verify-regression

Re: Patchy switches for forcing make doc don't seem to work

2012-08-21 Thread Julien Rioux
On 20/08/2012 8:53 AM, James wrote: John, On 20 August 2012 13:09, John Mandereau wrote: Hi James, Il giorno lun, 20/08/2012 alle 10.40 +0100, James ha scritto: I am not able to work out how to force patchy during a test-patches.py to also make doc as well as the test and test-baseline. I do

Re: Waltrop meeting outline

2012-08-21 Thread David Kastrup
Rodolfo Zitellini writes: > I can confirm I will arrive from Fribourg Friday 24th at 15:21 in > Dortmund, I still have figure out the time it will take with the U41. See the previous posting with the travel details. You'll need a type B local transport ticket. > I will leave sometime in the mo

Waltrop travel details

2012-08-21 Thread David Kastrup
The last travel details in a nutshell: Landline is +49-2309-782756, my mobile phone +49-16092087547. Address is Im Knäppen 63, Waltrop. OpenStreetMap does not even show it while Google Maps is quite accurate. If that is a concern to you, bring your own GPS device and fix it. If you are using

Re: Regtest changes phase 1 (issue 6454121)

2012-08-21 Thread tdanielsmusic
All LGTM now. Thanks Phil! Trevor http://codereview.appspot.com/6454121/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: added link to enc2ly (issue 2706) (issue 6448169)

2012-08-21 Thread Frédéric Bron
> LGTM > http://codereview.appspot.com/6448169/ Here is the patch. Frédéric 0001-Doc-added-link-to-conversion-tools-from-Encore-to-li.patch Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/li

Re: Regtest changes phase 1 (issue 6454121)

2012-08-21 Thread PhilEHolmes
http://codereview.appspot.com/6454121/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: All engravers should have double-quotes around them (issue 6461098)

2012-08-21 Thread dak
On 2012/08/21 12:08:16, dak wrote: On 2012/08/21 11:57:45, Graham Percival wrote: > LGTM, but two questions: > 1) why should engravers have double-quotes? Because the CG states so. > Was it only working by accident > before, or are you hoping to simplify the parser by no longer accepting t

Re: CG: All engravers should have double-quotes around them (issue 6461098)

2012-08-21 Thread Graham Percival
On Tue, Aug 21, 2012 at 12:08:16PM +, d...@gnu.org wrote: > Reviewers: Graham Percival, > > Message: > On 2012/08/21 11:57:45, Graham Percival wrote: > >2) the patch title says "CG:", but this doesn't touch the CG. > > But the CG touches the patch. Concretely, it states: > > All engravers s

Re: CG: All engravers should have double-quotes around them (issue 6461098)

2012-08-21 Thread dak
Reviewers: Graham Percival, Message: On 2012/08/21 11:57:45, Graham Percival wrote: LGTM, but two questions: 1) why should engravers have double-quotes? Because the CG states so. Was it only working by accident before, or are you hoping to simplify the parser by no longer accepting the non

CG: All engravers should have double-quotes around them (issue 6461098)

2012-08-21 Thread graham
LGTM, but two questions: 1) why should engravers have double-quotes? Was it only working by accident before, or are you hoping to simplify the parser by no longer accepting the non-quoted versions? 2) the patch title says "CG:", but this doesn't touch the CG. http://codereview.appspot.com/6461

Re: Doc: Bar_engraver is required for system-start clefs (2694) (issue 6446160)

2012-08-21 Thread graham
LGTM http://codereview.appspot.com/6446160/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: added link to enc2ly (issue 2706) (issue 6448169)

2012-08-21 Thread graham
LGTM http://codereview.appspot.com/6448169/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-08-21 Thread graham
LGTM http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread m...@mikesolomon.org
On 21 août 2012, at 03:42, k-ohara5...@oco.net wrote: > On 2012/08/18 10:12:00, MikeSol wrote: > >> \relative c'' { >>\override TupletBracket #'outside-staff-priority = #1 >>\override TupletNumber #'font-size = #5 >>\times 2/3 { a4\trill a\trill^"foo" a\trill } >> } > >> I added thi

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread k-ohara5a5a
On 2012/08/18 10:12:00, MikeSol wrote: \relative c'' { \override TupletBracket #'outside-staff-priority = #1 \override TupletNumber #'font-size = #5 \times 2/3 { a4\trill a\trill^"foo" a\trill } } I added this as a regtest. If you comment out the rider business, you'll see that f

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread k-ohara5a5a
On 2012/08/21 07:32:15, Keith wrote: There was, however, no measurable difference in speed on my > piano-music test case. at least, no speed difference from my attempt at simplification I haven't tried Joe's. http://codereview.appspot.com/5626052/diff

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread k-ohara5a5a
On 2012/08/18 10:12:00, MikeSol wrote: Agreed. I'd love for this to go faster. The goal is not speed, but comprehensibility of code. The code is much shorter with direct use of distance() so there is less for the human reader to hold in his head. There was, however, no measurable difference

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-08-21 Thread joeneeman
On 2012/08/17 19:25:29, Keith wrote: On Fri, 17 Aug 2012 10:16:25 -0700, wrote: > > http://codereview.appspot.com/5626052/diff/106004/lily/axis-group-interface.cc#newcode780 > lily/axis-group-interface.cc:780: while (dirty); > On 2012/08/17 08:12:56, Keith wrote: >