Re: Let rhythmic-engraver make its articulation-or-event decision based on current listeners (issue 6098050)

Reviewers: Graham Percival, J_lowe, http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely#newcode170 Documentation/changes.tely:170: Another consequence is th

Re: Let rhythmic-engraver make its articulation-or-event decision based on current listeners (issue 6098050)

http://codereview.appspot.com/6098050/diff/2001/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6098050/diff/2001/Documentation/notation/fretted-strings.itely#newcode521 Documentation/notation/fretted-strings.i

Re: hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

works good for me. I can see the sense in either splitting into two commits as you mentioned in email (the \hideNotes commit first) or combining into one (which makes more sense to me since they are so closely related). http://codereview.appspot.com/6105049/diff/1/Documentation/ly-examples/tab-

Re: PATCH: Countdown to 20120424

Carl Sorensen writes: > On Apr 22, 2012, at 9:01 PM, "Colin Campbell" wrote: > > For 20:00 MDT Tuesday April 24 > > Documentation: >     Issue 2488: Doc: LM - Change 'Monophonic' to 'Homophonic' - R > 6107045 >     Issue 2490: Patch: Document "fingerings" being frets rat

Re: PATCH: Countdown to 20120424

On Apr 22, 2012, at 9:01 PM, "Colin Campbell" mailto:c...@shaw.ca>> wrote: For 20:00 MDT Tuesday April 24 Documentation: Issue 2488: Doc: LM - Change 'Monophonic' to 'Homophonic' - R 6107045

Change \bendAfter and \rightHandFinger into event functions (issue 6102045)

LGTM http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6102045/diff/1/Documentation/notation/fretted-strings.itely#newcode1589 Documentation/notation/fretted-strings.

Let rhythmic-engraver make its articulation-or-event decision based on current listeners (issue 6098050)

LGTM http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely File Documentation/changes.tely (right): http://codereview.appspot.com/6098050/diff/2001/Documentation/changes.tely#newcode170 Documentation/changes.tely:170: Another consequence is that string numbers and right han

Re: Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

LGTM, please push directly. Small suggestion below but I'm not particularly enamoured with it. You can push it whether or not you like it. http://codereview.appspot.com/6107045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu

Re: Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

LGTM, please push directly. Small suggestion below but I'm not particularly enamoured with it. You can push it whether or not you like it. http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codere

PATCH: Countdown to 20120424

For 20:00 MDT Tuesday April 24 Critical: Issue 2468 : augmentation dot of a moved rest is placed on a line - R6035053 Defect: Issue 2449

Re: Document "fingerings" being frets rather than fingers for fretted instruments. (issue 6099046)

Reviewers: Trevor Daniels, carl.d.sorensen_gmail.com, http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely#ne

Re: Document "fingerings" being frets rather than fingers for fretted instruments. (issue 6099046)

I believe that this is wrong -- fingerings are fingers for fretted instruments, not frets. http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documenta

Document "fingerings" being frets rather than fingers for fretted instruments. (issue 6099046)

One nitpick; otherwise LGTM http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/6099046/diff/1/Documentation/notation/fretted-strings.itely#newcode68 Documentation/nota

Re: Rename translation branch

Le 22/04/2012 19:59, David Kastrup disait : Francisco Vila writes: Hello, David and all, I'd like the lilypond/translation branch to be renamed to just 'translation' if there are no objections. David, I recall you did something similar for 'staging'. A good moment would be just after one or

Re: Rename translation branch

Francisco Vila writes: > Hello, David and all, > > I'd like the lilypond/translation branch to be renamed to just > 'translation' if there are no objections. David, I recall you did > something similar for 'staging'. > > A good moment would be just after one or two 2.16 releases, I think. > Comme

Rename translation branch

Hello, David and all, I'd like the lilypond/translation branch to be renamed to just 'translation' if there are no objections. David, I recall you did something similar for 'staging'. A good moment would be just after one or two 2.16 releases, I think. Comments? -- Francisco Vila. Badajoz (Spai

Re: Footnote documentation error

So... as far as the Bug Squad is concerned, are we still waiting for something or does this need to get added to the tracker? Thanks, Mark On Fri, Apr 20, 2012 at 1:52 AM, m...@apollinemike.com < m...@apollinemike.com> wrote: > On Apr 20, 2012, at 7:40 AM, James wrote: > > > Hello, > > > > On 20

Doc: LM - Use Homophonic instead of Monophonic (issue 6107045)

http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/6107045/diff/1/Documentation/learning/fundamental.itely#newcode1045 Documentation/learning/fundamental.itely:1045: % The foll

Re: What's with the test-patches volunteers?

Hello, On 22 April 2012 16:00, Colin Campbell wrote: > On 12-04-22 03:57 AM, Phil Holmes wrote: >> >> - Original Message - From: "David Kastrup" >> To: >> Sent: Sunday, April 22, 2012 7:31 AM >> Subject: What's with the test-patches volunteers? >> >> >> >> It is close to two months that

Re: What's with the test-patches volunteers?

On 12-04-22 03:57 AM, Phil Holmes wrote: - Original Message - From: "David Kastrup" To: Sent: Sunday, April 22, 2012 7:31 AM Subject: What's with the test-patches volunteers? It is close to two months that I have been the only person running test-patches, even though several voluntee

Re: Part_combine_iterator::derived_mark: don't abort marking prematurely. (issue 6057044)

On Wed, Apr 18, 2012 at 4:56 AM, wrote: > Short of any protests, I think I'll be going with > > void > Part_combine_iterator::derived_mark () const > { >  if (first_iter_) >    scm_gc_mark (first_iter_->self_scm ()); >  if (second_iter_) >    scm_gc_mark (second_iter_->self_scm ()); >  if (unison

Re: Strange loop executed only once!

On Sun, Apr 22, 2012 at 7:20 AM, Łukasz Czerwiński wrote: > Hi, > > I have spotted a strange loop in lily/ledger-line-spanner.cc (lines 46-69): > > Direction d = UP; >   do >     { >       . >     } >   while (flip (&d) != DOWN); > > It will be executed only once - with d set to UP. To

Re: for_UP_and_DOWN

sorry for the delay; I was on holidays On Fri, Apr 20, 2012 at 10:45 AM, Łukasz Czerwiński wrote: > Could you please say, if there was a reason for using > do { > > } while(flip(&d)); > > instead of my macro: if (UP_and_DOWN) Macros make code harder to read for people not into the project, so it

Re: State of the pond

Hello, On 22 April 2012 11:59, David Kastrup wrote: > Werner LEMBERG writes: > >>> Git history will judge us all. >> >> Interesting.  Up to now I've assumed God does this. > > If HE weren't a fan of distributed version control systems, why create > the world in the first place? > God Loves Git

Re: State of the pond

>> Interesting. Up to now I've assumed God does this. > > If HE weren't a fan of distributed version control systems, why > create the world in the first place? Good point :-) This reminds me of a joke: Two planets meet. `How are you?' `Well, not very well.' `How comes?' `I suffer f

Re: State of the pond

Werner LEMBERG writes: >> Git history will judge us all. > > Interesting. Up to now I've assumed God does this. If HE weren't a fan of distributed version control systems, why create the world in the first place? -- David Kastrup ___ lilypond-deve

Re: State of the pond

> Git history will judge us all. Interesting. Up to now I've assumed God does this. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Strange loop executed only once!

Hi, I have spotted a strange loop in lily/ledger-line-spanner.cc (lines 46-69): Direction d = UP; do { . } while (flip (&d) != DOWN); *It will be executed only once - with d set to UP.* To be executed for d = UP and then d = DOWN, it should be: while (flip (&d) != *

Re: Footnote documentation error

Hi bug-squad, On 22/04/12 06:39, James wrote: > Hello, > > On 22 April 2012 04:12, Mark Mathias wrote: >> So... as far as the Bug Squad is concerned, are we still waiting >> for something or does this need to get added to the tracker? >> Thanks, Mark >> > > As far as the bug squad are concern

Re: What's with the test-patches volunteers?

- Original Message - From: "David Kastrup" To: Sent: Sunday, April 22, 2012 7:31 AM Subject: What's with the test-patches volunteers? It is close to two months that I have been the only person running test-patches, even though several volunteers claimed they would do so. It has been

Re: State of the pond

Francisco Vila writes: > On the other hand, I can not omit doing things forever just for > safety. Therefore, I have to assume a certain degree of risk. I > already apologized when it went bad. After that, everything has gone > smoothly. Git history will judge us all. The thing to remember is

Re: State of the pond

2012/4/22 James : > Hello, > > On 22 April 2012 00:02, Francisco Vila wrote: >> 2012/4/20 Graham Percival : >>> We do not have a long history of flawless git actions from >>> translations, so my preference would be not to touch anything. >> >> Good idea! The definitive recipe for eternal flawless

hideNotes should hide also TabNoteHead (issue 2480). (issue 6105049)

LGTM http://codereview.appspot.com/6105049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel