Fix compile on OSX by including std-vector.hh instead of (issue 5437052)

2011-11-23 Thread graham
this is the kind of patch that can in theory be pushed directly to staging, although in this case I'm glad there was a review first. http://codereview.appspot.com/5437052/diff/1/lily/include/lily-guile.hh File lily/include/lily-guile.hh (right): http://codereview.appspot.com/5437052/diff/1/lily

do not tinker with the position of a pitched rest (issue 5434061)

2011-11-23 Thread benko . pal
Reviewers: , Message: hi all, if I extend the staff by a line, pitched rests appear shifted by half a line (thus half rests look like whole rests and vice versa). this patch is a quick fix for that. I feel the line-positions and line-count properties of Staff are badly tangled; I intend to work

Re: stupid question about patching push / countdowns

2011-11-23 Thread David Kastrup
Graham Percival writes: > As a result, I have nothing keeping me in Glasgow, and after £160 in > extra charges at british airways, I'm flying back to Vancouver in > about 14 hours. > > You can expect a drastic turn-around in our development process by > next week. Don't worry about updating the

Re: stupid question about patching push / countdowns

2011-11-23 Thread Graham Percival
On Wed, Nov 23, 2011 at 01:47:12PM +, Adam Spiers wrote: > Am I right in > guessing that the Patch-push label indicates that the review process > is complete and that the patch should be pushed by the developer / > patch helper / frog-meister as appropriate? In which case I should > push to th

Re: stupid question about patching push / countdowns

2011-11-23 Thread Colin Campbell
On 11-11-23 06:47 AM, Adam Spiers wrote: Hi all, Sorry - it only recently dawned on me that I'm probably responsible for pushing my patches which I think have now already been reviewed and approved. I've read the CG and tried to understand the exact process, but as previously noted on this list

stupid question about patching push / countdowns

2011-11-23 Thread Adam Spiers
Hi all, Sorry - it only recently dawned on me that I'm probably responsible for pushing my patches which I think have now already been reviewed and approved. I've read the CG and tried to understand the exact process, but as previously noted on this list, the CG is not entirely complete and up-to

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-23 Thread m...@apollinemike.com
On Nov 23, 2011, at 9:21 AM, Keith OHara wrote: > On Mon, 21 Nov 2011 00:16:12 -0800, Keith OHara wrote: > >> On Sun, 20 Nov 2011 23:57:22 -0800, wrote: >> >>> I think that you're right for most cases, but for a piece with lots of >>> accidentals that could potentially hang over barlines, this

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

2011-11-23 Thread Keith OHara
On Mon, 21 Nov 2011 00:16:12 -0800, Keith OHara wrote: On Sun, 20 Nov 2011 23:57:22 -0800, wrote: I think that you're right for most cases, but for a piece with lots of accidentals that could potentially hang over barlines, this complexity in estimation seems to help. Have an example where