Re: Fixes issue 40. (issue 4801083)

2011-08-21 Thread mtsolo
Pushed as b3c0b773bde05b3971f087ed6c5f4fb40a1b20b1. http://codereview.appspot.com/4801083/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Creates a Flag grob. (issue 4922042)

2011-08-21 Thread mtsolo
On 2011/08/22 01:56:23, hanwenn wrote: quick remarks - Why are the flags called "maybe"flags in the engraver? Because we don't know if they are for-real flags until auto beaming has finished doing its thing (and all of the flags with beams are killed). I can change it to flags_ or flags_to_m

Re: pulling and rebasing. Problem with resolving conflict

2011-08-21 Thread Janek Warchoł
2011/8/22 Reinhold Kainhofer : > Am Sunday, 21. August 2011, 23:43:21 schrieb Janek Warchoł: >> janek@janek-lilydev5:~/lilypond-git$ git status >> ##now this looks strange - shouldn't it say something like "modified: >> this, this and this"? > > Nope, after you manually resolved all conflicts of th

Re: Creates a Flag grob. (issue 4922042)

2011-08-21 Thread Han-Wen Nienhuys
quick remarks - Why are the flags called "maybe"flags in the engraver? - Currently, the stem already does width/2 X-offset, can't you piggyback on that? - You're copying me and jan's name in the header. If anythingn, you should probably put your own. (we could consider just using "The lilypond au

Re: Moving away from make

2011-08-21 Thread Han-Wen Nienhuys
On Sat, Aug 20, 2011 at 6:06 AM, Jan Nieuwenhuizen wrote: > Han-Wen Nienhuys writes: >> Given that Cmake has a large following (examples include KDE and >> LLVM), I'd be comfortable with switching to that. > > Interesting; have you ever used Cmake? Lately I've been doing tweaks to parallel compil

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread ColinPKCampbell
Regarding the addition of instructions on how to push, I'd like to do that in a separate patch, unless an experienced developer cares to send me a rough sketch, point form perhaps, which I could then repackage in documentation format. http://codereview.appspot.com/4898058/ __

Re: fixing website translations

2011-08-21 Thread Federico Bruni
Il giorno ven, 12/08/2011 alle 09.07 -0700, Graham Percival ha scritto: > On Fri, Aug 12, 2011 at 05:27:53PM +0200, Francisco Vila wrote: > > 2011/8/12 Federico Bruni : > > > Il giorno ven, 12/08/2011 alle 16.49 +0200, Francisco Vila ha scritto: > > >> > Processing web site: [it] > > >> > WARNING:

Re: pulling and rebasing. Problem with resolving conflict

2011-08-21 Thread Reinhold Kainhofer
Am Sunday, 21. August 2011, 23:43:21 schrieb Janek Warchoł: > janek@janek-lilydev5:~/lilypond-git$ git status > ##now this looks strange - shouldn't it say something like "modified: > this, this and this"? Nope, after you manually resolved all conflicts of the rebase, the conflicting patch does n

pulling and rebasing. Problem with resolving conflict

2011-08-21 Thread Janek Warchoł
Hi, I don't understand what happens (and why) when i try to update one of my local branches. Here's the background: i made a branch and applied a patch done by Keith to it. Later a modified version of Keith's patch was pushed to origin/master (i guess). Now I try to pull and rebase and a conflic

Re: problems with git push and pull

2011-08-21 Thread Janek Warchoł
2011/8/21 Reinhold Kainhofer : > Am Sunday, 21. August 2011, 21:26:38 schrieb Janek Warchoł: >> > Did the "git pull" give any messages? >> >> I don't remember what it said the first time, but now it says >> "From ssh://git.sv.gnu.org/srv/git/lilypond >>  * branch            master     -> FETCH_HEAD

Creates a Flag grob. (issue 4922042)

2011-08-21 Thread mtsolo
Reviewers: , Message: This should do the trick. The regtests don't really help as they show tons of fake changes. I'll try Han Wen's suggestion for hacking output-distance.py in the next week if I am still having trouble. The only thing that currently seems broken is stem-tremolo-note-column.l

Re: problems with git push and pull

2011-08-21 Thread Reinhold Kainhofer
Am Sunday, 21. August 2011, 21:26:38 schrieb Janek Warchoł: > > Did the "git pull" give any messages? > > I don't remember what it said the first time, but now it says > "From ssh://git.sv.gnu.org/srv/git/lilypond > * branchmaster -> FETCH_HEAD > Current branch master is up to dat

Re: problems with git push and pull

2011-08-21 Thread Keith OHara
Janek Warchoł gmail.com> writes: > > I would expect another line in your configuration, added below: > > > >> [remote "origin"] > >> url = ssh://janekw git.sv.gnu.org/srv/git/lilypond.git > > fetch = +refs/heads/master:refs/remotes/origin/master > > > > Probably you want to go through

several regression tests changed slightly

2011-08-21 Thread Keith OHara
I pushed the patches for issues 1779 and 1785, the ones that made small changes to *lots* of regression tests. Probably you want to absorb these changes in new `make test-baseline` ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: problems with git push and pull

2011-08-21 Thread Janek Warchoł
2011/8/21 Reinhold Kainhofer : > Am Sunday, 21. August 2011, 20:30:09 schrieb Janek Warchoł: >> As a nice inauguration of me having git push ability, i broke my >> repository :)  git pull seems not to work properly. >> >> Here's what i did: >> - in step 6 from here >> http://lilypond.org/doc/v2.15/

Re: problems with git push and pull

2011-08-21 Thread Reinhold Kainhofer
Am Sunday, 21. August 2011, 20:39:05 schrieb m...@apollinemike.com: > On Aug 21, 2011, at 8:30 PM, Janek Warchoł wrote: > > commit 9c319db89ecc46cbf6c9c35e759eba973e412bb0 > > Merge: 49ef4f0 fb47959 > > Author: Mike Solomon > > Date: Sun Aug 21 17:19:28 2011 +0200 > > > >Merge branch 'maste

Re: problems with git push and pull

2011-08-21 Thread m...@apollinemike.com
On Aug 21, 2011, at 8:30 PM, Janek Warchoł wrote: > commit 9c319db89ecc46cbf6c9c35e759eba973e412bb0 > Merge: 49ef4f0 fb47959 > Author: Mike Solomon > Date: Sun Aug 21 17:19:28 2011 +0200 > >Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/lilypond For the record, I don't remember do

Re: problems with git push and pull

2011-08-21 Thread Keith OHara
Janek Warchoł gmail.com> writes: > > As a nice inauguration of me having git push ability, i broke my > repository :) git pull seems not to work properly. > Your commit looks fine on the repository, so nothing to worry about there. I would expect another line in your configuration, added bel

Re: problems with git push and pull

2011-08-21 Thread Reinhold Kainhofer
Am Sunday, 21. August 2011, 20:30:09 schrieb Janek Warchoł: > As a nice inauguration of me having git push ability, i broke my > repository :) git pull seems not to work properly. > > Here's what i did: > - in step 6 from here > http://lilypond.org/doc/v2.15/Documentation/contributor/commit-acces

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread janek . lilypond
On 2011/08/18 11:42:06, Reinhold wrote: On 2011/08/18 11:21:22, PhilEHolmes wrote: > LGTM too. My suggestion would be to add some instructions about actually > pushing. It took me a while to convince myself that all that appears to be > needed is to have an unpushed commit and type "git pus

problems with git push and pull

2011-08-21 Thread Janek Warchoł
Hi all, As a nice inauguration of me having git push ability, i broke my repository :) git pull seems not to work properly. Here's what i did: - in step 6 from here http://lilypond.org/doc/v2.15/Documentation/contributor/commit-access i mistakenly called config remote.origin.url \ ssh://u...@

Re: Remove special case in staff-spacing (issue 4188051)

2011-08-21 Thread mtsolo
LGTM. Cheers, MS http://codereview.appspot.com/4188051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Prevents nested tuplets from colliding. (issue 4808082)

2011-08-21 Thread mtsolo
That didn't take too long - I scrapped the previous try and went at it from a different angle. This should do the trick! Cheers, MS http://codereview.appspot.com/4808082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Fix 1529: hashed snippet filename changes should not count as log differences (issue 4893044)

2011-08-21 Thread reinhold . kainhofer
Reviewers: , http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py File scripts/build/output-distance.py (right): http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py#newcode481 scripts/build/output-distance.py:481: print "Replacing old filename

Re: Better pure height approximations for beamed rests. (issue 4860043)

2011-08-21 Thread mtsolo
Pushed as 9c319db89ecc46cbf6c9c35e759eba973e412bb0. Cheers, MS http://codereview.appspot.com/4860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: \once \revert

2011-08-21 Thread David Kastrup
Carl Sorensen writes: > On 8/21/11 3:01 AM, "David Kastrup" wrote: > > \override -- pushes a value on the stack to remain until reverted > \once \override -- pushes a value on the stack to last only for this time > step. Should be marked as special since it is a \once > \revert -- pulls a non-o

Re: Prevents nested tuplets from colliding. (issue 4808082)

2011-08-21 Thread m...@apollinemike.com
On Aug 20, 2011, at 10:30 AM, m...@apollinemike.com wrote: > >> http://codereview.appspot.com/4808082/diff/13002/lily/tuplet-bracket.cc#newcode669 >> lily/tuplet-bracket.cc:669: // have to re_run numbers to check for >> number-on-number collisions >> This is getting a bit complicated. Do you thin

Sorry for the erroneous push...

2011-08-21 Thread Bertrand Bordage
Hi, I made a mistake when pushing 0fa2313ae40ae4419b635193bce21dd2c17c02f4 As you can see, I pushed some other patches by error. Sorry for that, they are reverted. I didn't tried to make a git push -f origin [previous HEAD]:master. This could have done worse... Bertrand __

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread Reinhold Kainhofer
Am Friday, 19. August 2011, 05:11:30 schrieben Sie: > On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote: > > Am Friday 19 August 2011, 02:29:22 schrieb percival.music...@gmail.com: > > > On 2011/08/18 11:42:13, Reinhold wrote: > > > > Why did you change all dsa to rsa? > > > > It'

Re: \once \revert

2011-08-21 Thread Carl Sorensen
On 8/21/11 3:01 AM, "David Kastrup" wrote: > Carl Sorensen writes: > >> On 8/21/11 1:45 AM, "David Kastrup" wrote: >> >>> My suggestion >>> would be >>> >>> \set x = 4 ; setting the default >>> \override x = 5 ; context set has 5 >>> \override x = 2 ; context set has 5 2,

Re: Check for null pointer

2011-08-21 Thread Reinhold Kainhofer
Am Sunday, 21. August 2011, 05:01:38 schrieb Dan Eble: > > On 2011-08-20, at 16:00 , Reinhold Kainhofer wrote: > >> Hmm, do you have any example file where this appears (even if it's not > >> minimal, for now it's just important that we can reproduce it somehow). > > I wonder if this has anything

Re: Make doc is broken

2011-08-21 Thread Phil Holmes
- Original Message - From: "Reinhold Kainhofer" To: Sent: Saturday, August 20, 2011 6:23 PM Subject: Re: Make doc is broken Hi Phil, Am Saturday, 20. August 2011, 16:26:48 schrieb Phil Holmes: I think Reinhold's commit cfcb9efdbd7c6600fc89fc912ba80529010b31e7 has broken make doc.

Re: not all doc "clean-ups" are good

2011-08-21 Thread Werner LEMBERG
>> Well, it helps in situations like this >> This is a paragraph with some text to >> demonstrate that a path name like >> /usr/local/share/lilypond/foo.bar >> should be split after backslashes. >> which looks better with a break after the backslash: > > This is sensible,

Re: not all doc "clean-ups" are good

2011-08-21 Thread Trevor Daniels
David Kastrup wrote Sunday, August 21, 2011 9:33 AM "Trevor Daniels" writes: changing "and/or" to "and/@/or" is bad (one you changed recently.) Splitting such short strings will make little difference to the layout, and I would argue that placing the "/or" at the start of a new line render

Re: \once \revert

2011-08-21 Thread David Kastrup
Reinhold Kainhofer writes: > On So., 21. Aug. 2011 02:33:06 CEST, Carl Sorensen wrote: >> My thought for the architecture is to have two sets of properties -- the >> context set and the \once set. > > That's exactly what I was about to propose, too. override basically > sets the default, vbut a

Re: GOP-PROP 8: issue priorities (probable 2)

2011-08-21 Thread Phil Holmes
- Original Message - From: "Graham Percival" * Type-ugly: replaces Type-collision, and it will include things like bad slurs in addition to actual collision. Think we need to change the description of this on the tracker to make it clear it's not just collisions. -- Phil

Re: Improves horizontal spacing of axis groups that SpanBar grobs traverse. (issue 4917046)

2011-08-21 Thread mtsolo
Hey all, I just realized that in this patch, the Span_bar_stub_engraver could be bumped down a level to the Lyric context to avoid the Grob_info rerouting. Lemme know if this seems like a good idea. Another solution as well would be to create multiple SpanBars for the same timestep in the same

Re: \once \revert

2011-08-21 Thread David Kastrup
Carl Sorensen writes: > On 8/21/11 1:45 AM, "David Kastrup" wrote: > >> My suggestion >> would be >> >> \set x = 4 ; setting the default >> \override x = 5 ; context set has 5 >> \override x = 2 ; context set has 5 2, result 5 >> \once\override x = 3 ; context set has 3(o) 5

Re: \once \revert

2011-08-21 Thread Reinhold Kainhofer
On So., 21. Aug. 2011 02:33:06 CEST, Carl Sorensen wrote: > My thought for the architecture is to have two sets of properties -- the > context set and the \once set. That's exactly what I was about to propose, too. override basically sets the default, vbut a once always always takes precedence.

Re: \once \revert

2011-08-21 Thread Carl Sorensen
On 8/21/11 1:45 AM, "David Kastrup" wrote: > Carl Sorensen writes: > >> On 8/19/11 2:57 PM, "David Kastrup" wrote: >> >>> Carl Sorensen writes: >>> On 8/19/11 10:15 AM, "David Kastrup" wrote: >> >> With this architecture, I don't think there are any surprises. > > \set x = 4

Re: not all doc "clean-ups" are good

2011-08-21 Thread David Kastrup
"Trevor Daniels" writes: > Werner LEMBERG wrote Sunday, August 21, 2011 6:13 AM > >> Well, it helps in situations like this >> >> This is a paragraph with some text to >> demonstrate that a path name like >> /usr/local/share/lilypond/foo.bar >> should be split after backsl

Re: not all doc "clean-ups" are good

2011-08-21 Thread Trevor Daniels
Werner LEMBERG wrote Sunday, August 21, 2011 6:13 AM Well, it helps in situations like this This is a paragraph with some text to demonstrate that a path name like /usr/local/share/lilypond/foo.bar should be split after backslashes. which looks better with a break afte

Re: Fix issue 11 -- beamlet points in wrong direction on tuplet (issue 4941041)

2011-08-21 Thread Carl . D . Sorensen
This patch breaks beam subdivision. Please wait to review until I fix the subdivision problem. Thanks, Carl http://codereview.appspot.com/4941041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypon

Re: \once \revert

2011-08-21 Thread David Kastrup
Carl Sorensen writes: > On 8/19/11 2:57 PM, "David Kastrup" wrote: > >> Carl Sorensen writes: >> >>> On 8/19/11 10:15 AM, "David Kastrup" wrote: >>> In order to not have the override/revert stack get into unexpected interactions, I want to change \once\override to be impervious to >