Re: Beam collision strikes back!

2011-07-25 Thread m...@apollinemike.com
On Jul 26, 2011, at 5:23 AM, Han-Wen Nienhuys wrote: > On Fri, Jul 22, 2011 at 5:33 PM, m...@apollinemike.com > wrote: >> Hey Han-Wen, >> I've been bumping into this problem recently : >> http://code.google.com/p/lilypond/issues/detail?id=1645 >> and I think the solution is in the quanting code.

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread m...@apollinemike.com
On Jul 26, 2011, at 5:01 AM, hanw...@gmail.com wrote: > regtest missing. > > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc > File lily/slur-scoring.cc (right): > > http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286 > lily/slur-scoring.cc:286

Re: Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread k-ohara5a5a
Reviewers: J_lowe, joeneeman, Message: lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be a grob property rather than a static variable. I'm scared of the property-lookup costs. I might be wiser to leave it where it was in Springs::merge() , and just apply full-

PATCHES: 48-hour countdown to July 27´11

2011-07-25 Thread Colin Campbell
New today, for 22:00 MDT Wednesday July 27 Issue 732 : Alignment problems when vertically stacking horizontally centered stencils. - Rietveld Issue 4798050 : Fix 732: center-column ignored left hal

Re: Beam collision strikes back!

2011-07-25 Thread Han-Wen Nienhuys
On Fri, Jul 22, 2011 at 5:33 PM, m...@apollinemike.com wrote: > Hey Han-Wen, > I've been bumping into this problem recently : > http://code.google.com/p/lilypond/issues/detail?id=1645 > and I think the solution is in the quanting code.  Before I spend an hour How would a collision strategy work?

Re: Postscript printer errors with rounded barlines?

2011-07-25 Thread Han-Wen Nienhuys
On Sat, Jul 23, 2011 at 7:45 PM, Jan Warchoł wrote: > I'm not experienced with PostScript, but i have an impression that > this may be related to an issue discussed earlier - see here > http://lists.gnu.org/archive/html/lilypond-user/2007-07/msg00485.html > and here > http://lists.gnu.org/archive

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread hanwenn
regtest missing. http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc File lily/slur-scoring.cc (right): http://codereview.appspot.com/4813048/diff/3001/lily/slur-scoring.cc#newcode286 lily/slur-scoring.cc:286: end_ys[d] += additional_ys + 0.5; // 0.5 = m4g1c padding over extra

Re: Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread joeneeman
http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh File lily/include/spacing-spanner.hh (right): http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh#newcode45 lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be

Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

2011-07-25 Thread k-ohara5a5a
I like it, although I can still get the error if I put a new voice in the quoted expression like this: quoteMe = \relative c' \new Voice { http://codereview.appspot.com/4816044/diff/3001/input/regression/quote-during-subvoice.ly File input/regression/quote-during-subvoice.ly (right): http://

Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)

2011-07-25 Thread percival . music . ca
LGTM http://codereview.appspot.com/4808051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)

2011-07-25 Thread ColinPKCampbell
Revised as requested. http://codereview.appspot.com/4808051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Makes parameters for hairpin rotation available in Scheme (issue4809051)

2011-07-25 Thread Graham Percival
On Mon, Jul 25, 2011 at 09:17:53AM +0200, m...@apollinemike.com wrote: > > We may want to just fix issue 36 via something in the docs- ... > but as there is no clear way to > deal with these collisions, perhaps a section in the > documentation "Dealing with collisions" that says something to > th

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread Carl . D . Sorensen
Wol, Please fix the indentation, and make a new patch so that you get credit for the commit. Thanks, Carl http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread Carl . D . Sorensen
Wol, Please fix the indentation, and make a new patch so that you get credit for the commit. Thanks, Carl http://codereview.appspot.com/4800051/diff/3001/scm/chord-name.scm File scm/chord-name.scm (right): http://codereview.appspot.com/4800051/diff/3001/scm/chord-name.scm#newcode180 scm/cho

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread lemniskata . bernoullego
Uploaded Carl's fix, everything works now! I'm making from scratch and will run regtests. http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: separate regtest branch broke fonts

2011-07-25 Thread m...@apollinemike.com
On Jul 25, 2011, at 11:33 PM, Carl Sorensen wrote: > Fontforge built easily for me on OSX from MacPorts. > > Have you looked carefully through the archives from -devel for fonts on OSX? > There was a problem a while ago (I can't remember when) that involved wrong > fonts showing up for me in Chor

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread David Kastrup
lemniskata.bernoull...@gmail.com writes: > New patch from Wol uploaded. According to Carl, it addresses previous > concerns; we only have a problem with Scheme syntax left. More than one. You have too few parens after let, then too many around capo-pitch and capo-vertical (I guess). -- David

Re: separate regtest branch broke fonts

2011-07-25 Thread Carl Sorensen
Fontforge built easily for me on OSX from MacPorts. Have you looked carefully through the archives from -devel for fonts on OSX? There was a problem a while ago (I can't remember when) that involved wrong fonts showing up for me in ChordNames, and I was able to fix it. There was something about s

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread lemniskata . bernoullego
New patch from Wol uploaded. According to Carl, it addresses previous concerns; we only have a problem with Scheme syntax left. (don't run regtests on this yet) http://codereview.appspot.com/4800051/ ___ lilypond-devel mailing list lilypond-devel@gnu.

Modify chord-name-engraver to call capo-handler (issue4800051)

2011-07-25 Thread lemniskata . bernoullego
Reviewers: carl.d.sorensen_gmail.com, Description: Modify chord-name-engraver to call capo-handler Add capo properties to define-context-properties Add capo-handler function for guitar chords Please review this at http://codereview.appspot.com/4800051/ Affected files: M lily/chord-name-en

Give DynamicText horizontal space; issues 621 631 (issue4805054)

2011-07-25 Thread pkx166h
Passes make and reg tests show some differences but probably expected See http://code.google.com/p/lilypond/issues/detail?id=631#c4 http://codereview.appspot.com/4805054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Remove special case in staff-spacing (issue4188051)

2011-07-25 Thread pkx166h
Passes make and there are lots (lots) of reg test differences but as keith says many 'small' ones, nothing immediately jumps out as bad. But I cannot figure out how to attach them here for others to see. A pdf > 20MB and making screen shots is not really appropriate (there would be about 60+ pngs

Re: make check still failing with midis

2011-07-25 Thread Graham Percival
On Sun, Jul 24, 2011 at 10:59:25PM +0200, m...@apollinemike.com wrote: > Oddly, I'm also getting on this error, which is game blocking (meaning that > launching make check again doesn't fix it): > > File "/Users/mikesolomon/devel/regtests/scripts/build/out/output-distance", > line 970, in comp

Re: CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

2011-07-25 Thread Graham Percival
On Mon, Jul 25, 2011 at 12:54:55PM +0200, Jan Nieuwenhuizen wrote: > Graham Percival writes: > > > I have no clue how the .emacs is supposed to look...? > > Lisp is quite like scheme; like this > > (add-hook 'c++-mode-hook > '(lambda () >(setq indent-tabs-mode nil) >

Re: make check still failing with midis

2011-07-25 Thread m...@apollinemike.com
On Jul 25, 2011, at 8:46 PM, Keith OHara wrote: > apollinemike.com> writes: > >> I get the following error during make check: >> [...] >> Failed files: (1c/lily-e69a97ad.ly >> [...] >> Child returned 1 >> make[2]: *** [out-test/collated-files.texi] Error 1 >> rm out-test/rest-dynamic.midi out-t

Re: make check still failing with midis

2011-07-25 Thread Keith OHara
apollinemike.com> writes: > I get the following error during make check: > [...] > Failed files: (1c/lily-e69a97ad.ly > [...] > Child returned 1 > make[2]: *** [out-test/collated-files.texi] Error 1 > rm out-test/rest-dynamic.midi out-test/quantize-duration-2.midi [...] > make[1]: *** [local-te

Re: Makes parameters for hairpin rotation available in Scheme (issue4809051)

2011-07-25 Thread Keith OHara
apollinemike.com> writes: > > On Jul 24, 2011, at 11:29 PM, Neil Puttock wrote: > > > On 23 July 2011 15:48, gmail.com> wrote: > > > >> In the > >> example given in Issue 36, I would personally rotate the stencil > >> downwards, and this patch would give me all the data necessary > >> to c

Re: Figured Bass extenders syntax

2011-07-25 Thread Jan Warchoł
+1 ...GLISS? cheers, Janek 2011/7/25 Bertrand Bordage : > Hi all, > I am currently working on some huge figured bass projects and there's > something truely annoying and quite unnatural: > when using \bassFigureExtendersOn, we need to tell LilyPond when we don't > want an extender (by adding \! to

Re: Figured Bass extenders syntax

2011-07-25 Thread Jean-Charles Malahieude
Le 25/07/2011 13:56, Bertrand Bordage disait : Hi all, I am currently working on some huge figured bass projects and there's something truely annoying and quite unnatural: when using \bassFigureExtendersOn, we need to tell LilyPond when we don't want an extender (by adding \! to the number) inst

Re: Sketch for fix of issue 307 (issue4813048)

2011-07-25 Thread mtsolo
On 2011/07/24 14:43:16, MikeSol wrote: Please don't run regtests yet on this patch - it is up to see if people are OK with this approach. It is a brute-force approach that will slow down lilypond for slurs that have extra-object-collisions, but I think it'll cover the grand majority of cas

Figured Bass extenders syntax

2011-07-25 Thread Bertrand Bordage
Hi all, I am currently working on some huge figured bass projects and there's something truely annoying and quite unnatural: when using \bassFigureExtendersOn, we need to tell LilyPond when we don't want an extender (by adding \! to the number) instead of telling when we want one. I'm making a lot

RE: Produces better error messages when programmers forget to document a property. (issue4801045)

2011-07-25 Thread James Lowe
Hello, )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of m...@apollinemike.com )Sent: 24 July 2011 09:41 )To: mts...@gmail.com; n.putt...@gmail.com; )lemniskata.bernoull...@gmail.

Re: Fix for Issue 620. (issue4814041)

2011-07-25 Thread m...@apollinemike.com
On Jul 24, 2011, at 11:22 PM, Neil Puttock wrote: > On 24 July 2011 09:55, m...@apollinemike.com wrote: > >> Why is it a bad thing to do it this way? Currently, the >> Beam_collision_engraver implements dynamic filtering based on interface, and >> I don't think there's a problem with that (it

Re: CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

2011-07-25 Thread Jan Nieuwenhuizen
Graham Percival writes: > I have no clue how the .emacs is supposed to look...? Lisp is quite like scheme; like this (add-hook 'c++-mode-hook '(lambda () (setq indent-tabs-mode nil) (c-set-style "gnu"))) In fact, I have (add-hook 'c++-mode-hook

separate regtest branch broke fonts

2011-07-25 Thread m...@apollinemike.com
Hey all, In my zeal to get a separate regtest branch up and running, I have now broken all of my branches when it comes to font lookup via the Text_interface PastedGraphic-3.pdf Description: Adobe PDF document I had to update pango to get the most recent fontforge to build on Mac OS X and I

Re: Makes parameters for hairpin rotation available in Scheme (issue4809051)

2011-07-25 Thread mike
On Jul 24, 2011, at 11:29 PM, Neil Puttock wrote: > On 23 July 2011 15:48, wrote: > >> (a) is currently impossible to calculate in all circumstances, and (c) >> would require a code dup. I think by making these available as >> properties, the user can then use this data to fix the problem. In

Re: \footnote 'bug' (or not?)

2011-07-25 Thread mike
On Jul 24, 2011, at 11:42 PM, Neil Puttock wrote: > On 24 July 2011 19:51, m...@apollinemike.com wrote: >> On Jul 24, 2011, at 6:43 PM, James Lowe wrote: >> >>> Hello, >>> >>> From Neil P. explaining the finer points of footnote code, while looking at >>> my in-progress Doc patch for footnotes