Re: separating flags from noteheads in font (issue4273119)

2011-06-13 Thread Colin Campbell
On 11-06-13 01:17 PM, Janek Warchoł wrote: Bad news: it doesn't work (the flags are squashed) - i have no idea why... Maybe i forgot to make clean when i tested it before, but i'm almost sure i didn't. Still, this looks like the only possible explanation. Mike tested it too and he got flags as sq

Re: Bugfix for issue 1630 (issue4490045)

2011-06-13 Thread percival . music . ca
http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163 lily/tie-engraver.cc:163: /* On 2011/06/13 22:44:37, karin.hoethker wrote: On 2011/06/01 21:21:25, Neil Putto

Re: Bugfix for issue 1630 (issue4490045)

2011-06-13 Thread karin . hoethker
I have send the patch set to Janek for upload. http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163 lily/tie-engraver.cc:163: /* On 2011/06/01 21:21:25, Neil Putt

Re: Braces redesigned (issue4581060)

2011-06-13 Thread tdanielsmusic
I like the new shapes and thicknesses, at least in isolation. I've not tried any tests using them in real scores. http://codereview.appspot.com/4581060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lily

Braces redesigned (issue4581060)

2011-06-13 Thread bordage . bertrand
Reviewers: , Message: A small patch that redefines the braces: * Increases the width of the smallest. * Reduces the width of the largest. * Increments more consistently between two braces (there were too many tiny braces). * Increases the thickness of the ends of braces. * Sharpens a little the

Re: separating flags from noteheads in font (issue4273119)

2011-06-13 Thread Janek Warchoł
2011/6/13 Janek Warchoł : > Bad news: it doesn't work (the flags are squashed) An idea came to my mind - maybe we can use our *.table files in feta-flags? Is it possible to tell our build system to compile feta-noteheads first and feta-flags (which would contain a reference to feta-noteheads.otf-g

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

2011-06-13 Thread bordage . bertrand
Yes, thanks. 'Tis done. Bertrand http://codereview.appspot.com/4536068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Further build bugs

2011-06-13 Thread Werner LEMBERG
>> ToUnicode entries are generated by texinfo.tex. Assuming that your >> texinfo.tex (in the lilypond/tex) isn't garbled, it seems that your >> pdftex can't digest them properly. > > You have to be looking, otherwise it's a bit like a needle in a > haystack. I think it may also be Ubuntu specifi

Re: Further build bugs

2011-06-13 Thread Phil Holmes
- Original Message - From: "Werner LEMBERG" To: Cc: Sent: Monday, June 13, 2011 3:54 PM Subject: Re: Further build bugs Error: Illegal entry in bfrange block in ToUnicode CMap and the Error message repeated about 500 times. The block of these error messages is repeated through t

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-13 Thread Trevor Daniels
Janek Warchoł wrote Monday, June 13, 2011 2:51 PM 2011/6/13 : a) It would be better to honour the value of 'gap if this is set by the user, rather than change a specifically requested gap value. My rationale is that it wouldn't make sense to set a big gap and really want to have it applie

Re: Further build bugs

2011-06-13 Thread Werner LEMBERG
> Error: Illegal entry in bfrange block in ToUnicode CMap > > and the Error message repeated about 500 times. The block of these > error messages is repeated through the output. This is using > lily-ubuntu (ubuntu 10.04). It appears from the web that it's a bug > in Ubuntu, but just wondering

Re: ugly boxes

2011-06-13 Thread Phil Holmes
- Original Message - From: "Trevor Daniels" To: "Phil Holmes" ; "Lily-Devel List" Sent: Sunday, June 12, 2011 11:28 PM Subject: Re: ugly boxes "Phil Holmes" wrote in message news:it2a6b$kgt$1...@dough.gmane.org... I'm continuing to look at the build system, and studying the outpu

Re: problem with beam collision (was: problem with cross-staffstems, ?on lilypond-user)

2011-06-13 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" > > The snippet says "If the stems from the lower staff were used in the > following example, it would be necessary to turn automatic beam > collision > avoidance off.". I think it would be useful to add the command here. Done. Approved.

Further build bugs

2011-06-13 Thread Phil Holmes
I've now reduced the output from make doc from over 500,000 lines to just over 100,000 so there are some error messages I see that were not obvious before. In the output I see: cd ./out-www; texi2pdf -I /home/phil/lilypond-git/Documentation -I /home/phil/lilypond-git/input/regression --quiet

Re: problem with beam collision (was: problem with cross-staffstems,?on lilypond-user)

2011-06-13 Thread Janek Warchoł
2011/6/13 Phil Holmes : > - Original Message - From: "Janek Warchoł" > > >> Ok, it's not the time to discuss policies. Added as "Cross-staff >> chords - beaming problems workarounds" > > The snippet says "If the stems from the lower staff were used in the > following example, it would be n

Re: problem with beam collision (was: problem with cross-staffstems, ?on lilypond-user)

2011-06-13 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" Ok, it's not the time to discuss policies. Added as "Cross-staff chords - beaming problems workarounds" The snippet says "If the stems from the lower staff were used in the following example, it would be necessary to turn automatic beam col

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-13 Thread Janek Warchoł
2011/6/13 : > Thanks - much clearer! > > Two points: > > a) It would be better to honour the value of 'gap if this > is set by the user, rather than change a specifically > requested gap value. My rationale is that it wouldn't make sense to set a big gap and really want to have it applied to all

Re: problem with beam collision (was: problem with cross-staff stems,?on lilypond-user)

2011-06-13 Thread Janek Warchoł
2011/6/12 Graham Percival : > On Sun, Jun 12, 2011 at 02:06:35PM +0200, Janek Warchoł wrote: >> 2011/6/11 Graham Percival : >> > Is this problem likely to be unfixed?  Or is there a compelling >> > reason to override our normal doc policy in this specific case? >> > I am always happy to grant excep

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-13 Thread tdanielsmusic
Thanks - much clearer! Two points: a) It would be better to honour the value of 'gap if this is set by the user, rather than change a specifically requested gap value. b) I don't understand why quanting is desired. An ambitus doesn't align with anything. What is your reason? http://coderevie

Re: doc: changing example for overriding positions (issue4607043)

2011-06-13 Thread Janek Warchoł
2011/6/12 : > LGTM. Could you send me the final patch for pushing? Attached. From def5b44aba34023d30fd29c74995a6f49f70dd51 Mon Sep 17 00:00:00 2001 From: Janek Warchol Date: Sun, 12 Jun 2011 12:41:44 +0200 Subject: [PATCH] doc: changing example for overriding positions example in LM 4.5.2 (fix

Re: doc: changing example for overriding positions (issue4607043)

2011-06-13 Thread lemniskata . bernoullego
Style problems corrected. Thanks for review, Neil! http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/4607043/diff/1/Documentation/learning/tweaks.itely#newcode2801 Documentation/learni

Re: Makes outside-staff-property work for TupletNumber. (issue4530112)

2011-06-13 Thread m...@apollinemike.com
On Jun 12, 2011, at 6:52 PM, n.putt...@gmail.com wrote: > LGTM. > > > http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm > File scm/define-grobs.scm (right): > > http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm#newcode2344 > scm/define-grobs.scm:2344: (direction

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-13 Thread mike
On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: > On 2011/06/05 10:18:18, mike_apollinemike.com wrote: >> On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: > >>> >>> http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm >>> File scm/output-lib.scm (right): >>> >

Re: 2.15.1 with new fontforge

2011-06-13 Thread Graham Percival
On Mon, Jun 13, 2011 at 12:44:14PM +0200, Jan Warchoł wrote: > 2011/6/11 Graham Percival : > > 2.15.1 has fontforge 20110222. > > = fontforge 20110222 is required for building 2.15 It is not required. It is optional. It will become required once it's in lilydev. Cheers, - Graham _

Re: 2.15.1 with new fontforge

2011-06-13 Thread Jan Warchoł
2011/6/11 Graham Percival : > 2.15.1 has fontforge 20110222. = fontforge 20110222 is required for building 2.15 and != fontforge 20110222 included in lilydev, but it will be? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Re: CueClefs: Use middleCClefPosition in the key engraver (issue4551101)

2011-06-13 Thread Jan Warchoł
LGTM. Btw, is it possible to download a source file from Rietveld? I'd like to copy the regression test written by Reinhold, and i'm too lazy to remove all the '+' at the beggining of lines manually... Janek ___ lilypond-devel mailing list lilypond-dev

log message about old version (was: Old version 2.6.0? on user)

2011-06-13 Thread Janek Warchoł
summary for devs: we suppose that error message about too old a version error: file too old: 2.6.0 (oldest supported: 2.7.38) error: consider updating the input with the convert-ly script is misleading, and consider changing it. 2011/6/12 Brent Annable : > Hey Janek, > > I'm using the latest

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-13 Thread lemniskata . bernoullego
On 2011/06/13 08:01:22, Trevor Daniels wrote: The interpersed comments make it very difficult to read the code. Could you place an abridged summary at the top instead? Done. I write a lot of comments so that rookies like me would be able to understand the code in finite time, if they happen to

Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-13 Thread tdanielsmusic
The interpersed comments make it very difficult to read the code. Could you place an abridged summary at the top instead? http://codereview.appspot.com/4609041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listi