On 5/6/11 7:03 PM, "percival.music...@gmail.com"
wrote:
> woah, this is confusing.
>
> Could go back to the 2nd draft patch, yesterday's version? That is a
> very nice, self-contained patch. I'd like to have the official review
> period and get that pushed.
>
> I have no reason to believe tha
also, could we change the subject of the commit? (either by clever git
stuff, or by starting a new commit on a separate git branch --
personally, I'd do the latter)
Something like:
Suppress known "missing" warnings in extract_texi
(remember about the 50-char soft limit)
The point behind the pa
woah, this is confusing.
Could go back to the 2nd draft patch, yesterday's version? That is a
very nice, self-contained patch. I'd like to have the official review
period and get that pushed.
I have no reason to believe that the other changes are bad; I just think
that they're premature, and t
Carl, you wrote Friday, May 06, 2011 11:26 PM
LGTM.
Thanks!
I tried fixing this but couldn't track down all the interfaces to
figure
it out. I saw that we were going off staff position rather than
parent
position, but didn't know where to fix it.
I've done little else in my LilyPond t
LGTM.
I tried fixing this but couldn't track down all the interfaces to figure
it out. I saw that we were going off staff position rather than parent
position, but didn't know where to fix it.
Thanks!
http://codereview.appspot.com/4489042/
___
lily
Reviewers: ,
Message:
This is a fix for issue 877, "Ottava clefs may not look good". See
http://code.google.com/p/lilypond/issues/detail?id=877
The regtests run clean except for
cue-clef-octavation.ly
skiptypesetting-multimeasurerest.ly
both of which are improved, and 1 pixel differences
On 5/6/11 8:52 AM, "m...@apollinemike.com" wrote:
> On May 4, 2011, at 1:49 AM, Neil Puttock wrote:
>
>> On 3 May 2011 23:44, m...@apollinemike.com wrote:
>>> Back to http://codereview.appspot.com/4438092/, it seems as if this doesn't
>>> screw up the harmonics problem.
>>
>> But they're alrea
On May 4, 2011, at 1:49 AM, Neil Puttock wrote:
> On 3 May 2011 23:44, m...@apollinemike.com wrote:
>> Back to http://codereview.appspot.com/4438092/, it seems as if this doesn't
>> screw up the harmonics problem.
>
> But they're already screwed (probably since the Tab_harmonic_engraver
> was re
I think this just about completes this, unless we want to get rid of the
3 'Not a directory' messages.
http://codereview.appspot.com/4428077/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674
Documentation/notation/input.itely:674: @example
On 2011/05/05 11:
Looks mostly good to me.
Carl
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667
Documentation/notation/input.itely:
comments about the first section.
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode674
Documentation/notation/input.itel
Draft 8
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4124056/diff/32001/Documentation/notation/input.itely#newcode667
Documentation/notation/input.itely:667: Text fields left un
13 matches
Mail list logo
