Re: Beam collision engraver weirdness

2011-02-28 Thread Mike Solomon
This does the trick. \score { \new PianoStaff << \new Staff = "one" \relative c'{ \autoBeamOff \stemUp c8 c \change Staff=two \stemUp c c c c c c \change Staff=one \stemDown c8 c \change Staff=two \stemUp c c r2 \stemDown c8[ c \change Staff=one \stemDown c c] r2 \ch

Beam collision engraver weirdness

2011-02-28 Thread Han-Wen Nienhuys
Hey mike, have a look at the .ly below In this case, the 2nd beam and a note from the 2nd beam get added to the 1st beam. Can you make sure this does not happen? thanks, \context PianoStaff << \new Staff = "one" \relative c'{ \autoBeamOff \stemUp c8 c \change Staff=two \stemUp c c

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread mtsolo
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc File lily/footnote-engraver.cc (right): http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode67 lily/footnote-engraver.cc:67: b->set_property ("footnote-text", event->get_property ("footnote-t

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread n . puttock
http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc File lily/footnote-engraver.cc (right): http://codereview.appspot.com/4213042/diff/35006/lily/footnote-engraver.cc#newcode67 lily/footnote-engraver.cc:67: b->set_property ("footnote-text", event->get_property ("footnote-t

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread mtsolo
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc#newcode77 lily/balloon.cc:77: Grob *commonx = bounds[LEFT]->common_refpoint (bounds[RIGHT], X_AXIS); On 2011/02/28 23:04:21, Neil Puttoc

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread n . puttock
http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc File lily/balloon.cc (right): http://codereview.appspot.com/4213042/diff/44001/lily/balloon.cc#newcode77 lily/balloon.cc:77: Grob *commonx = bounds[LEFT]->common_refpoint (bounds[RIGHT], X_AXIS); You might as well say Grob *common

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread Mike Solomon
On Feb 28, 2011, at 5:42 PM, Neil Puttock wrote: > On 28 February 2011 00:32, wrote: > >> For now, I'm just gonna remove this kludge and leave it as is. It means >> that certain spanners may budge when annotations are attached to them, >> but I'll need more time to figure out a sustainable way

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread Neil Puttock
On 28 February 2011 00:32, wrote: > For now, I'm just gonna remove this kludge and leave it as is.  It means > that certain spanners may budge when annotations are attached to them, > but I'll need more time to figure out a sustainable way to get the axis > engraver to ignore the height of these

Re: Reduces algorithm time by prefinding footnoted grobs (issue4213042)

2011-02-28 Thread Neil Puttock
On 28 February 2011 21:06, m...@apollinemike.com wrote: > I found a problem w/ my footnote work.  Check out the 2nd example in bad.ly > and bad.pdf .  Why do you think the annotation is placed so far to the left > here but not in other cases? You're setting the spanner bounds to a NonMusicalPa

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread Patrick Schmidt
Am 28.02.2011 um 22:14 schrieb James Lowe: > Patrick > > -Original Message- > From: > Reply-To: , , > , , lilypond-devel > , > Date: Mon, 28 Feb 2011 21:00:15 + > To: , , > > Cc: , lilypond-devel > > Subject: Re: Doc: harmonics and slides (issue4186049) > >> BTW I accidentally c

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread James Lowe
Patrick -Original Message- From: Reply-To: , , , , lilypond-devel , Date: Mon, 28 Feb 2011 21:00:15 + To: , , Cc: , lilypond-devel Subject: Re: Doc: harmonics and slides (issue4186049) >BTW I accidentally created another issue number (4245047). Sorry for >that. How can I delete it

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Hi all, here is a revised patch. I hope everything is ok now. I don't know why two files I did not alter are part of this patch: hymn-template.ly and partcombine-and-autobeamoff.ly. BTW I accidentally created another issue number (4245047). Sorry for that. How can I delete it? Thanks for your h

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread Patrick Schmidt
Am 28.02.2011 um 14:21 schrieb pkx1...@gmail.com: > One comment. > > Thanks for your time. > > > http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely > File Documentation/notation/fretted-strings.itely (right): > > http://codereview.appspot.com/4186049/

Re: Doc: NR @Knownissues for Grace Notes in many Voices (issue4250044)

2011-02-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4250044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR @Knownissues for Grace Notes in many Voices (issue4250044)

2011-02-28 Thread pkx166h
Reviewers: , Message: This is a patch from Phil. I've made some minor formatting changes to bring it in line with the CG. http://codereview.appspot.com/4250044 Description: Doc: NR @Knownissues for Grace Notes in many Voices This is http://code.google.com/p/lilypond/issues/detail?id=667 Addin

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread Jean-Charles Malahieude
Le 28/02/2011 18:27, Phil Holmes disait : - Original Message - From: "Graham Percival" a10 is 26mm by 37m. Must be like very thin toilet tissue. Is it perforated? Just for information: http://en.wikipedia.org/wiki/Paper_format Cheers,Jean-Charles ___

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread Phil Holmes
- Original Message - From: "Graham Percival" a10 is 26mm by 37m. Must be like very thin toilet tissue. Is it perforated? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypo

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread Han-Wen Nienhuys
On Mon, Feb 28, 2011 at 11:48 AM, wrote: > Great work!  Two comments below concerning beam properties. > > > http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc > File lily/beam.cc (right): > > http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156 > lily/beam.cc:1156:

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread Graham Percival
On 2/28/11, pkx1...@gmail.com wrote: > Do we not want to make a custom edit in the .scm file also? > > Perhaps, with a size of height 35mm. a10 is 26mm by 37m. c10 is 28 by 40mm. pa10 is 26mm by 35mm. *shrug* if one of those isn't small enough (also don't forget about landscape size if that's

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread Han-Wen Nienhuys
On Mon, Feb 28, 2011 at 11:48 AM, wrote: > Great work!  Two comments below concerning beam properties. http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156 > lily/beam.cc:1156: Real min_y_size = 2.0; > here, we should have something like > if (to_boolean (me->get_property ("a

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread pkx166h
Graham, thanks. Do we not want to make a custom edit in the .scm file also? Perhaps, with a size of height 35mm. This was about the minimum size I was able to create the default 'This is a scale in LilyPond' PDF created from the first time you run the binary that also includes space for the tagl

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread m...@apollinemike.com
Attached is the type of note-on-beam thing I was talking about in my previous comments, which can be fixed w/ a padding property. Cheers, MS <> On Feb 28, 2011, at 9:48 AM, mts...@gmail.com wrote: > Great work! Two comments below concerning beam properties. > > > http://codereview.appspot.com

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread mtsolo
Great work! Two comments below concerning beam properties. http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4239047/diff/3002/lily/beam.cc#newcode1156 lily/beam.cc:1156: Real min_y_size = 2.0; here, we should have something l

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread Carl . D . Sorensen
LGTM. Thanks, Carl http://codereview.appspot.com/4239048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread tdanielsmusic
LGTM. Just one trivial nitpick. http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode389 Documen

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread pkx166h
One comment. Thanks for your time. http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode427 Doc

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread Han-Wen Nienhuys
On Mon, Feb 28, 2011 at 8:21 AM, m...@apollinemike.com wrote: >> fixed. >> >> http://codereview.appspot.com/4239047/ > > Several of the tests that I've been running work better with this new version > - large collisions are now handled no problem. > > The only things that don't work properly are

Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-02-28 Thread Janek Warchoł
2011/2/28 Trevor Daniels > > Graham Percival wrote Monday, February 28, 2011 7:39 AM >> >> On 2/27/11, Janek Warchoł wrote: >>> >>> Here you are. This contains all the changes and should apply cleanly >>> to origin/master. >> >> Thanks, pushed. > > This commit causes many changes to the reg tests

Re: improving the transition between full-length and shortenedstems. (issue4210051)

2011-02-28 Thread Trevor Daniels
Graham Percival wrote Monday, February 28, 2011 7:39 AM On 2/27/11, Janek Warchoł wrote: Here you are. This contains all the changes and should apply cleanly to origin/master. Thanks, pushed. This commit causes many changes to the reg tests due to the small increase in some of the stems

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread percival . music . ca
LGTM http://codereview.appspot.com/4186049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Extend Beam::shift_region_to_valid() to also take into account collisions. (issue4239047)

2011-02-28 Thread m...@apollinemike.com
On Feb 27, 2011, at 11:27 PM, hanw...@gmail.com wrote: > On 2011/02/28 04:06:03, hanwenn wrote: >> There are two issues in the regtest: it gets confused by x-staff > beams, and it >> tries to avoid the start of staff clef when the beam crosses a line > breaks. > > fixed. > > http://codereview.ap

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Is it ok, now? Thanks, patrick http://codereview.appspot.com/4186049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

doc-section.sh now uses ~/lilypond-git/

2011-02-28 Thread Graham Percival
I've changed scripts/auxiliar/doc-section.sh to use ~/lilypond-git/ by default, since this was confusing some contributors and the change had snuck into a patch they were proposing. Sorry for the inconvenience if you use a different dir, but we should make it simple for beginners and standardizing

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-02-28 Thread percival . music . ca
http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh File scripts/auxiliar/doc-section.sh (right): http://codereview.appspot.com/4188056/diff/20001/scripts/auxiliar/doc-section.sh#newcode33 scripts/auxiliar/doc-section.sh:33: FROMDIR="$HOME/lilypond-git" I totally agr

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread percival . music . ca
I had to run scripts/makelsr.py before I could compile this patch. Please do the same, then do: git add Documentation/snippets/*.ly git commit . and upload a new patch. Other than that, LGTM. http://codereview.appspot.com/4186049/ ___ lilypond-

Re: Doc: harmonics and slides (issue4186049)

2011-02-28 Thread p . l . schmidt
Reviewers: Graham Percival, Message: Hi Graham, here is a revised patch. Cheers, patrick Description: harmonics and slides new patch # This will displayed on the codereview site. harmonics-and-slides-V include file for chord glissando harmonics-and-slides-IV new snippets harmonic

Re: build failure for freebsd-x86 in beam-quanting.cc

2011-02-28 Thread Graham Percival
On 2/28/11, Jan Nieuwenhuizen wrote: > Graham Percival schreef op ma 28-02-2011 om 09:35 [+]: >> /main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638: >> error: 'round' was not declared in this scope >> >> I'm guessing that you n

Re: build failure for freebsd-x86 in beam-quanting.cc

2011-02-28 Thread Jan Nieuwenhuizen
Graham Percival schreef op ma 28-02-2011 om 09:35 [+]: > /main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638: > error: 'round' was not declared in this scope > > I'm guessing that you need to explicitly include some other header

build failure for freebsd-x86 in beam-quanting.cc

2011-02-28 Thread Graham Percival
/main/src/gub/target/freebsd-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/beam-quanting.cc:638: error: 'round' was not declared in this scope I'm guessing that you need to explicitly include some other header because round() is in default in glibc but not in freebsd libc, or

Use Doc PO files for something (Was Fwd: [translations] Translation of "top" and broken link)

2011-02-28 Thread Francisco Vila
I'd like a bug to be open about this, if possible. Translated docs used to make all comments, context IDs and variable names in lilypond code to become translated from strings in Documentation/po/.po files. This does not work anymore and we are not able to determine when did stop working. Transla

Re: lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread percival . music . ca
Test case: foo.tely: \input texinfo @node Top @top Texinfo text @lilypond[papersize=a8] \book{ \score { \relative c' { a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d a4 b c d } }} @end lilypond @bye http://codereview.appspot.com/423904

lilypond-book: add [pagesize=xyz] option. (issue4239048)

2011-02-28 Thread percival . music . ca
Reviewers: , Message: We've had a doc editor doing bugger-all for the past two weeks because nobody cooked up this 8-line python patch. Please review. I'm pushing it in 24 hours unless somebody screams. Description: lilypond-book: add [pagesize=xyz] option. This will be *extremely* useful whe

Re: dodecaphonic accidentals

2011-02-28 Thread Keith OHara
On Sun, 27 Feb 2011 23:58:45 -0800, Graham Percival wrote: Did you intend to remove the dodecaphonic accidentals snippet from our docs? If so (i.e. it's been replaced with 2.13 functionality), then we needs some magic in Documentation/snippets/new/ . Yes; it was obsolete even in version 2.1

Re: git rebase and gitk

2011-02-28 Thread Graham Percival
On Sun, Feb 27, 2011 at 09:23:00PM +0100, Reinhold Kainhofer wrote: > Am Sonntag, 27. Februar 2011, um 21:03:35 schrieb Graham Percival: > > git rebase -i origin/master > > > > are there any dangers with that? > > That's why a do a "git rebase origin/master" (non-interactive) > first, where I o