PATCHES: check your own

2011-02-24 Thread Graham Percival
As a reminder, we're using the google tracker to organize patches: http://code.google.com/p/lilypond/issues/list?can=2&q=label:patch&sort=patch 1) If you've submitted a patch recently (or even not recently), it should be in that list. If your patch isn't on that list, we've lost it. Sorry, pleas

PATCHES: 48-hour notice for toc dots, stem transitions, and doc accidentals

2011-02-24 Thread Graham Percival
Sunday, 6am UK time. Add dots to tocItemMarkup http://code.google.com/p/lilypond/issues/detail?id=1517 improving the transition between full-length and shortened stems http://codereview.appspot.com/4210051/ Doc: NR accidental styles http://codereview.appspot.com/4149045/ Cheers, - Graham ___

Fix 748. Key signatures for modes (issue4237041)

2011-02-24 Thread percival . music . ca
LGTM, passes regtests. http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly File ly/arabic.ly (right): http://codereview.appspot.com/4237041/diff/2001/ly/arabic.ly#newcode36 ly/arabic.ly:36: (0 . ,NATURAL) This might cause a merge conflict in Felipe's work. I'm not criticizing it; this

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-24 Thread percival . music . ca
LGTM. In light of the changes, let's have one more round of giving chances for reviews. http://codereview.appspot.com/4182056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR accidental styles (issue4149045)

2011-02-24 Thread percival . music . ca
LGTM http://codereview.appspot.com/4149045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-24 Thread Graham Percival
On 2/24/11, lemniskata.bernoull...@gmail.com wrote: > This patch handles transition between full length and shortened stems. > It follows Han-Wen suggestions and supports custom stem length and > custom staves. Thanks, this now: http://code.google.com/p/lilypond/issues/detail?id=1538 Cheers, - G

Re: Microtonal key signatures fix

2011-02-24 Thread Keith OHara
On Thu, 24 Feb 2011 19:45:32 -0800, Keith OHara wrote: ... tunings like XX-ET, popular in the 1600s, where C-sharp is 2/5 of a whole tone above C. Argh. It is 31-ET that has the 2/5ths. People liked it because it nearly matched quarter-comma meantone. I should learn to look things up befo

Re: Microtonal key signatures fix

2011-02-24 Thread Keith OHara
Benkő Pál writes: Graham Breed writes: > If the accidentals aren't halves, the MIDI production fails. Please explain in more detail, I never had such problems with MIDI. The following (derived from an example in the manual) crashes: \include "makam.ly" mode = #`((6 . ,(- KOMA)) (3 . ,BAKIYE)

Re: Beam collision push

2011-02-24 Thread m...@apollinemike.com
On Feb 24, 2011, at 10:21 PM, Bertrand Bordage wrote:Hi,You're cheating a bit, Mike !This wasn't "c'4~ c'8." instead of "a4~ a8." in the lower voice.It's even more tight ! Here is the example in context (Breitkopf und Härtel 1878) :http://imslp.org/wiki/Special:ImagefromIndex/05677The last two syst

Re: Beam collision push

2011-02-24 Thread Bertrand Bordage
Mistake in my second line : one must read "was" instead of "wasn't". Bertrand ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Beam collision push

2011-02-24 Thread Bertrand Bordage
Hi, You're cheating a bit, Mike ! This wasn't "c'4~ c'8." instead of "a4~ a8." in the lower voice. It's even more tight ! Here is the example in context (Breitkopf und Härtel 1878) : http://imslp.org/wiki/Special:ImagefromIndex/05677 The last two systems of the second page. You can also notice a s

Re: Beam collision push

2011-02-24 Thread m...@apollinemike.com
On Feb 24, 2011, at 11:23 AM, Mike Solomon wrote: > On Feb 24, 2011, at 10:52 AM, Han-Wen Nienhuys wrote: > >> On Thu, Feb 24, 2011 at 10:11 AM, Mike Solomon wrote: >>> Hey all, >>> >>> Han Wen - I saw that you pushed your beam collision work to master branch. >>> >>> I truly feel that this is

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-24 Thread Bertrand Bordage
Hi, Thanks for your watchfulness ! (Can we say this? I'm pretty bad at English...) I added Graham and Neil's changes. Regards, Bertrand (Git patch attached with the commit's informations) From fe20aad02a7c4a6ace4a9c31670b5f4c7dbe87ba Mon Sep 17 00:00:00 2001 From: Bertrand Bordage Date: Thu, 24

Re: Doc: NR accidental styles (issue4149045)

2011-02-24 Thread k-ohara5a5a
On 2011/02/24 06:32:25, Graham Percival wrote: It's still not showy enough for me. Well, maybe it's showy enough to resolve issue 1399. I posted the output images of the examples to that tracker item. http://code.google.com/p/lilypond/issues/detail?id=1399 Documentation/notation/pitches.itel

Re: transition between full-length and shortened stems - please discuss

2011-02-24 Thread Janek Warchoł
Hi, 2011/2/22 Janek Warchoł > > I'll cook appropriate function tomorrow. > Thanks, > Janek I'm very sorry for the delay, i had some trouble with git. I've uploaded new patch for review, it supports custom stem lengths and staves with custom line count. See differences in output between original

improving the transition between full-length and shortened stems. (issue4210051)

2011-02-24 Thread lemniskata . bernoullego
This patch handles transition between full length and shortened stems. It follows Han-Wen suggestions and supports custom stem length and custom staves. proof-sheets: Lily 2.13.47 output - http://www.sendspace.com/file/7fy9i4 this patch output - http://www.sendspace.com/file/tgmlfc source code: h

Re: Beam collision push

2011-02-24 Thread Han-Wen Nienhuys
On Thu, Feb 24, 2011 at 10:11 AM, Mike Solomon wrote: > Hey all, > > Han Wen - I saw that you pushed your beam collision work to master branch. > > I truly feel that this is premature and I urge you to undo it.  The reason I > have not pushed my patch yet is because I think more people need to ch

Re: `make test-baseline' failure in `remove-empty-staves-auto-knee.ly'

2011-02-24 Thread Han-Wen Nienhuys
On Thu, Feb 24, 2011 at 10:16 AM, Neil Puttock wrote: > Hi Han-Wen, > > I'm using an unoptimized binary and get an assertion failure following > the beam collision changes you've pushed: > > Processing `remove-empty-staves-auto-knee.ly' Thanks for the report. Duh. Pushing a patch... -- Han-Wen

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-24 Thread n . puttock
Hi Betrand, LGTM, apart from a few minor details. Cheers, Neil http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly File ly/toc-init.ly (right): http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly#newcode32 ly/toc-init.ly:32: tocItemWithDotsMarkup = \markup \fill-with-p

Re: shortened stems and flags (issue4134041)

2011-02-24 Thread Janek Warchoł
2011/2/24 Marek Klein > > I have created new [PATCH] issue for this: > http://code.google.com/p/lilypond/issues/detail?id=1538 Thanks for remembering! However, i'm afraid this issue is invalid. We decided to divide this problem and the first part is discussed in http://lists.gnu.org/archive/html/

Re: fine-tuning new flags - feedback needed

2011-02-24 Thread Jan Warchoł
2011/2/24 Marek Klein > > I have created new [PATCH] issue for this: > http://code.google.com/p/lilypond/issues/detail?id=1538 Thanks for remembering! However, i'm afraid this issue is invalid. We decided to divide this problem and the first part is discussed in http://lists.gnu.org/archive/html/

`make test-baseline' failure in `remove-empty-staves-auto-knee.ly'

2011-02-24 Thread Neil Puttock
Hi Han-Wen, I'm using an unoptimized binary and get an assertion failure following the beam collision changes you've pushed: Processing `remove-empty-staves-auto-knee.ly' Parsing... Interpreting music... Preprocessing graphical objects... Finding the ideal number of pages... Fitting music on 1 pa

Beam collision push

2011-02-24 Thread Mike Solomon
Hey all, Han Wen - I saw that you pushed your beam collision work to master branch. I truly feel that this is premature and I urge you to undo it. The reason I have not pushed my patch yet is because I think more people need to chime in. This type of collision avoidance is very important to m

Re: shortened stems and flags (issue4134041)

2011-02-24 Thread Marek Klein
I have created new [PATCH] issue for this: http://code.google.com/p/lilypond/issues/detail?id=1538 Marek ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fine-tuning new flags - feedback needed

2011-02-24 Thread Marek Klein
I have created new [PATCH] issue for this: http://code.google.com/p/lilypond/issues/detail?id=1538 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdfTex failure

2011-02-24 Thread Trevor Daniels
Graham Percival wrote Wednesday, February 23, 2011 2:23 AM On Tue, Feb 22, 2011 at 04:33:34PM +, James Lowe wrote: Hello )After increasing save size to 1 the doc build completed perfectly, so )all is OK at the moment, but as I hacked a file which says "don't hack this" )I guess it

Re: 13.51 regtests

2011-02-24 Thread Trevor Daniels
Francisco Vila wrote Wednesday, February 23, 2011 6:38 PM 2011/2/23 Phil Holmes : Another change I don't understand. Although I don't understand much about regtests, this difference could show that printing order of objects in the same layer (with the same value of the layer property) is

Re: Google Summer of Code - should we participate?

2011-02-24 Thread Graham Percival
On Wed, Feb 23, 2011 at 10:59:46AM -0300, Han-Wen Nienhuys wrote: > 2011/2/23 Janek Warchoł : > > should we participate in Google Summer of Code this year? (it's about > > students from all over the world who work on Open Source projects > > during summer holidays and Google pays them, website: > >