Hi Betrand, LGTM, apart from a few minor details.
Cheers, Neil http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly File ly/toc-init.ly (right): http://codereview.appspot.com/4182056/diff/15002/ly/toc-init.ly#newcode32 ly/toc-init.ly:32: tocItemWithDotsMarkup = \markup \fill-with-pattern #1 #RIGHT . this can be defined outside the \paper block http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3410 scm/define-markup-commands.scm:3410: Otherwise they are spread vertically. remove this line http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3421 scm/define-markup-commands.scm:3421: (let* ((pattern-width (interval-length (let (( http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3427 scm/define-markup-commands.scm:3427: (prepend-alist-chain 'word-space 0 (prepend-alist-chain 'baseline-skip 0 props)) move to separate binding above (e.g., `new-props') http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3428 scm/define-markup-commands.scm:3428: (if (zero? axis) (if (= axis X) http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3431 scm/define-markup-commands.scm:3431: (loop (1- i) indent (goes with (zero? i) above) http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3432 scm/define-markup-commands.scm:3432: (if (zero? axis) (if (= axis X) http://codereview.appspot.com/4182056/diff/15002/scm/define-markup-commands.scm#newcode3473 scm/define-markup-commands.scm:3473: #:pattern (1+ count) X space pattern I'm sorry I wasn't clearer about the indentation here: (markup left #:with-dimensions (cons 0 middle-width) '(0 . 0) #:translate (cons x-offset 0) #:pattern (1+ count) X space pattern http://codereview.appspot.com/4182056/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
