On 2011/02/18 05:43:36, Keith wrote:
The extra complication, for which the care was
given, makes the system more difficult to learn, understand, use, and
repair.
Unfortunately, I believe that the extra complication is necessary. The
commit message didn't clarify the background or our previous
I advise against changing the internal representation of pitches.
I say that even though this looks like very good and careful code, and
after spending two hours studying it. The extra complication, for which
the care was given, makes the system more difficult to learn,
understand, use, and repa
On Mon, Sep 13, 2010 at 8:03 AM, Jay Anderson wrote:
> On Sun, Sep 12, 2010 at 12:46 PM, Neil Puttock wrote:
>> Add the Tweak_engraver to the Dynamics context.
>
> Works fine. Thanks. This should probably be added to engraver-init.ly.
> Are there any problems with doing this?
>
> diff --git a/ly/
On 2/17/11 1:34 PM, "Felipe Gonçalves Assis"
wrote:
> Hi Carl,
>
> The denominators are not implicit.
> They are set in the file scm/lily.scm via the call to ly:set-default-scale.
>
> Also see lily/scale.cc, lily/include/scale.hh and lily/pitch.cc:89
> for how this is implemented.
Ahh, OK.
LGTM.
Can you email me your patch so I can apply it?
Thanks,
Patrick
http://codereview.appspot.com/2219044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/02/17 17:05:25, Reinhold wrote:
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode34
scm/display-lily.scm:34:
> We are in musicxml2ly and a few snippe
Graham (or any TeX wizard)
make doc was failing for me with
TeX capacity exceeded, sorry [save size=5000].
I hacked etc/texmf/texmf.cnf to increase save size,
which allowed make doc to proceed, but what is the
correct way to fix this?
Trevor
__
Reviewers: ,
Message:
Neil's fix for a critical crash with markuplines.
Description:
HACK DO NOT PUSH markuplines fix (Neil)
Please review this at http://codereview.appspot.com/4160059/
Affected files:
M lily/parser.yy
Index: lily/parser.yy
diff --git a/lily/parser.yy b/lily/parser.yy
inde
On 2/17/11, Janek Warchoł wrote:
> I wanted to make Graham happy, so looked through the tracker, picked
> an existing frog issue and made a patch without discussing it for 5
> hours.
Yay! :)
> I think it doesn't make sense to post it on Rietveld...
> It's here (112 kB, too big for an attachment
Hi,
I wanted to make Graham happy, so looked through the tracker, picked
an existing frog issue and made a patch without discussing it for 5
hours.
:)
It's issue 1489 (make regtests end on a barline).
I think it doesn't make sense to post it on Rietveld...
It's here (112 kB, too big for an attachm
New patchset uploaded to Rietveld Issue 2219044.
Please review.
Cheers,
Ian
http://codereview.appspot.com/2219044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/3789044/diff/29001/python/musicexp.py
File python/musicexp.py (right):
http://codereview.appspot.com/3789044/diff/29001/python/musicexp.py#newcode308
python/musicexp.py:308: return '(ly:make-pitch %d %d \'(%d . 0))' %
(self.octave,
On 2011/02/17 20:01:25, Carl wrote
Hi Carl,
The denominators are not implicit.
They are set in the file scm/lily.scm via the call to ly:set-default-scale.
Also see lily/scale.cc, lily/include/scale.hh and lily/pitch.cc:89
for how this is implemented.
ly/makam.ly gives an example of how to modify the denominators.
If you need fur
On 2/17/11, carl.d.soren...@gmail.com wrote:
> I have one question, I think. Right now, the alteration consists of two
> integers, which have implied denominators of 1/2 and 1/4, if I
> understand correctly.
>
> Would it be more general to have the alteration consist of two
> rationals? Or could
This work looks good to me, but I'm not an expert in this area.
I have one question, I think. Right now, the alteration consists of two
integers, which have implied denominators of 1/2 and 1/4, if I
understand correctly.
Would it be more general to have the alteration consist of two
rationals?
Hi,
In fact, this patch is divided in a few commits in my local branch.
The ones which change the pitch representation are most of the
diff. The rest are trivial additions that enable the new notation
to be used.
If this patch is approved, there will be no problem in separating
the work in two or
OK all, I've worked out what to keep and what to nuke.
I'll prepare a new patch-set once I've rebased and tested with Guile V2
on my VM.
Cheers,
Ian
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/d
LGTM.
I admittedly don't know this part of the source well, so I'll leave
comments about that to other programmers.
My only concern is about the scope of this patch. It seems like this
patch is doing two things: implementing a new type of quarter tone
notation & implementing alterations as a re
On 2011/02/17 16:17:29, nicolas.sceaux wrote:
Hi,
Here is a patch for fret diagrams, but as I have very little knowledge
of them I
may well be wrong on some points.
First, it fixes sizing issues, when the size property is overridden:
the xo
signs became too big, and too far from the fir
On 2011/02/17 16:17:29, nicolas.sceaux wrote:
Hi,
Here is a patch for fret diagrams, but as I have very little knowledge
of them I
may well be wrong on some points.
First, it fixes sizing issues, when the size property is overridden:
the xo
signs became too big, and too far from the fir
We're down to 1 patch in the "patch-review" category. It's a
relatively big one, and no programmers have looked at it yet, so I'm
not putting it on a countdown yet.
Issue 1278: Arrow notation for quarter-tones.
http://codereview.appspot.com/3789044/
This patch changes a *lot* of files, but most
Ok, it seems we're all ok with this.
Keith, please email the patch to Trevor for pushing.
http://codereview.appspot.com/4187043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Please push.
http://codereview.appspot.com/4186050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode34
scm/display-lily.scm:34:
We are in musicxml2ly and a few snippets:
$ git grep -l '(define (('
Is define-
Reviewers: carl.d.sorensen_gmail.com,
Message:
Hi,
Here is a patch for fret diagrams, but as I have very little knowledge
of them I may well be wrong on some points.
First, it fixes sizing issues, when the size property is overridden: the
xo signs became too big, and too far from the first fret
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode34
scm/display-lily.scm:34:
On 2011/02/17 15:07:00, ianhulin44 wrote:
In which case, do we even need lily.scm to
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode34
scm/display-lily.scm:34:
On 2011/02/17 06:50:21, Patrick McCarty wrote:
Jan recently removed all of the currie
Hi Patrick,
On 2011/02/17 06:50:21, Patrick McCarty wrote:
Hi Ian,
Please see my new comment regarding this patch (below).
Thanks,
Patrick
http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm
File scm/display-lily.scm (right):
http://codereview.appspot.com/2219044/dif
Now pushed.
fd7ad42f98d7e6117958a41e74cd736e396fb933
Will appear in 2.13.51.
Many thanks, Mike.
http://codereview.appspot.com/4079064/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode861
Documentation/notation/pitches.itely:861: A scale of any length
and with
any intervals may be specified:
"An ascending scale of any length ..."
The octaves are linked smoothly if the scale is asce
http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830
Documentation/notation/pitches.itely:830: left untransformed and a
warning given.}
I'd omit the "and a warning given". I mean, the warning will be
obvious, right? Just end with "... left untransform
31 matches
Mail list logo
