Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/16 Jean-Charles Malahieude : > Le 16/02/2011 13:19, Francisco Vila disait : >> >> 2011/2/16 Francisco Vila: >> BTW does >> >>   LANG=whatever date -u >> >> work for you? for whatever = fr, de etc? >> > > [jcharles@localhost ~]$ LANG=de_DE.utf8 date -u > Mi 16. Feb 18:52:37 UTC 2011 > [jcharl

Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044)

2011-02-16 Thread pnorcks
Hi Ian, Please see my new comment regarding this patch (below). Thanks, Patrick http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm File scm/display-lily.scm (right): http://codereview.appspot.com/2219044/diff/25001/scm/display-lily.scm#newcode34 scm/display-lily.scm:34: Jan

Re: guile 2.0.0 out

2011-02-16 Thread Patrick McCarty
On Wed, Feb 16, 2011 at 7:22 PM, Graham Percival wrote: > On Wed, Feb 16, 2011 at 07:08:29PM -0800, Patrick McCarty wrote: > >>  I have a patch queue with >> (potential) fixes for LilyPond so that we can support both Guile 1.8 >> and 2.0. > > Great!  Comment 5 of > http://code.google.com/p/lilypon

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-16 Thread k-ohara5a5a
Still works well for me, including the new bits. Some late suggestions on the docs that you can take or leave. http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4079064/diff/7001

Re: guile 2.0.0 out

2011-02-16 Thread Graham Percival
On Wed, Feb 16, 2011 at 07:08:29PM -0800, Patrick McCarty wrote: > On Wed, Feb 16, 2011 at 10:04 AM, Graham Percival > wrote: > > > > I don't see a need to support both guile 1.8.x and guile 2.0.x at > > the same time -- as far as I'm concerned, we can drop any > > guile-1.x-isms as soon as 2.15 b

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread Carl . D . Sorensen
Looks good. I had one comment. Feel free to add an entry to the changelog. It's done by editing the file Documentation/changes.tely Thanks, Carl http://codereview.appspot.com/4182056/diff/7001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.ap

Re: guile 2.0.0 out

2011-02-16 Thread Patrick McCarty
On Wed, Feb 16, 2011 at 10:04 AM, Graham Percival wrote: > > I don't see a need to support both guile 1.8.x and guile 2.0.x at > the same time -- as far as I'm concerned, we can drop any > guile-1.x-isms as soon as 2.15 begins. Uh, I'm not sure what you mean here. I have a patch queue with (pote

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread bordage . bertrand
Maybe add \pattern to the changelog ? http://codereview.appspot.com/4182056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread bordage . bertrand
Changes done ! It is more clean now. I'm not sure if the commands are in the right categories. I also noticed numerous commands have @code instead of @var and vice versa in their descriptions. Center-align's args or fill-line's line-width for example. Should I do a small patch to fix these ? Reg

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread Trevor Daniels
Keith OHara wrote Wednesday, February 16, 2011 8:54 PM On Wed, 16 Feb 2011 08:08:10 -0800, wrote: On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if

Re: guile 2.0.0 out

2011-02-16 Thread David Kastrup
Graham Percival writes: > On Wed, Feb 16, 2011 at 09:19:01PM +0100, David Kastrup wrote: >> Graham Percival writes: >> >> > I don't see a need to support both guile 1.8.x and guile 2.0.x at the >> > same time -- as far as I'm concerned, we can drop any guile-1.x-isms >> > as soon as 2.15 begins

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread Keith OHara
On Wed, 16 Feb 2011 08:08:10 -0800, wrote: On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if lyrics are spaced to clear that protrusion. The bar-lines th

Re: guile 2.0.0 out

2011-02-16 Thread Graham Percival
On Wed, Feb 16, 2011 at 09:19:01PM +0100, David Kastrup wrote: > Graham Percival writes: > > > I don't see a need to support both guile 1.8.x and guile 2.0.x at the > > same time -- as far as I'm concerned, we can drop any guile-1.x-isms > > as soon as 2.15 begins. > > As long as guile is not in

Re: guile 2.0.0 out

2011-02-16 Thread David Kastrup
Graham Percival writes: > I don't see a need to support both guile 1.8.x and guile 2.0.x at the > same time -- as far as I'm concerned, we can drop any guile-1.x-isms > as soon as 2.15 begins. As long as guile is not included with Lilypond, supporting the last stable version in reasonably up-to-

Re: make translation-status fails

2011-02-16 Thread Jean-Charles Malahieude
Le 16/02/2011 13:19, Francisco Vila disait : 2011/2/16 Francisco Vila: BTW does LANG=whatever date -u work for you? for whatever = fr, de etc? [jcharles@localhost ~]$ LANG=de_DE.utf8 date -u Mi 16. Feb 18:52:37 UTC 2011 [jcharles@localhost ~]$ LANG=de date -u Wed Feb 16 18:53:21 UTC 2011

Re: make translation-status fails

2011-02-16 Thread Jean-Charles Malahieude
Le 16/02/2011 13:19, Francisco Vila disait : 2011/2/16 Francisco Vila: Fixed in git, I hope. Still testing the build. OK succeeds here as well. Thanks for the chase! BTW does LANG=whatever date -u work for you? for whatever = fr, de etc? [jcharles@localhost ~]$ LANG=zh date -u Wed

Re: LSR and docs

2011-02-16 Thread Carl Sorensen
On 2/16/11 11:15 AM, "Phil Holmes" wrote: > One of my first jobs hereabouts was adding snippets to the LSR and tagging > them with "docs". Could someone explain a) the significance of this and b) > how snippets are imported from the LSR into the LM and NR? I'm assuming the > two are linked, but

Re: LSR and docs

2011-02-16 Thread Graham Percival
On Wed, Feb 16, 2011 at 06:15:03PM -, Phil Holmes wrote: > One of my first jobs hereabouts was adding snippets to the LSR and > tagging them with "docs". Could someone explain a) the significance > of this and It adds those snippets to the snippets-*-docs.tar.gz > b) how snippets are importe

LSR and docs

2011-02-16 Thread Phil Holmes
One of my first jobs hereabouts was adding snippets to the LSR and tagging them with "docs". Could someone explain a) the significance of this and b) how snippets are imported from the LSR into the LM and NR? I'm assuming the two are linked, but not sure how. TIA. -- Phil Holmes Bug Squad

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-16 Thread percival . music . ca
LGTM http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/4079064/diff/7001/Documentation/notation/pitches.itely#newcode830 Documentation/notation/pitches.itely:830: left untransform

guile 2.0.0 out

2011-02-16 Thread Graham Percival
Guile 2.0.0 is out. - no, there is no way that we'll try to add this for 2.14. Nice try! :) - changing to 2.0.0 could be done immediately after starting 2.15, as long as three conditions are met: 1. the regtests compile 2. the docs compile 3. the latest lilydev contains that vers

Re: Lyric alignment

2011-02-16 Thread Carl Sorensen
On 2/16/11 9:31 AM, "Trevor Daniels" wrote: > > > Carl Sorensen wrote Saturday, February 12, 2011 9:09 PM > > >> I've attached a .ly file and its output. I think it gives the >> desired >> output. I'd welcome any comments. > > Looks useful. > > What about adding a third argument so 'st

Re: Lyric alignment

2011-02-16 Thread Trevor Daniels
Carl Sorensen wrote Saturday, February 12, 2011 9:09 PM I've attached a .ly file and its output. I think it gives the desired output. I'd welcome any comments. Looks useful. What about adding a third argument so 'staff-affinity becomes set within the function too? \setLyricSpacing #25 #

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-16 Thread Trevor Daniels
http://codereview.appspot.com/4160048/diff/11001/Documentation/notation/rhythms.itely#newcode2229 Documentation/notation/rhythms.itely:2229: changed, so that when the time signature is set the desired What about: ... changed, so that the desired beaming is always used for that time signat

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-16 Thread tdanielsmusic
On 2011/02/15 18:36:06, Keith wrote: If there is /any/ protrusion on the lyrics side of the staff, anywhere in the score, then the PaperColumn skylines used for note-spacing are built as if lyrics are spaced to clear that protrusion. The bar-lines then slide past this assumed position of lyrics.

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread Carl . D . Sorensen
http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994 scm/define-markup-commands.scm:994: (define (nest-patterns pattern pattern-width distanc

Re: Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread bordage . bertrand
Reviewers: carl.d.sorensen_gmail.com, Message: A few questions. http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994 scm/define-markup-comm

Re: StaffGrouper properties does not apply to "second level" StaffGroup

2011-02-16 Thread Ralph Palmer
On Mon, Feb 7, 2011 at 6:32 AM, Xavier Scheuer wrote: > %% Reported on LilyPond French Users mailing list > %% > http://lilypond-french-users.1298960.n2.nabble.com/Arrangement-vertical-encore-une-petite-amelioration-tp5982503p5998593.html > %% > %% StaffGrouper properties does not apply to "seco

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-02-16 Thread ColinPKCampbell
On 2011/02/16 06:08:03, Keith wrote: Looks good as it is, better if you can add one markup that Reinhold missed in the example. http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.a

Add dots to tocItemMarkup (issue4182056)

2011-02-16 Thread Carl . D . Sorensen
Looks very good. Just a couple more comments. Thanks, Carl http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4182056/diff/1/scm/define-markup-commands.scm#newcode994 scm/define-markup-comman

Re: 4167050: Changes the beam collision engraver to check for subsequent beams (Re: collision between beams and grace notes)

2011-02-16 Thread Han-Wen Nienhuys
On Tue, Feb 15, 2011 at 6:58 PM, Neil Puttock wrote: > On 15 February 2011 20:02, m...@apollinemike.com > wrote: > >> I've uploaded a patch that takes grace notes (and other beams) into account. >> Keith - I'm not sure if this is the case.  Currently, both my algorithm & >> Han-Wen's get the att

Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/16 Francisco Vila : > > Fixed in git, I hope. Still testing the build. > BTW does LANG=whatever date -u work for you? for whatever = fr, de etc? -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mai

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-16 Thread Benkő Pál
> I've just uploaded the latest changes from Mike.  These extend > modalInversion to permit inversions around a pivot between two notes in > the scale. > > There are also some minor changes suggested by Graham. > > Please review. LGTM > http://codereview.appspot.com/4079064/

Re: Add modal transformations provided by Mike Ellis (issue4079064)

2011-02-16 Thread tdanielsmusic
I've just uploaded the latest changes from Mike. These extend modalInversion to permit inversions around a pivot between two notes in the scale. There are also some minor changes suggested by Graham. Please review. Trevor http://codereview.appspot.com/4079064/ __

Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/16 Francisco Vila : > I have discovered that > >  translation[l] (last_updated_string) > > does not contain the %s format placeholder for l=zh > > I looks as an easy fix from here. Stay tuned. Fixed in git, I hope. Still testing the build. -- Francisco Vila. Badajoz (Spain) www.paconet.o

Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/16 Francisco Vila : > 2011/2/16 Francisco Vila : >> This diff can temporarily make 'make translation-status' to succeed, >> without the last-updated string whose generation fails. > > I resend as an attachment. I have discovered that translation[l] (last_updated_string) does not contain

Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/16 Francisco Vila : > This diff can temporarily make 'make translation-status' to succeed, > without the last-updated string whose generation fails. I resend as an attachment. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com diff --git a/scripts/auxiliar/translation

Re: make translation-status fails

2011-02-16 Thread Francisco Vila
2011/2/12 Jean-Charles Malahieude : >>> make translation-status >> >> ... >>> >>> Traceback (most recent call last): >>>  File >>> "/home/jcharles/GIT/Traduc/scripts/auxiliar/translations-status.py", >>> line 727, in >>>    updated = markup.paragraph (markup.emph (translation[l] >>> (last_updated_s

Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-02-16 Thread reinhold . kainhofer
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode846 Documentation/notation/simultaneous.itely:846: change t