Hi,
In the attached snippet, the call to ly:set-default-scale has no
effect on the midi result, both in the stable and development
versions.
I believe that this is due to Pitches being constructed before
the new default_global_scale is set (see files lily/pitch.cc and
lily/scale.cc), so that they
Tell me if it is trivial to load patches from lily-git onto Reitveld.
The Contributors Guide implies that the lily-git patches are intended
for emailing to regular git-users.
http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressi
On 12/19/10 10:14 PM, "Keith OHara" wrote:
Posted for review on Rietveld:
http://codereview.appspot.com/3782042/
Thanks!
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 12/19/10 10:14 PM, "Keith OHara" wrote:
> Patch created by lily-git.tcl
> -Keith
Keith,
I've posted your patch for review on Rietveld. I'm sorry that I forgot to
include you on the reviewer list, but you should get it as part of the
-devel list.
Just in case, here's the URL:
http://code
Looks mostly good to me -- one styling nit.
Thanks!
Carl
http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely
File Documentation/notation/expressive.itely (right):
http://codereview.appspot.com/3732046/diff/1/Documentation/notation/expressive.itely#newcode313
D
Reviewers: ,
Message:
Here's Keith's patch for cross-staff documentation.
LGTM.
Description:
Doc: NR cross-staff
Some collisions are allowed by design,
as controlled by the 'cross-staff' property.
Please review this at http://codereview.appspot.com/3782042/
Affected files:
M Documentation/
Reviewers: ,
Message:
Here are Keith's suggested doc changes for the Dynamics context and
postfix (de)crescendo notation.
Description:
Documentation of Dynamics context and postfix dynamics changes
Please review this at http://codereview.appspot.com/3732046/
Affected files:
M Documentation/n
Thanks for the review, Patrick.
I've made the changes and posted a new patch set.
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhyth
We decided not to document this earlier because it is logged in the tracker
(issues 36, 439, 721, 1324, 1411).
However, searching the code for 'cross-staff', I see that allowing some
collisions is clearly intentional. After thinking a bit, it becomes clear that
some collisions must be allowed
Patch created by lily-git.tcl
-Keith
0001-Doc-NR-new-dynamics-context-cresc.patch
Description: Binary data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Just some Nitpicks
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/3693042/diff/9001/Documentation/notation/rhythms.itely#newcode
Documentation/notation/rhythms.itely::
On 19 December 2010 13:50, Phil Holmes wrote:
> Looks nonsense. Think the description should be "A staff should die if
> there is _no_ reference to it.".
Definitely. The original test had the following description:
"a staff should really die, if no one's referencing it."
> And the regtest s
LGTM.
http://codereview.appspot.com/3693042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hope these aren't too nit-picky.
http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode527
Documentation/notation/input.itely
Mark,
This is really useful stuff. Thanks!
However, I agree with Trevor about the LM vs NR style of writing.
The NR needs to be terse and show, rather than tell, the story. In an
effort to be clear, we often try to both tell and show. I spent a lot
of time when I first started writing NR sec
I like it, and think it's ready for pushing.
Just for purposes of clarification, let me summarize the original
problem, since I didn't do a good job before.
The syntax of alternative is:
\alternative {
ending_one
ending_two
ending_three
}
NOT
\alternative {
{ ending_one }
{ endin
- Original Message -
From: "James Bailey"
To:
Sent: Sunday, December 19, 2010 1:07 PM
Subject: regression test checking
What does the description for context-die-staff.ly mean?
\version "2.12.0"
\header {
texidoc = "a staff should die if there is reference to it."
}
\layout {
rag
What does the description for context-die-staff.ly mean?
\version "2.12.0"
\header {
texidoc = "a staff should die if there is reference to it."
}
\layout {
ragged-right = ##t
line-width = 2.5 \cm
indent = 0.0
}
{
<< \new Staff = "q" \new Voice ="V" c1 >>
%% no \break, BreakEvent ca
Greetings Mark,
I actually kinda like this writing style, it's more explanatory and
detailed that other NR material but if it can help make things more
clear then I think we should accept it.
The downside is that it "talks through the code" quite a lot, perhaps
you could remove all variable name
I've looked at the compiled version now. It's nicely written, but my
concern is that this is no longer written in 'reference' style. To me,
parts of it seem more suited to the LM. The idea of the NR is that
people already well-familiar with LilyPond can quickly find a keyword or
syntax they hav
A short note about bookpart titles.
http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely#newcode538
Documentation/notation/input.it
Just a few comments after eye-balling the patch. I'll need to download
and compile to comment more fully.
http://codereview.appspot.com/3667041/diff/13001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/3667041/diff/13001/Docume
22 matches
Mail list logo
