Re: german doc patch, issue 1344

2010/11/13 Graham Percival : > Guys, > > There's been a simply German doc patch waiting for review for a few weeks: > http://code.google.com/p/lilypond/issues/detail?id=1344 > http://lists.gnu.org/archive/html/lilypond-devel/2010-09/msg00329.html > > I don't know if the change to the English docs i

Re: Doc: translations: manually update syntax (1358) (issue3092041)

Graham: here are my comments. I will not close the issue until all other languages are revised, but for German it is done. Thanks http://codereview.appspot.com/3092041/diff/1/Documentation/de/notation/fretted-strings.itely File Documentation/de/notation/fretted-strings.itely (right): http://cod

Re: Corrections and additions to NR 4.1.2, "Page formatting". (issue1710046)

On 2010/11/14 06:59:41, Mark Polesky wrote: I don't want to be a spoilsport, but I have a patch of my own that I'm pretty sure takes care of everything involved here (and more): http://codereview.appspot.com/2758042/ I have absolutely no problem with that. I just wanted some clarity about the

Re: Doc: translations: manually update syntax (1358) (issue3092041)

On 2010/11/13 17:22:44, Graham Percival wrote: Translation Meister: here's a fix for 1358. ok to push? I don't know why this issue has been hanging around for 3 week... I mean, editing .ly code and @funindex entries isn't precisely difficult! Push if you want to, but besides version strin

Re: Corrections and additions to NR 4.1.2, "Page formatting". (issue1710046)

On 2010/11/13 17:33:47, Graham Percival wrote: This patch cannot be applied to current master. Please withdraw the patch, or rewrite it to match the post-renaming spacing docs. If you opt to rewrite it, then Mark Polesky can help you. Graham, I don't want to be a spoilsport, but I have a p

Doc: NR 4.4.1: Clean up property descriptions. (issue3089042)

Reviewers: , Message: Just some clean-ups to NR 4.4.1 "Flexible vertical spacing within systems". Any objections? Okay to push? - Mark Description: Doc: NR 4.4.1: Clean up property descriptions. Please review this at http://codereview.appspot.com/3089042/ Affected files: M Documentation/no

Re: incorrect version number in convert-ly rule

On Sat, Nov 13, 2010 at 05:51:23PM -0800, Mark Polesky wrote: > Graham Percival wrote: > > The vertical space renaming uses > > @rule ((2, 13, 36)) > > > > but that should be 39. Unfortunately, simply updating > > this value in python/convert-ly might cause problems when > > previously-updated f

Re: incorrect version number in convert-ly rule

Graham Percival wrote: > The vertical space renaming uses > @rule ((2, 13, 36)) > > but that should be 39. Unfortunately, simply updating > this value in python/convert-ly might cause problems when > previously-updated files (now incorrectly tagged as .36) > try to be updated to .39 again. > > I

Fix 1382 (issue3100041)

Reviewers: carl.d.sorensen_gmail.com, Message: Here's a fix for Issue 1382. It sets the staff position to zero if staff space is zero, which is a consistent outcome -- all the staff lines are in the same position so zero works. Please review. Thanks, Carl Description: Fix 1382 Please revie

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks, Patrick. Carl http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#newcode60 ly/paper-defaults-init.ly:60: system-system-spacing = #'((space . 12) (mi

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Hi Carl, Just one tiny style nitpick below. Otherwise, looks fine. Thanks, Patrick http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/3099041/diff/6001/ly/paper-defaults-init.ly#newcode60 ly/paper-de

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

On 2010/11/13 22:38:36, Graham Percival wrote: Looks good to me, thanks Carl! I'll make .39 once this is applied, but let's wait 24 hours before pushing to give people in all time zones a chance to comment. OK, I'll wait till tomorrow night. Carl http://codereview.appspot.com/3099041/

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks, Keith. Done. Carl http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly#newcode418 ly/engraver-init.ly:418: \override VerticalAxisGroup #'nonstaff-unrelatedstaff-spacing #'pa

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Looks good to me, thanks Carl! I'll make .39 once this is applied, but let's wait 24 hours before pushing to give people in all time zones a chance to comment. http://codereview.appspot.com/3099041/ ___ lilypond-devel mailing list lilypond-devel@gnu.o

Re: Update spacing for Keith Ohara's suggested defaults (issue3099041)

Thanks Carl. I marked one (non-essential) change to make the patch equivalent to its final state after discussion at Outside of that, looks good to me. http://codereview.appspot.com/3099041/diff/1/ly/engraver-init.ly File l

Update spacing for Keith Ohara's suggested defaults (issue3099041)

Reviewers: , Message: Here's the new default spacing patch with the new names. Keith, can you check it out? THanks, Carl Description: Update spacing for Keith Ohara's suggested defaults Please review this at http://codereview.appspot.com/3099041/ Affected files: M ly/engraver-init.ly M

Re: Changes to Default spacing settings (issue3061041)

I've posted a patch with the new spacing issues to reitveld. http://codereview.appspot.com/3099041 Keith, could you please check it to make sure it's right? Thanks, Carl http://codereview.appspot.com/3061041/ ___ lilypond-devel mailing list lilypo

Re: PATCH: applied default spacing rules provided by Keith O Hara

On 11/13/10 1:24 PM, "Graham Percival" wrote: > On Sat, Nov 13, 2010 at 11:53:06AM -0800, Mark Polesky wrote: >> James Lowe wrote: Looks like it will be fairly straightforward in this case, but let me know if you want help with that process. I figure I should help you there, si

incorrect version number in convert-ly rule

The vertical space renaming uses @rule ((2, 13, 36)) but that should be 39. Unfortunately, simply updating this value in python/convert-ly might cause problems when previously-updated files (now incorrectly tagged as .36) try to be updated to .39 again. I'm willing to handle all the manual vers

Re: PATCH: applied default spacing rules provided by Keith O Hara

On Sat, Nov 13, 2010 at 11:53:06AM -0800, Mark Polesky wrote: > James Lowe wrote: > >> Looks like it will be fairly straightforward in this > >> case, but let me know if you want help with that > >> process. I figure I should help you there, since I'm > >> the one who introduced the conflicts. > >

Re: PATCH: applied default spacing rules provided by Keith O Hara

On 11/13/10 12:53 PM, "Mark Polesky" wrote: > James Lowe wrote: >>> Looks like it will be fairly straightforward in this >>> case, but let me know if you want help with that >>> process. I figure I should help you there, since I'm >>> the one who introduced the conflicts. >> >> If it's not too

RE: PATCH: applied default spacing rules provided by Keith O Hara

James Lowe wrote: >> Looks like it will be fairly straightforward in this >> case, but let me know if you want help with that >> process. I figure I should help you there, since I'm >> the one who introduced the conflicts. > > If it's not too much trouble I'd appreciate that. 1) Make sure the loc

Re: german doc patch, issue 1344

Am 13.11.2010 18:29, schrieb Graham Percival: Guys, There's been a simply German doc patch waiting for review for a few weeks: http://code.google.com/p/lilypond/issues/detail?id=1344 http://lists.gnu.org/archive/html/lilypond-devel/2010-09/msg00329.html I don't know if the change to the English

Re: GLISS list

On Sat, Nov 13, 2010 at 7:57 PM, Carl Sorensen wrote: > The GLISS list on lilynet.net is being used regularly as a spam sender.  Can > we require membership or moderation? Oh, I had no idea! Yes of course! I've just changed the moderation rules. Thanks for the heads-up! Valentin. _

Re: Add tab-tie-follow-engraver (issue2723043)

Am 13.11.2010 15:29, schrieb Carl Sorensen: On 11/13/10 3:18 AM, "Marc Hohl" wrote: Am 13.11.2010 06:21, schrieb carl.d.soren...@gmail.com: I can think of no way to simplify this code further. If you have any ideas I'd be happy to hear them. There was the idea to inclu

GLISS list

Valentin, The GLISS list on lilynet.net is being used regularly as a spam sender. Can we require membership or moderation? Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add tab-tie-follow-engraver (issue2723043)

On 11/13/10 3:23 AM, "David Kastrup" wrote: > Carl Sorensen writes: > >> On 11/13/10 2:01 AM, "David Kastrup" wrote: >> >>> carl.d.soren...@gmail.com writes: >>> >> >>> You sort the noteheads according to some criterion, and use the same >>> criterion for sorting the other data structur

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

On 11/13/10 9:17 AM, "David Santamauro" wrote: > > I want to offer to do it, but I have some intense studying to do. Is > this the correct list to ask questions about this. I'm not in > inexperienced developer, just a novice with the internals of > lilypond. I just don't want to seem burdensome.

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

Am Samstag, 13. November 2010, um 13:50:24 schrieb David Santamauro: > On Sat, 13 Nov 2010 03:12:40 -0700 > Carl Sorensen wrote: > > An easier approach might be to write an engraver [...] > Is there already a 'test' engraver that simply outputs to stdout as a > simple prototype ... more-or-less a

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

On Sat, Nov 13, 2010 at 8:17 AM, David Santamauro wrote: > > On Sat, 13 Nov 2010 07:32:06 -0700 Carl Sorensen wrote: >> >> The second state is in the form of scheme music expressions.  The job >> of the parser is to convert lilypond music expressions into scheme >> music expressions.  Most user-d

german doc patch, issue 1344

Guys, There's been a simply German doc patch waiting for review for a few weeks: http://code.google.com/p/lilypond/issues/detail?id=1344 http://lists.gnu.org/archive/html/lilypond-devel/2010-09/msg00329.html I don't know if the change to the English docs is still valid after the spacing doc rewri

Doc: translations: manually update syntax (1358) (issue3092041)

Reviewers: , Message: Translation Meister: here's a fix for 1358. ok to push? I don't know why this issue has been hanging around for 3 week... I mean, editing .ly code and @funindex entries isn't precisely difficult! Description: Doc: translations: manually update syntax (1358) Please review

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

On Sat, 13 Nov 2010 07:32:06 -0700 Carl Sorensen wrote: > >> > >> An easier approach might be to write an engraver > > > > Pardon my ignorance, but is this something like what > > articulate.ly[1] does or are you referring to some deeper, possible > > c++ level? E.g., > > > > \score { > > \

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

On 11/13/10 5:50 AM, "David Santamauro" wrote: > > > Hi Carl, > > very interesting information... > > On Sat, 13 Nov 2010 03:12:40 -0700 > Carl Sorensen wrote: > >> >> An easier approach might be to write an engraver > > Pardon my ignorance, but is this something like what articulate.l

Re: Add tab-tie-follow-engraver (issue2723043)

On 11/13/10 3:18 AM, "Marc Hohl" wrote: > Am 13.11.2010 06:21, schrieb carl.d.soren...@gmail.com: >> I can think of no way to simplify this code further. If you have any >> ideas I'd be happy to hear them. > There was the idea to include this into the Tab_note_heads_engraver, and > if it were >

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

Hi Carl, very interesting information... On Sat, 13 Nov 2010 03:12:40 -0700 Carl Sorensen wrote: > > An easier approach might be to write an engraver Pardon my ignorance, but is this something like what articulate.ly[1] does or are you referring to some deeper, possible c++ level? E.g., \sc

Re: Add tab-tie-follow-engraver (issue2723043)

Am 13.11.2010 06:21, schrieb carl.d.soren...@gmail.com: Thanks for the help on the null pointer. I was thinking that it was some *other* kind of variable than a Grob, and that I was casting it wrong. Got that all taken care of -- no scheme calls at all. On 2010/11/12 17:40:42, Neil Puttock wro

RE: PATCH: applied default spacing rules provided by Keith O Hara

Mark, -Original Message- From: Mark Polesky [mailto:markpole...@yahoo.com] Sent: Sat 11/13/2010 1:31 Looks like it will be fairly straightforward in this case, but let me know if you want help with that process. I figure I should help you there, since I'm the one who introduced the conf

Re: Add tab-tie-follow-engraver (issue2723043)

Carl Sorensen writes: > On 11/13/10 2:01 AM, "David Kastrup" wrote: > >> carl.d.soren...@gmail.com writes: >> >>> OK, so now I've eliminated the triple nested loop. >>> >>> There is what appears to me to be a required nested loop. >>> >>> One loop to loop through the note-heads. >>> Then an i

Re: Universe of syntax possibilities, ONLY to skip over non-notes/chords

On 11/12/10 7:11 AM, "Jeff Epstein" wrote: > I am writing a very-simplified LilyPond parser, just to analyze the notes, > chords and rests/silences within a particular { }-block of LY code. I want > to completely ignore all non-note (and non-chords and non-rest/silence) > elements. > > I am tryi

Re: vert. spacing: Rename properties (lily, scm). (issue3031041)

Mark, you wrote Saturday, November 13, 2010 12:50 AM I think I made every suggestion except one. I didn't change "grob" to "layout object", just because "grob" appears as a word so often in define-grob-properties.scm, and "layout" doesn't appear once: That may be so, but it's a standard ter

Re: Add tab-tie-follow-engraver (issue2723043)

On 11/13/10 2:01 AM, "David Kastrup" wrote: > carl.d.soren...@gmail.com writes: > >> OK, so now I've eliminated the triple nested loop. >> >> There is what appears to me to be a required nested loop. >> >> One loop to loop through the note-heads. >> Then an inner loop (with a break) through th

Re: Add tab-tie-follow-engraver (issue2723043)

carl.d.soren...@gmail.com writes: > OK, so now I've eliminated the triple nested loop. > > There is what appears to me to be a required nested loop. > > One loop to loop through the note-heads. > Then an inner loop (with a break) through the ties looking for a tie on > a note head. > Followed by a