Re: Modularity in lilypond

Mike Solomon writes: > Understood. Does this modularity thing seem eventually includable in > lilypond? I'm finishing a piece for October 1 and would like to be > consistent about the way that I do the coding for my graphical > notation: either it'll be done in my git repository or as a module.

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

http://codereview.appspot.com/1908041/diff/2001/3002 File mf/feta-accordion.mf (right): http://codereview.appspot.com/1908041/diff/2001/3002#newcode117 mf/feta-accordion.mf:117: fet_beginchar ("accordion register freebass", "freebass") On 2010/07/28 17:11:20, Carl wrote: I made these changes, a

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

Reviewers: carl.d.sorensen_gmail.com, Message: On 2010/07/28 17:11:20, Carl wrote: Looks good, with the exception of the version being wrong for the convert rule. Care to elaborate? I have no idea how to do this correctly, and I believe that convert-ly should somehow cater for notation manual

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

On 2010/07/29 00:28:24, Patrick McCarty wrote: On 2010/07/28 22:49:11, Ian Hulin wrote: > On 19/05/10 23:42, mailto:n.putt...@gmail.com wrote: > > > > I've tried testing your latest patch, but it fails on clip-systems.ly. > > > > `make-rhythmic-location' (defined in clip-region.scm) appears to

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

Hi Ian, On 2010/07/28 22:49:11, Ian Hulin wrote: On 19/05/10 23:42, mailto:n.putt...@gmail.com wrote: > > I've tried testing your latest patch, but it fails on clip-systems.ly. > > `make-rhythmic-location' (defined in clip-region.scm) appears to be > inaccessible from a \layout block. A new

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

Thanks Carl. I'll upload my changes shortly. -Patrick http://codereview.appspot.com/1730044/diff/35001/36003 File scm/define-stencil-commands.scm (left): http://codereview.appspot.com/1730044/diff/35001/36003#oldcode30 scm/define-stencil-commands.scm:30: connected-shape On 2010/07/28 19:08:16

Issue 1060 -- add Funk and Walker noteheads to shape notes (issue1697056)

Reviewers: , Message: I've created a patch to add Funk and Walker noteheads to the shape note capability of LilyPond. I've also updated the documentation to reflect this. Please review, Thanks, Carl Description: Issue 1060 -- add Funk and Walker noteheads to shape notes Add a series of Funk

Re: RemoveEmptyStaves and \with

Le 28 juil. 2010 à 01:50, Reinhold Kainhofer a écrit : > Am Dienstag, 27. Juli 2010, um 18:19:39 schrieb Neil Puttock: > [..] >> Why don't we move its definition to a separate file (e.g., >> `context-modifications-init.ly')? I'm sure there are other mods which >> could usefully be defined (e.g.,

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

Looks very nice! Just a few comments. Thanks, Carl http://codereview.appspot.com/1730044/diff/35001/36003 File scm/define-stencil-commands.scm (left): http://codereview.appspot.com/1730044/diff/35001/36003#oldcode30 scm/define-stencil-commands.scm:30: connected-shape Shouldn't path be in th

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

Hi all, This patchset integrates some of Mike's work in order to fix the stencil extents for paths and to combine some duplicate functionality. Thanks, Patrick http://codereview.appspot.com/1730044/show ___ lilypond-devel mailing list lilypond-devel@

[PATCH] Making partcombine more flexible

Finally, I have a score, where I really need to tweak the partcombiner (so far, I managed to not use it at all and instead use two staves...). In particular, every now and then the split list obtained in make-part- combine-music (file scm/part-combiner.scm) is not ideal and needs manual tweaking

Re: Modularity in lilypond

Understood. Does this modularity thing seem eventually includable in lilypond? I'm finishing a piece for October 1 and would like to be consistent about the way that I do the coding for my graphical notation: either it'll be done in my git repository or as a module. Obviously I'd like not to have

Re: Modularity in lilypond

On Wed, Jul 28, 2010 at 04:25:08PM +0200, Mike Solomon wrote: > In doing this, I've realized that almost everything in Lilypond can be > made modular, which is a testament to how well it is put together. David > had suggested modularity as an option before (perhaps others as well), and > there

feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041)

Looks good, with the exception of the version being wrong for the convert rule. Carl http://codereview.appspot.com/1908041/diff/2001/3002 File mf/feta-accordion.mf (right): http://codereview.appspot.com/1908041/diff/2001/3002#newcode117 mf/feta-accordion.mf:117: fet_beginchar ("accordion regi

Adding Links to User Manual in scm/define-music-types.scm

Hi Everyone, In scm/define-music-types.scm there is a comment: ;; TODO: should link back into the user manual. I'm assuming it's referring to the elements of "music-description". Where are these located? I've seen them in manuals, but I've been wading through both stable and unstable docs and I

Review: Accordion symbol name sanitization (was: Accordion push and pull symbols)

David Kastrup writes: > Carl Sorensen writes: > >> On 7/28/10 6:41 AM, "David Kastrup" wrote: >> >> PayPal, to carl_soren...@byu.edu would be very easy. > > Done. > > I am currently writing conversion rules in order to make the accordion > symbol names saner and am tearing out my hairs because

Re: Accordion push and pull symbols

Carl Sorensen writes: > On 7/28/10 6:41 AM, "David Kastrup" wrote: > > PayPal, to carl_soren...@byu.edu would be very easy. Done. I am currently writing conversion rules in order to make the accordion symbol names saner and am tearing out my hairs because scripts/aux/makelsr.py does not bother

Modularity in lilypond

Hey all, I've almost finished moving my vector-graphic package into a module that is usable by invoking one \include statement (it is in scheme code and .so files importable by guile). I decided to do this because the generation of vector graphics readable by my code uses too much kludgery to

Re: Add user-init option to include a custom init snippet (not replacing the whole init file) (issue1901042)

On 7/28/10 4:49 AM, "Ian Hulin" wrote: > Hi Reinhold, > On 28/07/10 01:43, reinhold.kainho...@gmail.com wrote: >> Reviewers: Neil Puttock, >> >> >> http://codereview.appspot.com/1901042/diff/2001/3001 >> File ly/init.ly (right): >> >> http://codereview.appspot.com/1901042/diff/2001/3001#newcod

Re: Accordion push and pull symbols

On 7/28/10 6:41 AM, "David Kastrup" wrote: > Carl Sorensen writes: > >> I have just pushed a patch containing accordion push and pull symbols. >> >> Because this modifies the font, in order to see its effects, you will need >> to do >> >> make clean && make >> >> or >> >> rm mf/out/* &&

Re: Accordion push and pull symbols

Carl Sorensen writes: > I have just pushed a patch containing accordion push and pull symbols. > > Because this modifies the font, in order to see its effects, you will need > to do > > make clean && make > > or > > rm mf/out/* && make > > in order to rebuild the font and see the new symbols. Th

Re: Add user-init option to include a custom init snippet (not replacing the whole init file) (issue1901042)

Hi Reinhold, On 28/07/10 01:43, reinhold.kainho...@gmail.com wrote: Reviewers: Neil Puttock, http://codereview.appspot.com/1901042/diff/2001/3001 File ly/init.ly (right): http://codereview.appspot.com/1901042/diff/2001/3001#newcode26 ly/init.ly:26: #(if (ly:get-option 'user-init) On 2010/07/27