Hello,
The changes found in this patch make the GUB Windows uninstallers
*much* faster. Before, uninstalling LilyPond on Windows could take up
to 10 minutes, and these changes appear to have cut that time down to
about 20 seconds.
As the commit description notes, I incorporated the recent script
Neil has approved. He mentioned some style nitpicks. I went through
looking for style nitpicks, and found two.
If we get these cleared up, then I'll push.
http://codereview.appspot.com/1345041/diff/2001/3004
File lily/include/lily-parser.hh (right):
http://codereview.appspot.com/1345041/diff
On 07/10/2010 12:16 PM, Joseph Wakeling wrote:
> In principle I can also use these to define custom cases for the notes
> c, e, f, b as well; not sure if I should, since the whole point of the
> naturalizeMusic function is to kill things like c-flats and e-sharps,
> and tonal transposition is alrea
On 07/09/2010 10:34 PM, Neil Puttock wrote:
> Sounds good to me.
So, here we go ... (faster to achieve than I expected, thanks to a
conversation with a friend who is Scheme-experienced).
I've defined a Scheme function "naturalize-limit" which can be used to
define limits for different cases, and
Reviewers: Neil Puttock,
http://codereview.appspot.com/1786041/diff/1/3
File lily/chord-tremolo-engraver.cc (right):
http://codereview.appspot.com/1786041/diff/1/3#newcode87
lily/chord-tremolo-engraver.cc:87: announce_end_grob (beam_,
previous_grob_->self_scm ());
On 2010/07/09 20:19:11, Neil P
