Neil has approved. He mentioned some style nitpicks. I went through looking for style nitpicks, and found two.
If we get these cleared up, then I'll push. http://codereview.appspot.com/1345041/diff/2001/3004 File lily/include/lily-parser.hh (right): http://codereview.appspot.com/1345041/diff/2001/3004#newcode68 lily/include/lily-parser.hh:68: void include_string (string ly_code); Should be alphabetic -- before parse_file http://codereview.appspot.com/1345041/diff/2001/3005 File lily/lexer.ll (right): http://codereview.appspot.com/1345041/diff/2001/3005#newcode371 lily/lexer.ll:371: for (size_t i = 0; i < pending_string_includes_.size(); i++) { { should be on next line, although we're not consistent in this file. But I think it's the desired structure. http://codereview.appspot.com/1345041/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
