Re: [PATCH]: Fix issue 1096

2010-05-30 Thread Benjamin Peterson
Reinhold Kainhofer kainhofer.com> schrieb: > > If so, I think a new interface, > > that would simply insert the string into the current stream would make > > more sense. > > Yes, you are probably right. However, I don't know enough of the parser > internals to implement this myself :( I've atta

Re: woodwind diagrams in lilypond (http://codereview.appspot.com/1385041)

2010-05-30 Thread Neil Puttock
On 30 May 2010 21:52, Neil Puttock wrote: > I'll post some comments on Rietveld once I've had a closer look. Hmm, I have 16 draft comments, but it won't let me publish them (server error). I think you might need to upload a new issue to Rietveld if this continues. Thanks, Neil ___

Re: Text cresc *without dashed line* and Y-offset

2010-05-30 Thread Neil Puttock
On 28 May 2010 17:48, Xavier Scheuer wrote: > Shouldn't we open an issue about this on the tracker, at least to > keep track on this discussion and your very interesting proposal? I should have a patch sorted later, so there's no need to log this on the tracker. Once I've refreshed the (approve

Re: Add independent control of thickness and offset for underline markup (issue1347041)

2010-05-30 Thread n . puttock
On 2010/05/29 16:10:16, kieren_macmillan_sympatico.ca wrote: I tried #:properties ((thickness 1)) and it failed. Sorry, I meant remove the default value, but keep `offset' in the properties list, i.e., #:properties ((thickness 1) (offset)) This way it's bound to #f if the user hasn't over

Re: woodwind diagrams in lilypond (http://codereview.appspot.com/1385041)

2010-05-30 Thread Neil Puttock
On 28 May 2010 07:45, Mike Solomon wrote: >    At http://codereview.appspot.com/1385041, you will find a patch that > implements several woodwind diagrams (piccolo, flute, oboe, clarinet, bass > clarinet, saxophone, bassoon, and contrabassoon) in Lilypond.  I would very > much appreciate any and