Re: [PATCH] Use iterator for STL std::map element access.

2010-03-28 Thread Han-Wen Nienhuys
On Sun, Mar 28, 2010 at 8:54 PM, Patrick McCarty wrote: > Hi, > > Please review this patch: > > http://codereview.appspot.com/819041/show > > I'm hoping this will fix Carl's compile failure: > http://lists.gnu.org/archive/html/lilypond-devel/2010-03/msg00389.html > > Is this the correct way to ret

Re: Make failure from new git repo

2010-03-28 Thread Carl Sorensen
On 3/28/10 5:47 PM, "Patrick McCarty" wrote: > > I'm still in foreign territory here, but I have a possible solution > for your problem. Can you test the attached patch instead of the one > I send to you earlier? > > I just posted a patch to Rietveld as well: > http://codereview.appspot.com/8

[PATCH] Use iterator for STL std::map element access.

2010-03-28 Thread Patrick McCarty
Hi, Please review this patch: http://codereview.appspot.com/819041/show I'm hoping this will fix Carl's compile failure: http://lists.gnu.org/archive/html/lilypond-devel/2010-03/msg00389.html Is this the correct way to return an element from a map? Thanks, Patrick ___

Re: Make failure from new git repo

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 10:12 AM, Patrick McCarty wrote: > On 2010-03-28, Carl Sorensen wrote: >> >> Perhaps we have different versions of gcc.  I'm using the following: >> >> sorensen2:~ Carl$ gcc --version >> i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493) > > Yes, we do have di

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 1:12 PM, Jan Nieuwenhuizen wrote: > Op zondag 28-03-2010 om 13:09 uur [tijdzone -0700], schreef Patrick > McCarty: >> >> It appears that only one duplicate commit exists in these situations. > > Does the old archive also have the duplicated commit? I don't know, and I can'

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Jan Nieuwenhuizen
Op zondag 28-03-2010 om 22:12 uur [tijdzone +0200], schreef Jan Nieuwenhuizen: > Op zondag 28-03-2010 om 13:09 uur [tijdzone -0700], schreef Patrick > McCarty: > > On Sun, Mar 28, 2010 at 1:00 PM, Patrick McCarty wrote: > > > On Sun, Mar 28, 2010 at 12:33 PM, Patrick McCarty > > > wrote: > > > >

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Jan Nieuwenhuizen
Op zondag 28-03-2010 om 13:09 uur [tijdzone -0700], schreef Patrick McCarty: > On Sun, Mar 28, 2010 at 1:00 PM, Patrick McCarty wrote: > > On Sun, Mar 28, 2010 at 12:33 PM, Patrick McCarty wrote: > > I'm wrong. Please disregard this last comment. > > It appears that only one duplicate commit ex

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Graham Percival
On Sun, Mar 28, 2010 at 01:00:02PM -0700, Patrick McCarty wrote: > On Sun, Mar 28, 2010 at 12:33 PM, Patrick McCarty wrote: > > > > In the overall repo, I'm find some duplicate commits.  For example, > > have a look at the shortlog for the "release/2.1.3" commit: > > > > http://git.savannah.gnu.or

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 1:00 PM, Patrick McCarty wrote: > On Sun, Mar 28, 2010 at 12:33 PM, Patrick McCarty wrote: >> >> In the overall repo, I'm find some duplicate commits.  For example, >> have a look at the shortlog for the "release/2.1.3" commit: >> >> http://git.savannah.gnu.org/gitweb/?p=l

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 12:33 PM, Patrick McCarty wrote: > > In the overall repo, I'm find some duplicate commits.  For example, > have a look at the shortlog for the "release/2.1.3" commit: > > http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=shortlog;h=refs/tags/release/2.1.3 Hmm, interesti

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 11:45 AM, Jan Nieuwenhuizen wrote: > Op zondag 28-03-2010 om 01:13 uur [tijdzone -0700], schreef Patrick > McCarty: > >> Great, that's a better solution anyway.  I'll have a look at the new >> repo tomorrow (well, later today) when I get the chance. > > The new repo is up.

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Jan Nieuwenhuizen
Op zondag 28-03-2010 om 01:13 uur [tijdzone -0700], schreef Patrick McCarty: > Great, that's a better solution anyway. I'll have a look at the new > repo tomorrow (well, later today) when I get the chance. The new repo is up. I would appreciate a few checks, all past checks now pass and all con

Re: Make failure from new git repo

2010-03-28 Thread Patrick McCarty
On 2010-03-28, Carl Sorensen wrote: > > On 3/27/10 11:56 PM, "Patrick McCarty" wrote: > > > On Sat, Mar 27, 2010 at 6:53 PM, Carl Sorensen wrote: > > > >> open-type-font.cc: In member function 'virtual size_t > >> Open_type_font::index_to_charcode(size_t) const': > >> open-type-font.cc:244: er

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Francisco Vila
2010/3/28 Jan Nieuwenhuizen : > Thanks, I just wrote something very similar, fyi see attached.  The > commit/tag date problem is now fixed, but I intend to upload yet > another, final repo ~1500 CET this afternoon. I am sorry but I'm bot to be available to check this until Thu april 1st -- Franci

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 1:07 AM, Jan Nieuwenhuizen wrote: > Op zondag 28-03-2010 om 01:04 uur [tijdzone -0700], schreef Patrick > McCarty: >> On Sun, Mar 28, 2010 at 12:43 AM, Patrick McCarty wrote: >> > On Sun, Mar 28, 2010 at 12:36 AM, Jan Nieuwenhuizen >> > wrote: >> >> Op zaterdag 27-03-2010

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Jan Nieuwenhuizen
Op zondag 28-03-2010 om 01:04 uur [tijdzone -0700], schreef Patrick McCarty: > On Sun, Mar 28, 2010 at 12:43 AM, Patrick McCarty wrote: > > On Sun, Mar 28, 2010 at 12:36 AM, Jan Nieuwenhuizen > > wrote: > >> Op zaterdag 27-03-2010 om 14:43 uur [tijdzone -0700], schreef Patrick > >> McCarty: > Th

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 12:43 AM, Patrick McCarty wrote: > On Sun, Mar 28, 2010 at 12:36 AM, Jan Nieuwenhuizen > wrote: >> Op zaterdag 27-03-2010 om 14:43 uur [tijdzone -0700], schreef Patrick >> McCarty: >> >>> author     Han-Wen Nienhuys >>>            Tue, 26 Mar 2002 23:27:21 + (00:27 +0

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Patrick McCarty
On Sun, Mar 28, 2010 at 12:36 AM, Jan Nieuwenhuizen wrote: > Op zaterdag 27-03-2010 om 14:43 uur [tijdzone -0700], schreef Patrick > McCarty: >> On Sat, Mar 27, 2010 at 3:14 AM, Jan Nieuwenhuizen >> wrote: >> > Op zaterdag 27-03-2010 om 09:51 uur [tijdzone +0100], schreef Francisco >> > Vila: > >

Re: hold your horses, new repo #3 ETA 1500 CET [WAS]: new Git stats

2010-03-28 Thread Jan Nieuwenhuizen
Op zaterdag 27-03-2010 om 14:43 uur [tijdzone -0700], schreef Patrick McCarty: > On Sat, Mar 27, 2010 at 3:14 AM, Jan Nieuwenhuizen > wrote: > > Op zaterdag 27-03-2010 om 09:51 uur [tijdzone +0100], schreef Francisco > > Vila: > author Han-Wen Nienhuys >Tue, 26 Mar 2002 23:27:21