Reviewers: hanwenn,
Message:
On 2009/08/20 03:12:26, hanwenn wrote:
http://codereview.appspot.com/110047/diff/1/11
File scm/output-lib.scm (right):
http://codereview.appspot.com/110047/diff/1/11#newcode778
Line 778: (ly:grob-suicide! grob)
this does not make sense. did you forget to check th
http://codereview.appspot.com/109051/diff/1/5
File lily/output-def.cc (right):
http://codereview.appspot.com/109051/diff/1/5#newcode146
Line 146: if (scm_paper_width != SCM_UNDEFINED
On 2009/08/20 12:54:08, Carl wrote:
I'd prefer to see this and all of your checks for SCM_UNDEFINED) be
written
Hi Jan,
I'm getting a build failure at the compile stage for gzip which is
caused by a naming conflict with glibc's futimens () function:
In file included from ./sys/stat.h:27,
from ./fcntl.h:26,
from
/home/neil/gub/target/tools/src/gzip-1.3.12/lib/utimens.c:29:
I'm trying to complete the 'prob' entry in the Technical glossary.
From a position of ignorance I've come up with this:
"PRoperty OBjects, or @strong{probs} for short, are instances of
the @code{Prob} class, a simple base class for objects which have
mutable and immutable property alists. The
2009/8/20 Michael Käppler :
> 1. Can someone run the regression test suite for me?
Sure, see the attached results.
The only issue is the number of `systems run off the page' warnings,
which appear to be associated with tests using A6 paper size.
However, there are two problems which only show u
2009/8/20 Mark Polesky :
> Okay to push?
LGTM.
+ english.ly -- common English names for notes
It's stretching it a bit to claim these are common, unlike the names
in other languages.
Regards,
Neil
___
lilypond-devel mailing list
lilypond-devel@g
Okay to push?
- Mark
From 2c66e3da46201b89bd841f9a9c9df7ba302a71e0 Mon Sep 17 00:00:00 2001
From: Mark Polesky
Date: Thu, 20 Aug 2009 13:11:36 -0700
Subject: [PATCH] Organize pitchname files.
---
ly/catalan.ly| 32 ++--
ly/deutsch.ly| 34
On 2009-08-20, Mark Polesky wrote:
> Okay to push?
LGTM.
By the way, the original version of this file, pushed in 2001, had
these two lines at the top:
\version "1.3.146"
% JUNKME.
:-)
-Patrick
___
lilypond-devel mailing list
lilypond-devel@gnu
Okay to push?
- Mark
From d92c2514df04fdf63df1c747bac86f5599415e17 Mon Sep 17 00:00:00 2001
From: Mark Polesky
Date: Thu, 20 Aug 2009 09:49:37 -0700
Subject: [PATCH] Remove params-init.ly.
---
ly/engraver-init.ly | 10 --
ly/params-init.ly |2 --
Michael Käppler schrieb:
More in a few hours.
I won't be able to check my mail during the next week so don't expect
me to reply until then.
Anyway, I want to ask you some things before I leave.
1. Can someone run the regression test suite for me? I ask because
I've never done this and my c
More in a few hours.
I won't be able to check my mail during the next week so don't expect me
to reply until then.
Anyway, I want to ask you some things before I leave.
1. Can someone run the regression test suite for me? I ask because I've
never done this and my computer is extremely slow,
dear list,
quite often i am running into a situation like
<> c4^"longish playing indication ma non
troppo" d2.
so that if the bar, which would only take little space with its only two
notes, appears towards the end of a line, the text line will run off the
right end of the staff, and of
Hi Carl,
LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think
there's less chance of confusion when testing for "undefined" rather
than "not undefined", which is "defined". The double negative (not
undefined) can potentially be confusing.
that's a good point. However, I'm goi
Mark Polesky wrote Thursday, August 20, 2009 8:59 AM
I made an attempt at cleaning up property-init.ly. I
included my revised file (not a patch) Mostly I'm
curious to know if there's anything I'm doing here
that goes against coding conventions or anything like
that. Or if I'm making things wors
LGTM. I do have one comment about tests for != SCM_UNDEFINED. It think
there's less chance of confusion when testing for "undefined" rather
than "not undefined", which is "defined". The double negative (not
undefined) can potentially be confusing.
But this is just my opinion, and you can feel
Patrick McCarty schrieb:
On 2009-08-20, Marc Hohl wrote:
Hello,
is there a description of Slur #'details? I googled for some of the
parameters and did a git grep, but I didn't find
anything which would explain the meaning of these parameters:
((region-size . 4) (head-encompass-penalty . 100
Hi all,
it took me quite a while but here is a new approach for review:
http://codereview.appspot.com/109051
More in a few hours.
Cheers,
Michael
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-de
Hello again!
I made an attempt at cleaning up property-init.ly. I
included my revised file (not a patch) Mostly I'm
curious to know if there's anything I'm doing here
that goes against coding conventions or anything like
that. Or if I'm making things worse in some way.
Thanks.
- Mark
% p
On 2009-08-20, Marc Hohl wrote:
> Hello,
>
> is there a description of Slur #'details? I googled for some of the
> parameters and did a git grep, but I didn't find
> anything which would explain the meaning of these parameters:
>
> ((region-size . 4) (head-encompass-penalty . 1000.0)
> (stem-enco
Hello,
is there a description of Slur #'details? I googled for some of the
parameters and did a git grep, but I didn't find
anything which would explain the meaning of these parameters:
((region-size . 4) (head-encompass-penalty . 1000.0)
(stem-encompass-penalty . 30.0) (closeness-factor . 10
20 matches
Mail list logo
