[PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Peter Rosin
* tests/runpath-in-lalib.at: Make sure shared libraries are created on Windows by passing -no-undefined. Otherwise libb.la fails to record a dependency on liba.la, and the final link of the program then fails with undefined symbols. Signed-off-by: Peter Rosin --- tests/runpath-in-lalib.at |1

[PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Peter Rosin
* tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic "flag", but never applies it to static libraries. Cater for this and skip if no "real" pic flag is in use. Signed-off-by: Peter Rosin --- tests/with-pic.at | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) Ok

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Gary V. Vaughan
Hi Peter, On 19 ก.ย. 2012, at 15:56, Peter Rosin wrote: > * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic > "flag", but never applies it to static libraries. Cater for this > and skip if no "real" pic flag is in use. > [[...]] > > Ok to push? Yes, with nit below addressed. Th

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Peter Rosin
On 2012-09-19 09:31, Peter Rosin wrote: > * tests/runpath-in-lalib.at: Make sure shared libraries are created > on Windows by passing -no-undefined. Otherwise libb.la fails to record > a dependency on liba.la, and the final link of the program then fails > with undefined symbols. > > Signed-off-by

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Peter Rosin
On 2012-09-19 11:20, Gary V. Vaughan wrote: > Hi Peter, > > On 19 ก.ย. 2012, at 15:56, Peter Rosin wrote: > >> * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic >> "flag", but never applies it to static libraries. Cater for this >> and skip if no "real" pic flag is in use. >> [[.

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Peter Rosin
On 2012-09-19 11:26, Peter Rosin wrote: > On 2012-09-19 09:31, Peter Rosin wrote: >> * tests/runpath-in-lalib.at: Make sure shared libraries are created >> on Windows by passing -no-undefined. Otherwise libb.la fails to record >> a dependency on liba.la, and the final link of the program then fails

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Gary V. Vaughan
Hi Peter, My bad, I'm embarrassed to say. I started to write a script to make the appropriate changes, but ended up doing it manually rather than adding more and more corner cases to the throwaway script... a poor choice in hindsight :-( On 19 ก.ย. 2012, at 19:27, Peter Rosin wrote: > On 2012-

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Peter Rosin
On 2012-09-19 16:20, Gary V. Vaughan wrote: > Hi Peter, > > My bad, I'm embarrassed to say. I started to write a script to make the > appropriate changes, but ended up doing it manually rather than adding > more and more corner cases to the throwaway script... a poor choice in > hindsight :-( It'

Re: [PATCH] tests: don't feed -no-undefined to the linker during, configure.

2012-09-19 Thread Roumen Petrov
Peter Rosin wrote: * tests/deplibs-mingw.at: Restore LDFLAGS for the configure run so that the linker does not see -no-undefined. Makes the test pass instead of skip on MinGW. Signed-off-by: Peter Rosin --- tests/deplibs-mingw.at |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Roumen Petrov
Peter Rosin wrote: On 2012-09-19 09:31, Peter Rosin wrote: * tests/runpath-in-lalib.at: Make sure shared libraries are created on Windows by passing -no-undefined. Otherwise libb.la fails to record a dependency on liba.la, and the final link of the program then fails with undefined symbols. Sig

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Roumen Petrov
Peter Rosin wrote: * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic "flag", but never applies it to static libraries. Cater for this and skip if no "real" pic flag is in use. I'm not sure that this test is suitable for mingw host. Signed-off-by: Peter Rosin --- tests/with-

Re: [PATCH] tests: don't feed -no-undefined to the linker during, configure.

2012-09-19 Thread Peter Rosin
On 2012-09-19 21:25, Roumen Petrov wrote: > Peter Rosin wrote: >> * tests/deplibs-mingw.at: Restore LDFLAGS for the configure run so that >> the linker does not see -no-undefined. Makes the test pass instead of >> skip on MinGW. >> >> Signed-off-by: Peter Rosin >> --- >> tests/deplibs-mingw.at |

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Peter Rosin
On 2012-09-19 21:43, Roumen Petrov wrote: > Peter Rosin wrote: >> * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic >> "flag", but never applies it to static libraries. Cater for this >> and skip if no "real" pic flag is in use. > I'm not sure that this test is suitable for mingw ho

Re: [PATCH] tests: feed -no-undefined when linking libtool libraries

2012-09-19 Thread Peter Rosin
On 2012-09-19 21:32, Roumen Petrov wrote: > Peter Rosin wrote: >> On 2012-09-19 09:31, Peter Rosin wrote: >>> * tests/runpath-in-lalib.at: Make sure shared libraries are created >>> on Windows by passing -no-undefined. Otherwise libb.la fails to record >>> a dependency on liba.la, and the final lin

Re: [PATCH] tests: don't feed -no-undefined to the linker during, configure.

2012-09-19 Thread Roumen Petrov
Peter Rosin wrote: On 2012-09-19 21:25, Roumen Petrov wrote: Peter Rosin wrote: * tests/deplibs-mingw.at: Restore LDFLAGS for the configure run so that the linker does not see -no-undefined. Makes the test pass instead of skip on MinGW. Signed-off-by: Peter Rosin --- tests/deplibs-mingw.at

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Roumen Petrov
Peter Rosin wrote: On 2012-09-19 21:43, Roumen Petrov wrote: Peter Rosin wrote: * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic "flag", but never applies it to static libraries. Cater for this and skip if no "real" pic flag is in use. I'm not sure that this test is suitable f

Re: [PATCH] tests: skip with-pic test when no "real" pic flag is used.

2012-09-19 Thread Peter Rosin
On 2012-09-19 23:02, Roumen Petrov wrote: > Peter Rosin wrote: >> On 2012-09-19 21:43, Roumen Petrov wrote: >>> Peter Rosin wrote: * tests/with-pic.at: Windows uses "-DDLL_EXPORT -DPIC" as the pic "flag", but never applies it to static libraries. Cater for this and skip if no "real"