[0/2] sh.test adjustments

2010-09-17 Thread Peter Rosin
Hi! Since I tripped up and made sh.test fail, to repent I'd thought I'd move the test to the new testsuite. But then I noticed a bug, so it turned into a two patch series... Ok to push? Cheers, Peter

[PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'.

2010-09-17 Thread Peter Rosin
>From 75358282c6674d399e76c42eb456ed20b73c358a Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Fri, 17 Sep 2010 12:15:00 +0200 Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'. Signed-off-by: Peter Rosin --- ChangeLog |4 tests/sh.test |6 +++--

[PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-17 Thread Peter Rosin
>From c6195aeb806270200950a86cda955ca674e680f1 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Fri, 17 Sep 2010 12:28:51 +0200 Subject: [PATCH 2/2] Move portable shell tests from the old to the new testsuite. * tests/sh.test: Move this... * tests/sh.at: ...to here, and adjust to the new testsui

[PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Peter Rosin
Hi! I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code with MSVC. I'd like this one to go in before the release. Ok to push? Cheers, Peter >From 0114c5a834fb1ce8e8324ff6d7c0bb782139c3c7 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Fri, 17 Sep 2010 16:15:04 +0200 Subject:

[PATCH] Fix order of PATH manipulation in cwrapper and shwrapper

2010-09-17 Thread Charles Wilson
* libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call lt_update_exe_path before lt_update_lib_path, to ensure that the temporary rpath values (which include the OBJDIRs of uninstalled libtool libraries) precede installation and final -rpath directories. (func_emit_wrapper): Prepend $d

[PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Charles Wilson
* doc/libtool.texi (libtool script contents:to_host_file_cmd): Document variable. (libtool script contents:to_tool_file_cmd): Prefer `build platform' to `build system'; Ditto `host platform'. --- As promised here: http://lists.gnu.org/archive/html/libtool-patches/2010-09/msg00191.html OK to push?

Re: [PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Ralf Wildenhues
let the review sprint begin ... Hi Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 04:18:55PM CEST: > I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code > with MSVC. > > I'd like this one to go in before the release. > > Ok to push? OK, thanks. Testsuite exposure would be n

Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'.

2010-09-17 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:07PM CEST: > Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = > ...'. OK, but I find the log entry not really explaining the change. How about this instead? tests: actually detect missing 'test' in 'if "$foo" = ...'

Re: [PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Charles Wilson
On 9/17/2010 12:53 PM, Ralf Wildenhues wrote: > let the review sprint begin ... Meh -- no more patches from me in the near term. I promised two small patches yesterday, delivered today. Whether they are reviewed and pushed before the release or not doesn't matter that much. -- Chuck

Re: [PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-17 Thread Ralf Wildenhues
Hi Peter, * Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:30PM CEST: > Subject: [PATCH 2/2] Move portable shell tests from the old to the new > testsuite. > > * tests/sh.test: Move this... > * tests/sh.at: ...to here, and adjust to the new testsuite. > * Makefile.am: Update. > --- a/Makefile.

Re: [PATCH 2/2] Move portable shell tests from the old to the new testsuite.

2010-09-17 Thread Charles Wilson
On 9/17/2010 1:23 PM, Ralf Wildenhues wrote: > And since IIRC > Gary wanted to do the release this weekend, I wonder whether this isn't > more safely pushed to after the relase. WDYT? FWIW, I agree that this patch should be postponed until after the release. I'm agnostic on whether tests -- such

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Ralf Wildenhues
Hi Charles, * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:28:46PM CEST: > * doc/libtool.texi (libtool script contents:to_host_file_cmd): Document > variable. > (libtool script contents:to_tool_file_cmd): Prefer `build platform' > to `build system'; Ditto `host platform'. > OK to push? OK. W

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Charles Wilson
On 9/17/2010 1:30 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:28:46PM CEST: >> OK to push? > > OK. Why the s/system/platform/ changes though? I see that > libtool.texi uses platform a lot, and also uses system quite a bit but > not quite as often. Other GNU d

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Sep 17, 2010 at 07:37:23PM CEST: > On 9/17/2010 1:30 PM, Ralf Wildenhues wrote: > > OK. Why the s/system/platform/ changes though? I see that > > libtool.texi uses platform a lot, and also uses system quite a bit but > > not quite as often. Other GNU documentation

Re: [PATCH] Document libtool variable to_host_file_cmd.

2010-09-17 Thread Charles Wilson
On 9/17/2010 1:30 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:28:46PM CEST: >> OK to push? > > OK. Pushed. -- Chuck

Re: [PATCH] Fix order of PATH manipulation in cwrapper and shwrapper

2010-09-17 Thread Ralf Wildenhues
* Charles Wilson wrote on Fri, Sep 17, 2010 at 06:23:28PM CEST: > * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call > lt_update_exe_path before lt_update_lib_path, to ensure that the > temporary rpath values (which include the OBJDIRs of uninstalled > libtool libraries) precede in

Re: [PATCH] Fix order of PATH manipulation in cwrapper and shwrapper

2010-09-17 Thread Charles Wilson
On 9/17/2010 2:12 PM, Ralf Wildenhues wrote: > * Charles Wilson wrote on Fri, Sep 17, 2010 at 06:23:28PM CEST: >> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call >> lt_update_exe_path before lt_update_lib_path, to ensure that the >> temporary rpath values (which include the OBJD

LTO: consistently accept -fwhopr* and -flto* for GCC.

2010-09-17 Thread Ralf Wildenhues
We were inconsistent in matching flags matching -flto?* or -fwhopr?* (in glob notation); GCC has more flags matching either. It seems fairly safe to allow all of these through. On the other hand, from looking at the semantics it seems like the right thing to _not_ allow through -fwhole-program fo

Re: [PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.

2010-09-17 Thread Peter Rosin
Den 2010-09-17 18:53 skrev Ralf Wildenhues: > let the review sprint begin ... Sorry for the late patches... > Hi Peter, > > * Peter Rosin wrote on Fri, Sep 17, 2010 at 04:18:55PM CEST: >> I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code >> with MSVC. >> >> I'd like this one to

Re: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = ...'.

2010-09-17 Thread Peter Rosin
Den 2010-09-17 19:06 skrev Ralf Wildenhues: > * Peter Rosin wrote on Fri, Sep 17, 2010 at 12:37:07PM CEST: >> Subject: [PATCH 1/2] * tests/sh.test: Detect missing 'test' in 'if "$foo" = >> ...'. > > OK, but I find the log entry not really explaining the change. > How about this instead? > >

Re: w32 pending?

2010-09-17 Thread Roumen Petrov
Ralf Wildenhues wrote: Hi Charles, * Charles Wilson wrote on Thu, Sep 16, 2010 at 08:47:52PM CEST: [cygwin|mingw] Fix order of PATH manipulation in cwrapper * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:main): Call lt_update_exe_path before lt_update_lib_path, to ensure that the loca

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-17 Thread Roumen Petrov
Hi Peter, Peter Rosin wrote: Hi! need_lib_prefix.at currently fails with MSVC. Hmm probably test fail as shared library is build without -no-undefined flag. Did libtool MSC allow creation of shared libraries without -no-undefined ? On windows platforms (msc, gcc(mingw*)) may be the test

Re: [PATCH] maint: improve README instructions for fetching latest version.

2010-09-17 Thread Gary V. Vaughan
On 17 Sep 2010, at 00:24, Ralf Wildenhues wrote: > Hi Gary, Hallo Ralf, > * Gary V. Vaughan wrote on Thu, Sep 16, 2010 at 04:49:47AM CEST: >> * README, README-alpha (Obtaining the Latest Sources): New >> section, describing use of savannah repositories and bootstrap. >> * README.alpha (Reporting

README cleanups

2010-09-17 Thread Gary V. Vaughan
With the recent additions I made to README, I noticed that we're maintaining a lot of duplicated redundant information, and also that README and README.alpha have needlessly drifted apart, effectively hiding useful information from users of our alpha and stable release tarballs. All but the last p

[PATCH 3/6] maint: improve `Reporting Bugs' in README and README.alpha.

2010-09-17 Thread Gary V. Vaughan
* README (Reporting Bugs): Rewritten to a more complete and concise guide to providing a good bug report. * README.alpha (Reporting Bugs): Adjust to match. --- ChangeLog|5 + README | 36 +++- README.alpha | 44 ++---

[PATCH 2/6] maint: consolidate Introductions of README and README.alpha.

2010-09-17 Thread Gary V. Vaughan
* README (Introduction): Rewritten to a more logical order for first time users, incorporating some additional text that was previously only in README.alpha. * README.alpha (Introduction): Adjust to match. --- ChangeLog|6 ++ README | 30 -- README.a

[PATCH 4/6] maint: reformat README `The Test Suites' for consistency.

2010-09-17 Thread Gary V. Vaughan
* README (The Test Suites): Reformatted for consistency. * README.alpha (The Test Suites): Adjust to match. --- ChangeLog|4 README | 38 -- README.alpha | 39 +-- 3 files changed, 49 insertions(+), 32 d

[PATCH 5/6] maint: improve README's `Obtaining the Latest Sources'.

2010-09-17 Thread Gary V. Vaughan
* README (Obtaining the Latest Sources): Add instructions for obtaining stable, alpha and nightly snapshot tarballs. * README.alpha (Obtaining the Latest Sources): Adjust to match. --- ChangeLog|5 + README | 56 +++- README.a

[PATCH 6/6] maint: use sed instead of maintaining 2 README files.

2010-09-17 Thread Gary V. Vaughan
* README.alpha: Deleted. It was mostly identical to README. * libltdl/config/edit-readme-alpha: New script to edit the contents of README in the dist tree prior to tarring up. * Makefile.am (dist-hook): Run it before rolling alpha release tarball. --- ChangeLog|7 + Ma

[PATCH 1/6] maint: copy the Version Numbering section into README.alpha.

2010-09-17 Thread Gary V. Vaughan
* README.alpha (Version Numbering): No less useful for users of alpha releases. Copied from README. --- ChangeLog|6 ++ README.alpha | 56 2 files changed, 62 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog i

Re: README cleanups

2010-09-17 Thread Ralf Wildenhues
Hi Gary, * Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:12AM CEST: > Okay to push? I'm fine with this patch series. Thanks. A minor nit: users don't really need GNU make to build Libtool from a release tarball unless they want to do VPATH builds. This was stated before your patch though

Re: [PATCH 6/6] maint: use sed instead of maintaining 2 README files.

2010-09-17 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Sat, Sep 18, 2010 at 07:20:18AM CEST: > * README.alpha: Deleted. It was mostly identical to README. > * libltdl/config/edit-readme-alpha: New script to edit the > contents of README in the dist tree prior to tarring up. > * Makefile.am (dist-hook): Run it before rolling

Re: [PATCH] Skip need_lib_prefix.at on systems without lib prefix on libraries.

2010-09-17 Thread Peter Rosin
Den 2010-09-18 00:04 skrev Roumen Petrov: > Hi Peter, > > Peter Rosin wrote: >> Hi! >> >> need_lib_prefix.at currently fails with MSVC. > > Hmm probably test fail as shared library is build without -no-undefined flag. > > Did libtool MSC allow creation of shared libraries without -no-undefined