let the review sprint begin ... Hi Peter,
* Peter Rosin wrote on Fri, Sep 17, 2010 at 04:18:55PM CEST: > I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code > with MSVC. > > I'd like this one to go in before the release. > > Ok to push? OK, thanks. Testsuite exposure would be nice at some point. In this macro, there are 4 cases, with the first criterion being decided at autoconf time, the second at configure time: 1) $1 = CXX $CXX = yes 2) $1 = CXX $CXX != yes 3) $1 != CXX $GCC = yes 4) $1 != CXX $GCC != yes your code fixes case (2). After the change, the mingw bits of the cases (1) and (2) both superfluously compare $1 to GCJ; that is not needed, because $1 is CXX. You may simplify both cases accordingly. Thanks, Ralf > Subject: [PATCH] Copy over DLL_EXPORT handling from C to C++ for non-GCC on > w32. > > * libltdl/m4/libtool.m4 (_LT_COMPILER_PIC) [mingw, cygwin, os2] > [pw32, cegcc]: Copy over the DLL_EXPORT handling from C to C++. > --- a/libltdl/m4/libtool.m4 > +++ b/libltdl/m4/libtool.m4 > @@ -3873,6 +3873,12 @@ m4_if([$1], [CXX], [ see here: ^^^^^^^^^^^^^^^^^ > ;; > esac > ;; > + mingw* | cygwin* | os2* | pw32* | cegcc*) > + # This hack is so that the source file can tell whether it is being > + # built for inclusion in a dll (and should export symbols for example). > + m4_if([$1], [GCJ], [], > + [_LT_TAGVAR(lt_prog_compiler_pic, $1)='-DDLL_EXPORT']) > + ;; > dgux*) > case $cc_basename in > ec++*)
