Re: 350-gary-maintain-private-libobj-namespace

2008-05-19 Thread Eric Blake
Eric Blake byu.net> writes: > |> * libltdl/m4/ltdl.m4 (_LT_LIBSOURCES): Delete. > |> (LTDL_INIT): Ignore arguments to AC_LIBSOURCES during _LTDL_SETUP, > |> on the assumption that libtoolize correctly installed them. > | > | > | Looks good to me. Please apply. > > Applied. Bah. I had tested w

Re: 350-gary-maintain-private-libobj-namespace

2008-05-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Gary V. Vaughan on 5/16/2008 11:07 AM: |> Subject: [PATCH] Kill _LT_LIBSOURCES; it wasn't checking anything useful. |> |> * libltdl/m4/ltdl.m4 (_LT_LIBSOURCES): Delete. |> (LTDL_INIT): Ignore arguments to AC_LIBSOURCES during _LTDL_SETUP,

Re: 350-gary-maintain-private-libobj-namespace

2008-05-16 Thread Gary V. Vaughan
Hi Eric, On 13 May 2008, at 18:47, Eric Blake wrote: So how about this patch? From 5160f84d0c1d00883b0db3336d79863286e8e89a Mon Sep 17 00:00:00 2001 From: Eric Blake <[EMAIL PROTECTED]> Date: Tue, 13 May 2008 16:45:29 -0600 Subject: [PATCH] Kill _LT_LIBSOURCES; it wasn't checking anything use

Re: 350-gary-maintain-private-libobj-namespace

2008-05-13 Thread Eric Blake
Eric Blake byu.net> writes: > > Gnulib was able to get away with an autoconf-time check because it _generates_ > the .m4 file that contains the replacement *_LIBSOURCES definition, and > substitutes the correct directory name in during that generation. And with my > proposed patch to gnuli

Re: 350-gary-maintain-private-libobj-namespace

2008-05-13 Thread Eric Blake
Gary V. Vaughan gnu.org> writes: > >> + > >> +# Like AC_LIBSOURCES, except the directory where the source file is > >> +# expected is separated from the user LIBOBJ directory. > >> +AC_DEFUN([_LT_LIBSOURCES], [ > >> + m4_foreach([_LTNAME], [$1], [ > >> +m4_syscmd([test -r libltdl/]_LTN

FYI: 350-gary-maintain-private-libobj-namespace

2008-01-31 Thread Gary V. Vaughan
Applied to HEAD. Index: ChangeLog from Gary V. Vaughan <[EMAIL PROTECTED]> Unfortunately, the autoconf implementation of AC_LIBOBJ and friends requires all libobjs to be in the same directory, as declared by AC_CONFIG_LIBOBJ_DIR. That might prevent using e

Re: 350-gary-maintain-private-libobj-namespace

2008-01-30 Thread Gary V. Vaughan
Hallo Ralf (and other potential reviewers!) On 30 Jan 2008, at 22:00, Gary V. Vaughan wrote: Maybe Mail.app will co-operate if I use a '.txt' extension for the patch attachments? Let me know if this is better. If not, I'll post with mailnotify, and put up with the broken message threading.

Re: 350-gary-maintain-private-libobj-namespace

2008-01-30 Thread Gary V. Vaughan
Hallo Ralf, [Repost with correct Cc: apologies] On 30 Jan 2008, at 14:43, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Tue, Jan 29, 2008 at 08:44:51AM CET: On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote: I haven't reviewed your last two pending patches yet (but I'm not telling you to w

Re: 350-gary-maintain-private-libobj-namespace

2008-01-30 Thread Gary V. Vaughan
Hallo Ralf, On 30 Jan 2008, at 14:43, Ralf Wildenhues wrote: * Gary V. Vaughan wrote on Tue, Jan 29, 2008 at 08:44:51AM CET: On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote: I haven't reviewed your last two pending patches yet (but I'm not telling you to wait for me). Every little helps, ev

Re: 350-gary-maintain-private-libobj-namespace

2008-01-29 Thread Ralf Wildenhues
* Gary V. Vaughan wrote on Tue, Jan 29, 2008 at 08:44:51AM CET: > On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote: > >> I haven't reviewed your last two pending patches yet (but I'm not >> telling you to wait for me). > > Every little helps, even if you don't have time for a thorough review... You

Re: 350-gary-maintain-private-libobj-namespace

2008-01-28 Thread Gary V. Vaughan
On 29 Jan 2008, at 06:45, Ralf Wildenhues wrote: Hi Gary, Hallo Ralf! Thanks for your comments. I haven't reviewed your last two pending patches yet (but I'm not telling you to wait for me). Every little helps, even if you don't have time for a thorough review... What caught my eyes thou

Re: 350-gary-maintain-private-libobj-namespace

2008-01-28 Thread Ralf Wildenhues
Hi Gary, I haven't reviewed your last two pending patches yet (but I'm not telling you to wait for me). What caught my eyes though at a glance was this: * Gary V. Vaughan wrote on Mon, Jan 28, 2008 at 07:38:01PM CET: > +++ b/libltdl/m4/ltdl-libobj.m4 [...] > + > +# Like AC_LIBSOURCES, exce

350-gary-maintain-private-libobj-namespace

2008-01-28 Thread Gary V. Vaughan
Okay to commit? I plan to commit this one in 72 hours (or less with a favourable review) and roll libtool-2.1b. This fixes the last of Eric's recently reported bugs, making a patch to build M4 with nonrecursive libltdl possible :-) from Gary V. Vaughan <[EMAIL PROTECTED]> Unfortunate